Skip to content

API-1843: FeatureGate(d) KMS encryption #2035

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 25, 2025
Merged

API-1843: FeatureGate(d) KMS encryption #2035

merged 2 commits into from
Mar 25, 2025

Conversation

swghosh
Copy link
Member

@swghosh swghosh commented Sep 20, 2024 •
edited
Loading

Adds API fields for KMS based encryption enablement via configv1.APIServer through it's spec.encryptionType,
AWS KMS config added as the initial KMS encryption provider.

This feature is primarily targeted for SelfManagedHA OpenShift and is considered for TechPreview.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 20, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 20, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 20, 2024

Hello @swghosh! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 20, 2024
@swghosh swghosh changed the title FeatureGate KMSv2 API-1843: FeatureGate KMSv2 Sep 23, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 23, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 23, 2024 •
edited by openshift-ci bot
Loading

@swghosh: This pull request references API-1843 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.18.0" version, but no target version was set.

In response to this:

This feature is primarily targeted for SelfManagedHA OpenShift TechPreview.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 25, 2024
@swghosh swghosh marked this pull request as ready for review September 25, 2024 22:49
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 25, 2024
@swghosh swghosh changed the title API-1843: FeatureGate KMSv2 API-1843: FeatureGate for KMS encryption Sep 25, 2024
@openshift-ci openshift-ci bot requested review from bparees and deads2k September 25, 2024 22:49
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 26, 2024
@swghosh
Copy link
Member Author

swghosh commented Sep 26, 2024

/cc @dgrisonnet @tkashem

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 3, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 18, 2024
@openshift-ci openshift-ci bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 18, 2024
@swghosh swghosh changed the title API-1843: FeatureGate for KMS encryption API-1843: FeatureGate(d) KMS encryption Oct 18, 2024
@swghosh swghosh force-pushed the kms-01 branch 2 times, most recently from 793d8ff to f40ab94 Compare October 19, 2024 11:21
@swghosh swghosh mentioned this pull request Oct 22, 2024
Merged
@swghosh
Copy link
Member Author

swghosh commented Mar 12, 2025

/retest

1 similar comment
@swghosh
Copy link
Member Author

swghosh commented Mar 12, 2025

/retest

dgrisonnet
dgrisonnet approved these changes Mar 21, 2025
View reviewed changes
Copy link
Member

@dgrisonnet dgrisonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 21, 2025
@swghosh
Copy link
Member Author

swghosh commented Mar 21, 2025

/retest

@JoelSpeed
Copy link
Contributor

/lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgrisonnet, JoelSpeed, swghosh, tkashem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2025
@swghosh
Copy link
Member Author

swghosh commented Mar 21, 2025

/test all

@swghosh
Copy link
Member Author

swghosh commented Mar 21, 2025 •
edited
Loading

/label acknowledge-critical-fixes-only
(requirement added for the next week: Shift Week)
This is a low risk change and API fields are well gated behind TechPreview. It should not affect our OpenShift payload.

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Mar 21, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 75d64d7 and 2 for PR HEAD 8ada9f6 in total

@swghosh
Copy link
Member Author

swghosh commented Mar 21, 2025

/retest-required

@swghosh
Copy link
Member Author

swghosh commented Mar 21, 2025

/test e2e-aws-ovn-hypershift

@swghosh
Copy link
Member Author

swghosh commented Mar 22, 2025

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 75d64d7 and 2 for PR HEAD 8ada9f6 in total

@swghosh
Copy link
Member Author

swghosh commented Mar 24, 2025

/hold
e2e-aws-ovn-hypershift have been generally failing across
https://sippy.dptools.openshift.org/sippy-ng/jobs/4.19/analysis?filters=%7B%22items%22%3A%5B%7B%22columnField%22%3A%22name%22%2C%22operatorValue%22%3A%22equals%22%2C%22value%22%3A%22periodic-ci-openshift-hypershift-release-4.19-periodics-e2e-aws-ovn%22%7D%5D%7D

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 24, 2025 •
edited
Loading

@swghosh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 8ada9f6 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-azure 8ada9f6 link false /test e2e-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@swghosh
Copy link
Member Author

swghosh commented Mar 24, 2025

/test e2e-aws-ovn-hypershift

@swghosh
Copy link
Member Author

swghosh commented Mar 24, 2025

/remove-hold
permafailing e2e-aws-ovn-hypershift job was supposedly fixed in openshift/hypershift#5881

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 62cf5e9 into openshift:master Mar 25, 2025
21 of 23 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api
This PR has been included in build ose-cluster-config-api-container-v4.19.0-202503250146.p0.g62cf5e9.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bparees bparees Awaiting requested review from bparees

@deads2k deads2k Awaiting requested review from deads2k

@tkashem tkashem Awaiting requested review from tkashem

4 more reviewers

@benluddy benluddy benluddy left review comments

@patrickdillon patrickdillon patrickdillon left review comments

@JoelSpeed JoelSpeed JoelSpeed left review comments

@dgrisonnet dgrisonnet dgrisonnet approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@tkashem tkashem

@JoelSpeed JoelSpeed

@dgrisonnet dgrisonnet

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@swghosh @openshift-ci-robot @JoelSpeed @dgrisonnet @tkashem @openshift-bot @benluddy @patrickdillon @openshift-merge-robot