Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNTRLPLANE-72: remove RoleBindingRestriction CRD from payload #2138

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

CNTRLPLANE-72: remove RoleBindingRestriction CRD from payload #2138

wants to merge 1 commit into from

Conversation

everettraven
Copy link
Contributor

@everettraven everettraven commented Jan 9, 2025 •
edited
Loading

so that it can be managed by the cluster-authentication-operator instead of cluster-version-operator. This enables the cluster-authentication-operator to remove the CRD from the cluster when intentionally taking down the OpenShift OAuth stack.

@everettraven
remove rolebindingrestriction CRD from payload
bb85ed6 
so that it can be managed by the cluster-authentication-operator
instead of cluster-version-operator. This enables the
cluster-authentication-operator to remove the CRD from
the cluster when OIDC authentication is configured.

Signed-off-by: Bryce Palmer <[email protected]>
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 9, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 9, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 9, 2025

Hello @everettraven! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 9, 2025
@everettraven
Copy link
Contributor Author

This needs to wait until we have the changes in place on the cluster-authentication-operator to start managing the CRD.

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 9, 2025
@everettraven everettraven marked this pull request as ready for review January 29, 2025 20:31
@everettraven everettraven changed the title WIP: remove RoleBindingRestriction CRD from payload CNTRLPLANE-72: remove RoleBindingRestriction CRD from payload Jan 29, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 29, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 29, 2025 •
edited by openshift-ci bot
Loading

@everettraven: This pull request references CNTRLPLANE-72 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

so that it can be managed by the cluster-authentication-operator instead of cluster-version-operator. This enables the cluster-authentication-operator to remove the CRD from the cluster when OIDC authentication is configured.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 29, 2025
@openshift-ci openshift-ci bot requested review from deads2k and knobunc January 29, 2025 20:32
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 29, 2025 •
edited by openshift-ci bot
Loading

@everettraven: This pull request references CNTRLPLANE-72 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

so that it can be managed by the cluster-authentication-operator instead of cluster-version-operator. This enables the cluster-authentication-operator to remove the CRD from the cluster when intentionally taking down the OpenShift OAuth stack.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@everettraven
Copy link
Contributor Author

/retest-required

This was referenced Jan 30, 2025
Merged
Merged
@liouk
Copy link
Member

liouk commented Feb 7, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 7, 2025
@everettraven
Copy link
Contributor Author

/retest

@everettraven
Copy link
Contributor Author

openshift/cluster-authentication-operator#748 and openshift/installer#9424 have merged. This should be good to go as long as tests are happy.

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 28, 2025
@everettraven
Copy link
Contributor Author

cc @JoelSpeed for whenever you have time to take a look.

This is part of moving the management of the RoleBindingRestriction CRD to the cluster-authentication-operator. Outlined in openshift/enhancements#1726

@JoelSpeed
Copy link
Contributor

/approve

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: everettraven, JoelSpeed, liouk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f587fb6 and 2 for PR HEAD bb85ed6 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f587fb6 and 2 for PR HEAD bb85ed6 in total

3 similar comments
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f587fb6 and 2 for PR HEAD bb85ed6 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f587fb6 and 2 for PR HEAD bb85ed6 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f587fb6 and 2 for PR HEAD bb85ed6 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD f2caafd and 1 for PR HEAD bb85ed6 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 422203b and 0 for PR HEAD bb85ed6 in total

@openshift-ci-robot
Copy link

/hold

Revision bb85ed6 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 4, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 4, 2025

@everettraven: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn bb85ed6 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-azure bb85ed6 link false /test e2e-azure
ci/prow/e2e-aws-ovn-hypershift bb85ed6 link true /test e2e-aws-ovn-hypershift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@everettraven everettraven mentioned this pull request Mar 12, 2025
Open
4 tasks
@everettraven
Copy link
Contributor Author

/test-with openshift/hypershift#5819 e2e-aws-ovn-hypershift

@everettraven
Copy link
Contributor Author

/testwith e2e-aws-ovn-hypershift openshift/hypershift#5819

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Mar 12, 2025

@everettraven, testwith: Error processing request. ERROR:

could not determine job runs: requested job is invalid. needs to be formatted like: <org>/<repo>/<branch>/<variant?>/<job>. instead it was: e2e-aws-ovn-hypershift

@everettraven
Copy link
Contributor Author

/testwith openshift/api/master/e2e-aws-ovn-hypershift openshift/hypershift#5819

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@knobunc knobunc Awaiting requested review from knobunc

Assignees

@liouk liouk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@everettraven @openshift-ci-robot @liouk @JoelSpeed