DNM: Kueue Operator API Review Part 2 #2250
Conversation
|
Hello @kannon92! Some important instructions when contributing to openshift/api: |
|
/hold |
kannon92
changed the title
openshift-ci
bot
added
do-not-merge/hold
operator/v1alpha1/types_kueue.go
Outdated
| type ByWorkload struct { | ||
| // admission controls how Kueue will process workloads. | ||
| // admission is a required field with policy is set to ByWorkload. | ||
| // admission is only required if policy is specified to ByWorkload. |
There was a problem hiding this comment.
Is this implied by byWorkload being required when policy is set to ByWorkload?
There was a problem hiding this comment.
I suspect both this line and the line before are redundant
operator/v1alpha1/types_kueue.go
Outdated
| type ByWorkload struct { | ||
| // admission controls how Kueue will process workloads. | ||
| // admission is a required field with policy is set to ByWorkload. | ||
| // admission is only required if policy is specified to ByWorkload. |
There was a problem hiding this comment.
I suspect both this line and the line before are redundant
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: everettraven, kannon92 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM |
|
@kannon92: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
We have got more requirements for Operator now.
Opening this up so we can discuss.
Please ignore the other API fields as these have already been approved by @JoelSpeed.