Skip to content

Monitoring API: Add Metric server config #2322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

marioferh
Copy link
Contributor

@marioferh marioferh commented May 15, 2025

First PR: #1929
Related: Enhancements Proposal openshift/enhancements#1627

Copy link
Contributor

openshift-ci bot commented May 15, 2025

Hello @marioferh! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label May 15, 2025
@openshift-ci openshift-ci bot requested review from deads2k and JoelSpeed May 15, 2025 14:08
Copy link
Contributor

openshift-ci bot commented May 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: marioferh
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@marioferh marioferh force-pushed the metrics_server_config_monitoring_api branch from 8592b9b to 4a25999 Compare May 15, 2025 15:39
@marioferh marioferh force-pushed the metrics_server_config_monitoring_api branch from 4a25999 to d2369a1 Compare July 16, 2025 16:45
@marioferh
Copy link
Contributor Author

Signed-off-by: Mario Fernandez <[email protected]>
@marioferh marioferh force-pushed the metrics_server_config_monitoring_api branch from d2369a1 to c38a1eb Compare July 16, 2025 16:47
Signed-off-by: Mario Fernandez <[email protected]>
Signed-off-by: Mario Fernandez <[email protected]>
Signed-off-by: Mario Fernandez <[email protected]>
Copy link
Contributor

openshift-ci bot commented Jul 17, 2025

@marioferh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/verify c8a438c link true /test verify
ci/prow/verify-client-go c8a438c link true /test verify-client-go
ci/prow/integration c8a438c link true /test integration
ci/prow/verify-crd-schema c8a438c link true /test verify-crd-schema

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants