Skip to content

CORS-4096: Add DNS Record Type for IPv6 Domain mapping #2361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion openapi/generated_openapi/zz_generated.openapi.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion openapi/openapi.json
Original file line number Diff line number Diff line change
Expand Up @@ -34908,7 +34908,7 @@
"default": 0
},
"recordType": {
"description": "recordType is the DNS record type. For example, \"A\" or \"CNAME\".",
"description": "recordType is the DNS record type. For example, \"A\", \"AAAA\", or \"CNAME\".",
"type": "string",
"default": ""
},
Expand Down
7 changes: 5 additions & 2 deletions operatoringress/v1/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ type DNSRecordSpec struct {
// +kubebuilder:validation:MinItems=1
// +required
Targets []string `json:"targets"`
// recordType is the DNS record type. For example, "A" or "CNAME".
// recordType is the DNS record type. For example, "A", "AAAA", or "CNAME".
// +required
RecordType DNSRecordType `json:"recordType"`
// recordTTL is the record TTL in seconds. If zero, the default is 30.
Expand Down Expand Up @@ -128,7 +128,7 @@ type DNSZoneCondition struct {
}

// DNSRecordType is a DNS resource record type.
// +kubebuilder:validation:Enum=CNAME;A
// +kubebuilder:validation:Enum=CNAME;A;AAAA
type DNSRecordType string

const (
Expand All @@ -137,6 +137,9 @@ const (

// ARecordType is an RFC 1035 A record.
ARecordType DNSRecordType = "A"

// AAAARecordType is an RFC 3596 AAAA record that is used to map a domain name to an IPv6 address.
AAAARecordType DNSRecordType = "AAAA"
)

// DNSManagementPolicy is a policy for configuring how the dns controller
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,11 +83,12 @@ spec:
minimum: 0
type: integer
recordType:
description: recordType is the DNS record type. For example, "A" or
"CNAME".
description: recordType is the DNS record type. For example, "A",
"AAAA", or "CNAME".
enum:
- CNAME
- A
- AAAA
type: string
targets:
description: targets are record targets.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,11 +84,12 @@ spec:
minimum: 0
type: integer
recordType:
description: recordType is the DNS record type. For example, "A" or
"CNAME".
description: recordType is the DNS record type. For example, "A",
"AAAA", or "CNAME".
enum:
- CNAME
- A
- AAAA
type: string
targets:
description: targets are record targets.
Expand Down
2 changes: 1 addition & 1 deletion operatoringress/v1/zz_generated.swagger_doc_generated.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.