[release-4.19] MCO-1720: Promote MachineConfigNode feature gate to default

[isabella-janssen]

This promotes the MachineConfigNode feature gate to Default in the 4.19 brach.

[openshift-ci-robot]

@isabella-janssen: This pull request references MCO-1720 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

This promotes the MachineConfigNode feature gate to Default in the 4.19 brach.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Hello @isabella-janssen! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[isabella-janssen]

/retest-required

[JoelSpeed]

@isabella-janssen We don't generally backport feature promotions post GA unless there is a very very good reason to do so, what's the motivation here?

[oourfali]

@JoelSpeed Hi! Due to it finalizing in the last minute, the aggreement was to push it via 4.19 z-stream.
Motivation-wise we have several aspects:

1. Appliance - we have a customer interested in getting a support exception for the appliance, which leverages the pinned image set functionality. in order to allow the cluster to get upgraded, we'll need this API GA'ed
2. OVE - It is consuming the appliance as well.
3. There are additional use-cases being discussed at the moment

Overall, the api does exist for a while, and is a mature one. I hope the above clarifies things, but when we saw that we missed 4.19 the agreed plan was to backport.

[isabella-janssen]

/retest-required

[JoelSpeed]

Do we have the associated SBAR for this feature backport that we can link here?

[isabella-janssen]

/hold

Holding while we create an SBAR for this feature & PinnedImage sets.

[isabella-janssen]

/retest-required

[isabella-janssen]

/retest-required

[isabella-janssen]

/retest-required

[isabella-janssen]

/retest-required

[isabella-janssen]

/test verify-feature-promotion

[isabella-janssen]

/retest-required

[isabella-janssen]

/retest-required

[isabella-janssen]

/retest-required

[isabella-janssen]

/test verify-feature-promotion

[isabella-janssen]

/retest-required

[JoelSpeed]

As far as I can tell, some tests have been renamed recetly and those haven't timed out yet.

The only test I can see which doesn't pass enough is [Suite:openshift/machine-config-operator/disruptive][Suite:openshift/conformance/serial][sig-mco][OCPFeatureGate:PinnedImages][OCPFeatureGate:MachineConfigNodes][Serial] Invalid PIS leads to degraded MCN in a standard Pool [apigroup:machineconfiguration.openshift.io] on ha metal amd64 ipv4.

If we can get a few more runs there to see if it comes above 95% I think we are good to promote this

[isabella-janssen]

/retest-required

[isabella-janssen]

As far as I can tell, some tests have been renamed recetly and those haven't timed out yet.

That's correct, they were updated June 26th (openshift/origin#29918).

The only test I can see which doesn't pass enough is [Suite:openshift/machine-config-operator/disruptive][Suite:openshift/conformance/serial][sig-mco][OCPFeatureGate:PinnedImages][OCPFeatureGate:MachineConfigNodes][Serial] Invalid PIS leads to degraded MCN in a standard Pool [apigroup:machineconfiguration.openshift.io] on ha metal amd64 ipv4.

I have some manually triggered runs for that running now, hopefully we can get the passing rate up soon.

Related SBAR can be found here.

Thanks for the continued patience and help throughout this effort @JoelSpeed!

[JoelSpeed]

/test verify-feature-promotion

[isabella-janssen]

/test verify-feature-promotion

[isabella-janssen]

/test verify-feature-promotion

[isabella-janssen]

@JoelSpeed This should be ready for reconsideration.

[yuqi-zhang]

Should be safe to go now that openshift/machine-config-operator#5243 is in 4.19

[isabella-janssen]

/hold

Holding until SBAR is reviewed & approved by Nick Stielau and Kirsten Newcomer.

[JoelSpeed]

/test verify-feature-promotion

[JoelSpeed]

/lgtm
/label backport-risk-assessed
/label jira/valid-bug
/verified-by ci/prow/verify-feature-promotion

/override ci/prow/verify-feature-promotion

Having reviewed sippy, I'm fairly happy that the lanes that have below 95% are from failures over a week ago. Most appeared to be networking/API server comms issues which should be unrelated to this feature

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: isabella-janssen, JoelSpeed, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [JoelSpeed]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-feature-promotion

In response to this:

/lgtm
/label backport-risk-assessed
/label jira/valid-bug
/verified-by ci/prow/verify-feature-promotion

/override ci/prow/verify-feature-promotion

Having reviewed sippy, I'm fairly happy that the lanes that have below 95% are from failures over a week ago. Most appeared to be networking/API server comms issues which should be unrelated to this feature

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[JoelSpeed]

/verified by ci/prow/verify-feature-promotion

[openshift-ci-robot]

@JoelSpeed: This PR has been marked as verified by [ci/prow/verify-feature-promotion](https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_api/2376/pull-ci-openshift-api-release-4.19-verify-feature-promotion/1962892350124462080).

In response to this:

/verified by ci/prow/verify-feature-promotion

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[JoelSpeed]

/hold cancel

SBAR is approved

[JoelSpeed]

/skip

[JoelSpeed]

/test okd-scos-images

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD c9f500d and 2 for PR HEAD 75435dd in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD c9f500d and 2 for PR HEAD 75435dd in total

[JoelSpeed]

/override ci/prow/verify-feature-promotion

[openshift-ci]

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-feature-promotion

In response to this:

/override ci/prow/verify-feature-promotion

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

@isabella-janssen: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify-feature-promotion	75435dd	link	true	/test verify-feature-promotion

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.