OCPNODE-3006:Add clusterimgepolicy/imagepolicy to payload #2384
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
Hello @QiWang19! Some important instructions when contributing to openshift/api: |
|
/test all |
openshift-ci
bot
added
the
size/XXL
openshift-merge-robot
added
the
needs-rebase
QiWang19
force-pushed
the
clusterimagepolicy-v1-payload
branch
from
a794939 to
d31e59b
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/retest-required |
QiWang19
force-pushed
the
clusterimagepolicy-v1-payload
branch
from
d31e59b to
5c43881
Compare
|
/retest-required |
|
/test all |
QiWang19
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@QiWang19: This pull request references OCPNODE-3006 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test all |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
|
@QiWang19: This pull request references OCPNODE-3006 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@JoelSpeed PTAL, tested with openshift/machine-config-operator#5143 and openshift/cluster-update-keys#74 |
|
@QiWang19: This pull request references OCPNODE-3006 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@QiWang19: This pull request references OCPNODE-3006 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Code changes look reasonable here, but I'd expect to see links to the prow runs where you tested these changes with the others? Do you have a PR open to promote the feature gate as a WIP? Would be good to see how the feature gate testing is with the alpha types right now We need to make sure that we are on track for the feature gate to be promoted before we merge this PR |
The tests |
|
WIP PR that promotes the feature gate #2340 |
openshift-merge-robot
added
the
needs-rebase
QiWang19
force-pushed
the
clusterimagepolicy-v1-payload
branch
from
95dc771 to
54e9300
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/test e2e-aws-ovn-techpreview |
|
/testwith openshift/api/master/e2e-aws-ovn-techpreview #2384 openshift/cluster-update-keys#74 openshift/machine-config-operator#5143 |
|
/hold
Required test From the discussion, get in this PR after openshift/cluster-update-keys#76 |
openshift-ci
bot
added
the
do-not-merge/hold
Drop openshift policy to DevPreviewNoUpgrade, so it will not install on TechPreviewNoUpgrade environment during the process moving ClusterImagePolicy to v1 from v1alpha1. Will add openshift policy openshift#74 back after openshift/api#2384 openshift/mco#5143 Signed-off-by: Qi Wang <[email protected]>
QiWang19
force-pushed
the
clusterimagepolicy-v1-payload
branch
from
54e9300 to
14a7df2
Compare
|
/retest-required |
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/lgtm |
|
/retest-required |
Signed-off-by: Qi Wang <[email protected]>
Signed-off-by: Qi Wang <[email protected]>
QiWang19
force-pushed
the
clusterimagepolicy-v1-payload
branch
from
14a7df2 to
60ac3d5
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed, QiWang19 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@QiWang19: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit 98ae8fb
into
openshift:master
|
[ART PR BUILD NOTIFIER] Distgit: ose-cluster-config-api |
Added a commit to drop down the SigstoreImageVerification the gate from all sets
6b81288: Added commit to drop down the SigstoreImageVerification to DevPreview
891ea2a: Test this PR with openshift/machine-config-operator#5143, openshift/cluster-update-keys#74:
techpreviewOn the TechPreviewNoUpgrade cluster,
openshift-tests run-testOCPFeatureGate:SigstoreImageVerificationtests OCPNODE-3454: OCPFeatureGate:SigstoreImageVerification update test on v1 (Cluster)ImagePolicy origin#29973 on the cluster