Skip to content

OCPEDGE-1945: feat: promote HighlyAvailableArbiter feature to default #2401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

eggfoobar
Copy link
Contributor

Promote HighlyAvailableArbiter to the Default featureSet.

HighlyAvailableArbiter allows deploying an OpenShift cluster with 2 master nodes and 1 arbiter node which will be a smaller capacity machine that will run only the required components for HA to be maintained in edge deployments.

Current Pass Rate: Sippy FeatureSet PassRate 100%
Enhancement PR: openshift/enhancements#1674

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 14, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jul 14, 2025

@eggfoobar: This pull request references OCPEDGE-1945 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Promote HighlyAvailableArbiter to the Default featureSet.

HighlyAvailableArbiter allows deploying an OpenShift cluster with 2 master nodes and 1 arbiter node which will be a smaller capacity machine that will run only the required components for HA to be maintained in edge deployments.

Current Pass Rate: Sippy FeatureSet PassRate 100%
Enhancement PR: openshift/enhancements#1674

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Jul 14, 2025

Hello @eggfoobar! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 14, 2025
@openshift-ci openshift-ci bot requested review from cgwalters and JoelSpeed July 14, 2025 09:35
@eggfoobar
Copy link
Contributor Author

/assign @JoelSpeed

Joel, we had originally written a comment that we can not merge this change until we had resolved the tooling issue with having multi feature gates on the same attribute, since you patched this in #2283 would you consider this comment to no longer be relevant? https://github.com/openshift/api/pull/2401/files#diff-a8b6135d50534471326ea7bcd20e0f5eae25353f7788338060f718128a6a0b34L701

@JoelSpeed
Copy link
Contributor

/test verify-feature-promotion

I see tests in sippy, so they should appear here too 🤔

@eggfoobar
Copy link
Contributor Author

/test verify-feature-promotion

I see tests in sippy, so they should appear here too 🤔

Fix incoming, there is a topology diff that causes it not to show up.

updated integration tests to reference baremetal to keep inline with Arbiter and DualReplica main platform use

Signed-off-by: ehila <[email protected]>
added two node topology support for featuregate test analyzer to match and query sippy for two node test history

Signed-off-by: ehila <[email protected]>
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 14, 2025
Copy link
Contributor

openshift-ci bot commented Jul 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: eggfoobar
Once this PR has been reviewed and has the lgtm label, please ask for approval from joelspeed. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eggfoobar
Copy link
Contributor Author

/retest-required

Copy link
Contributor

openshift-ci bot commented Jul 15, 2025

@eggfoobar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 4acf014 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-serial-2of2 4acf014 link true /test e2e-aws-serial-2of2
ci/prow/e2e-aws-ovn-techpreview 4acf014 link true /test e2e-aws-ovn-techpreview
ci/prow/e2e-aws-serial-1of2 4acf014 link true /test e2e-aws-serial-1of2
ci/prow/verify-feature-promotion 4acf014 link true /test verify-feature-promotion
ci/prow/minor-e2e-upgrade-minor 4acf014 link true /test minor-e2e-upgrade-minor

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants