-
Notifications
You must be signed in to change notification settings - Fork 551
OCPEDGE-1945: feat: promote HighlyAvailableArbiter feature to default #2401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
OCPEDGE-1945: feat: promote HighlyAvailableArbiter feature to default #2401
Conversation
Signed-off-by: ehila <[email protected]>
@eggfoobar: This pull request references OCPEDGE-1945 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Hello @eggfoobar! Some important instructions when contributing to openshift/api: |
/assign @JoelSpeed Joel, we had originally written a comment that we can not merge this change until we had resolved the tooling issue with having multi feature gates on the same attribute, since you patched this in #2283 would you consider this comment to no longer be relevant? https://github.com/openshift/api/pull/2401/files#diff-a8b6135d50534471326ea7bcd20e0f5eae25353f7788338060f718128a6a0b34L701 |
/test verify-feature-promotion I see tests in sippy, so they should appear here too 🤔 |
Fix incoming, there is a topology diff that causes it not to show up. |
updated integration tests to reference baremetal to keep inline with Arbiter and DualReplica main platform use Signed-off-by: ehila <[email protected]>
added two node topology support for featuregate test analyzer to match and query sippy for two node test history Signed-off-by: ehila <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: eggfoobar The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest-required |
@eggfoobar: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Promote HighlyAvailableArbiter to the Default featureSet.
HighlyAvailableArbiter allows deploying an OpenShift cluster with 2 master nodes and 1 arbiter node which will be a smaller capacity machine that will run only the required components for HA to be maintained in edge deployments.
Current Pass Rate: Sippy FeatureSet PassRate 100%
Enhancement PR: openshift/enhancements#1674