-
Notifications
You must be signed in to change notification settings - Fork 58
NO-ISSUE: Bump the go-dependencies group across 1 directory with 4 updates #843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,27 +1,25 @@ | ||
| module github.com/openshift/assisted-image-service | ||
|
|
||
| go 1.25.0 | ||
|
|
||
| toolchain go1.25.5 | ||
| go 1.25.7 | ||
|
|
||
| require ( | ||
| github.com/cavaliercoder/go-cpio v0.0.0-20180626203310-925f9528c45e | ||
| github.com/diskfs/go-diskfs v1.7.1-0.20251217162235-58541aa8f559 | ||
| github.com/diskfs/go-diskfs v1.9.1 | ||
| github.com/go-chi/chi/v5 v5.2.5 | ||
| github.com/google/renameio v1.0.1 | ||
| github.com/google/uuid v1.6.0 | ||
| github.com/hashicorp/go-version v1.8.0 | ||
| github.com/hashicorp/go-version v1.9.0 | ||
| github.com/kelseyhightower/envconfig v1.4.0 | ||
| github.com/onsi/ginkgo v1.16.5 | ||
| github.com/onsi/gomega v1.39.1 | ||
| github.com/onsi/gomega v1.40.0 | ||
| github.com/pkg/errors v0.9.1 | ||
| github.com/prometheus/client_golang v1.23.2 | ||
| github.com/rs/cors v1.11.1 | ||
| github.com/sirupsen/logrus v1.9.4 | ||
| github.com/slok/go-http-metrics v0.13.0 | ||
| github.com/thoas/go-funk v0.9.3 | ||
| go.uber.org/mock v0.6.0 | ||
| golang.org/x/sync v0.19.0 | ||
| golang.org/x/sync v0.20.0 | ||
| ) | ||
|
|
||
| require ( | ||
|
|
@@ -36,11 +34,10 @@ require ( | |
| github.com/munnerz/goautoneg v0.0.0-20191010083416-a7dc8b61c822 // indirect | ||
| github.com/nxadm/tail v1.4.8 // indirect | ||
| github.com/pierrec/lz4/v4 v4.1.17 // indirect | ||
| github.com/pkg/xattr v0.4.9 // indirect | ||
| github.com/pkg/xattr v0.4.12 // indirect | ||
| github.com/prometheus/client_model v0.6.2 // indirect | ||
|
Comment on lines
36
to
38
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Review indirect
If there are no tests covering xattr, consider adding a minimal unit/integration test (guarded/skipped when unsupported) to reduce risk from subtle behavior changes. 🤖 Prompt for AI Agents |
||
| github.com/prometheus/common v0.66.1 // indirect | ||
| github.com/prometheus/procfs v0.16.1 // indirect | ||
| github.com/rogpeppe/go-internal v1.11.0 // indirect | ||
| github.com/ulikunitz/xz v0.5.15 // indirect | ||
| go.yaml.in/yaml/v2 v2.4.2 // indirect | ||
| go.yaml.in/yaml/v3 v3.0.4 // indirect | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: openshift/assisted-image-service
Length of output: 147
🏁 Script executed:
Repository: openshift/assisted-image-service
Length of output: 1050
🏁 Script executed:
Repository: openshift/assisted-image-service
Length of output: 1321
Update CI configuration: go.mod requires Go 1.25.7 but CI is pinned to Go 1.21.
You bumped
go 1.25.7ingo.mod(Line 3) and removed thetoolchaindirective. However,.ci-operator.yamlstill specifiesgolang-1.21in its build root image:This causes a version mismatch: the module declares a minimum Go version of 1.25.7, but CI uses 1.21. Builds will fail in CI with "go requires go 1.25.7" errors.
Required fixes:
.ci-operator.yamlto usegolang-1.25(or1.25.7if available) instead ofgolang-1.21.Dockerfile.image-service-buildto pin the go-toolset version more precisely (currently uses1.25, which may not guarantee 1.25.7).toolchain go1.25.7ingo.mod(or ensure CI/dev environments will not accidentally use an older Go).🤖 Prompt for AI Agents