OCPBUGS-83862: Raise minor_min to 4.20.25 and add conditional update risk for 4.21.0-25 - #10047
OCPBUGS-83862: Raise minor_min to 4.20.25 and add conditional update risk for 4.21.0-25#10047shahsahil264 wants to merge 2 commits into
Conversation
….21.0-25 Warn clusters with KubeletConfigs upgrading from 4.20.24 or earlier to any existing 4.21.z that auto-sizing-disabled MachineConfigs may override KubeletConfig autosizing settings on custom MachineConfigPool nodes. Uses PromQL matching on apiserver_storage_objects to scope the risk to clusters that have KubeletConfigs, per Trevor's recommendation. The fix (openshift/machine-config-operator#5885) shipped in 4.20.25. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Sahil Shah <sahshah@redhat.com>
openshift-ci-robot
added
jira/severity-important
|
@shahsahil264: This pull request references Jira Issue OCPBUGS-83862, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: shahsahil264 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@shahsahil264: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/assign @wking |
| @@ -1,5 +1,5 @@ | |||
| default: | |||
| minor_min: 4.20.15 | |||
| minor_min: 4.20.25 | |||
There was a problem hiding this comment.
Poking into the implementation, I don't think 4.20.25 is sufficient, and I've reported the issue as OCPBUGS-99650 . I don't think we should be raising the floor until we know when it's actually fixed. And given the low impact rate and the number of clusters who would be updated by a floor-raise, it might be too late in the 4.20.z lifecycle to declare at all?
There was a problem hiding this comment.
I don't think we should be raising the floor until we know when it's actually fixed.
Agree.
And given the low impact rate and the number of clusters who would be updated by a floor-raise, it might be too late in the 4.20.z lifecycle to declare at all?
Yes, it's a larger ask. Definitely something to ponder about a little bit before introducing.
| @@ -0,0 +1,13 @@ | |||
| to: 4.21.9 | |||
| from: ^4[.]20[.](1?[0-9]|2[0-4])[+].*$ | |||
| url: https://redhat.atlassian.net/browse/OCPBUGS-83862 | |||
There was a problem hiding this comment.
Currently, the https://redhat.atlassian.net/browse/OCPBUGS-83862 has a security level assigned.
This will hinder the url's purpose, making it less useful for folks interested in more information. Meaning, we can either create a new impact statement jira with public-facing information, or the bug can be evaluated to see whether the assigned security level is justified or whether it can be open to the public (assuming the bug's description is helpful for the conditional risk).
There was a problem hiding this comment.
Currently, not that actionable because of #10047 (comment), but it is something to address before merging if we decide to merge the PR.
There was a problem hiding this comment.
83862 seems open to everyone now.
I will probably still create "a new impact statement jira" to save the energy of our users on jumping between two bugs OCPBUGS-83862 and OCPBUGS-99650.
I will update the link soon.
|
/hold We will wait until the fix is available for main and all previous releases to 4.20. |
openshift-ci
Bot
added
the
do-not-merge/hold
6 participants
Summary
Combined PR: raises
minor_minfrom 4.20.15 to 4.20.25 for future 4.21.z builds, and adds conditional update risk for all existing 4.21.z GA releases (4.21.0 through 4.21.25).Cherry-picks the build-suggestions change from #9494 (by @aksjadha) and adds the companion blocked-edge files requested by @sdodson and @wking.
Replaces #9494 and #10046.
Bug
OCPBUGS-83862: During upgrade from pre-4.20.25,
auto-sizing-disabledMachineConfigs override KubeletConfig autosizing settings on custom MachineConfigPool nodes. Fixed in 4.20.25 via openshift/machine-config-operator#5885.Risk details
^4[.]20[.](1?[0-9]|2[0-4])[+].*$— matches 4.20.0 through 4.20.24apiserver_storage_objects(per Trevor's recommendation — 26k clusters without KubeletConfigs won't see the warning)