Skip to content

Conversation

@michaelalang
Copy link

The Cluster DNS Operator can wait for the PR to merged and backported or alternatively implement response type specific cache settings by utilizing TTL and minimum TTL as shown in this PR

# current dns.Operator overwrites
cache <ttl> {
    denial <maxrec> <ttl> 
}
# propsed dns.Operator overwrites
cache {
     success <maxrec> <ttl> <minttl>
     denial <maxrec> <ttl> <minttl>
}

The resource specific overwrites can take the minimum TTL which will end in resource record responses as increased/lowered TTL for the record and remove the burden of overloading upstream DNS queries.

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 10, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign knobunc for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 10, 2025

Hi @michaelalang. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@michaelalang michaelalang changed the title OCPBUGS-62919 implement response type specific cache settings OCPBUGS-62919: implement response type specific cache settings Oct 10, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 10, 2025
@openshift-ci-robot
Copy link
Contributor

@michaelalang: This pull request references Jira Issue OCPBUGS-62919, which is invalid:

  • expected the bug to target either version "4.21." or "openshift-4.21.", but it targets "4.20" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The Cluster DNS Operator can wait for the PR to merged and backported or alternatively implement response type specific cache settings by utilizing TTL and minimum TTL as shown in this PR

# current dns.Operator overwrites
cache <ttl> {
   denial <maxrec> <ttl> 
}
# propsed dns.Operator overwrites
cache {
     success <maxrec> <ttl> <minttl>
     denial <maxrec> <ttl> <minttl>
}

The resource specific overwrites can take the minimum TTL which will end in resource record responses as increased/lowered TTL for the record and remove the burden of overloading upstream DNS queries.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@michaelalang
Copy link
Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 10, 2025
@openshift-ci-robot
Copy link
Contributor

@michaelalang: This pull request references Jira Issue OCPBUGS-62919, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.0) matches configured target version for branch (4.21.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @lihongan

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from lihongan October 10, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants