Skip to content

Conversation

pliurh
Copy link
Contributor

@pliurh pliurh commented Jul 28, 2025

This change introduces a mechanism to provide hidden or experimental configuration to OVN-Kubernetes through a ConfigMap. This provides a flexible way to enable advanced or experimental OVN-Kubernetes features without modifying the CNO API.

A new ConfigMap 'ovn-kubernetes-config-overrides', is now read by the operator during the bootstrap process. The key-value data from this ConfigMap is passed down to the OVN-K components.

As an initial implementation, this is used to support the flag 'udn-isolation-mode' which is to enable user to select the UDN isolation mode between 'loose' and 'strict'. If unset, the default mode is 'strict'.

@pliurh
Copy link
Contributor Author

pliurh commented Jul 28, 2025

This PR is to replace #2714, by providing a more generic approach for OVN-K configuration override.

@danwinship
Copy link
Contributor

Should we try to merge the various other one-off ConfigMaps into this one?

@jcaamano
Copy link
Contributor

Should we try to merge the various other one-off ConfigMaps into this one?

Probably not worth it? Even if unsupported, it would probably be not nice if we just dropped the old config maps without chasing down people or unofficial documentation this might be referenced from? It might be best to just let them be until they are removed.

@pliurh pliurh force-pushed the cm-enforcing-udn-loose-isolation branch from 428f44a to 0d41528 Compare July 28, 2025 13:11
@pliurh
Copy link
Contributor Author

pliurh commented Jul 29, 2025

/retest-required

@pliurh pliurh changed the title Allow overriding OVN-Kubernetes configuration OCPBUGS-55962: Allow overriding OVN-Kubernetes configuration Jul 29, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jul 29, 2025
@openshift-ci-robot
Copy link
Contributor

@pliurh: This pull request references Jira Issue OCPBUGS-55962, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @Meina-rh

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This change introduces a mechanism to provide hidden or experimental configuration to OVN-Kubernetes through a ConfigMap. This provides a flexible way to enable advanced or experimental OVN-Kubernetes features without modifying the CNO API.

A new ConfigMap 'ovn-kubernetes-config-overrides', is now read by the operator during the bootstrap process. The key-value data from this ConfigMap is passed down to the OVN-K components.

As an initial implementation, this is used to support the flag 'udn-isolation-mode' which is to enable user to select the UDN isolation mode between 'loose' and 'strict'. If unset, the default mode is 'strict'.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from Meina-rh July 29, 2025 04:07
@pliurh pliurh force-pushed the cm-enforcing-udn-loose-isolation branch 5 times, most recently from e2d75dc to c46fc16 Compare July 29, 2025 13:48
@pliurh
Copy link
Contributor Author

pliurh commented Jul 30, 2025

/retest-required

2 similar comments
@pliurh
Copy link
Contributor Author

pliurh commented Jul 31, 2025

/retest-required

@pliurh
Copy link
Contributor Author

pliurh commented Aug 1, 2025

/retest-required

@jcaamano
Copy link
Contributor

jcaamano commented Aug 5, 2025

/retest

3 similar comments
@jcaamano
Copy link
Contributor

jcaamano commented Aug 5, 2025

/retest

@jcaamano
Copy link
Contributor

jcaamano commented Aug 6, 2025

/retest

@jcaamano
Copy link
Contributor

jcaamano commented Aug 7, 2025

/retest

@pliurh pliurh force-pushed the cm-enforcing-udn-loose-isolation branch from c46fc16 to cd0925e Compare August 12, 2025 04:40
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2025
@pliurh
Copy link
Contributor Author

pliurh commented Aug 13, 2025

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 6688e9a and 1 for PR HEAD 1df74c4 in total

@pliurh
Copy link
Contributor Author

pliurh commented Aug 15, 2025

/retest-required

1 similar comment
@pliurh
Copy link
Contributor Author

pliurh commented Aug 18, 2025

/retest-required

@jcaamano
Copy link
Contributor

/override ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-local-gw

Copy link
Contributor

openshift-ci bot commented Aug 18, 2025

@jcaamano: Overrode contexts on behalf of jcaamano: ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-local-gw

In response to this:

/override ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-local-gw

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jcaamano
Copy link
Contributor

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 6688e9a and 2 for PR HEAD 1df74c4 in total

@jcaamano
Copy link
Contributor

/retest-required

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 6688e9a and 2 for PR HEAD 1df74c4 in total

@jcaamano
Copy link
Contributor

/override ci/prow/e2e-ovn-ipsec-step-registry
https://issues.redhat.com/browse/OCPBUGS-57477

Copy link
Contributor

openshift-ci bot commented Aug 19, 2025

@jcaamano: Overrode contexts on behalf of jcaamano: ci/prow/e2e-ovn-ipsec-step-registry

In response to this:

/override ci/prow/e2e-ovn-ipsec-step-registry
https://issues.redhat.com/browse/OCPBUGS-57477

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Aug 19, 2025

@pliurh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 c46fc16 link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/4.20-upgrade-from-stable-4.19-e2e-gcp-ovn-upgrade 1df74c4 link false /test 4.20-upgrade-from-stable-4.19-e2e-gcp-ovn-upgrade
ci/prow/e2e-aws-ovn-serial 1df74c4 link false /test e2e-aws-ovn-serial
ci/prow/e2e-aws-hypershift-ovn-kubevirt 1df74c4 link false /test e2e-aws-hypershift-ovn-kubevirt
ci/prow/4.20-upgrade-from-stable-4.19-e2e-azure-ovn-upgrade 1df74c4 link false /test 4.20-upgrade-from-stable-4.19-e2e-azure-ovn-upgrade
ci/prow/security 1df74c4 link false /test security
ci/prow/okd-scos-e2e-aws-ovn 1df74c4 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@pliurh
Copy link
Contributor Author

pliurh commented Aug 19, 2025

/retest-required

@jcaamano
Copy link
Contributor

/override ci/prow/e2e-gcp-ovn
https://issues.redhat.com/browse/OCPBUGS-59496

Copy link
Contributor

openshift-ci bot commented Aug 19, 2025

@jcaamano: Overrode contexts on behalf of jcaamano: ci/prow/e2e-gcp-ovn

In response to this:

/override ci/prow/e2e-gcp-ovn
https://issues.redhat.com/browse/OCPBUGS-59496

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tssurya
Copy link
Contributor

tssurya commented Aug 19, 2025

/test e2e-metal-ipi-ovn-ipv6-ipsec

@jcaamano
Copy link
Contributor

/override ci/prow/e2e-metal-ipi-ovn-dualstack-bgp
https://issues.redhat.com/browse/OCPBUGS-57477

Copy link
Contributor

openshift-ci bot commented Aug 19, 2025

@jcaamano: Overrode contexts on behalf of jcaamano: ci/prow/e2e-metal-ipi-ovn-dualstack-bgp

In response to this:

/override ci/prow/e2e-metal-ipi-ovn-dualstack-bgp
https://issues.redhat.com/browse/OCPBUGS-57477

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 6688e9a and 2 for PR HEAD 1df74c4 in total

@kyrtapz
Copy link
Contributor

kyrtapz commented Aug 19, 2025

Copy link
Contributor

openshift-ci bot commented Aug 19, 2025

@kyrtapz: Overrode contexts on behalf of kyrtapz: ci/prow/e2e-azure-ovn-upgrade

In response to this:

/override ci/prow/e2e-azure-ovn-upgrade
https://issues.redhat.com/browse/OCPBUGS-57477
https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_cluster-network-operator/2752/pull-ci-openshift-cluster-network-operator-master-e2e-azure-ovn-upgrade/1957719190982889472

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 76c7185 into openshift:master Aug 19, 2025
34 of 40 checks passed
@openshift-ci-robot
Copy link
Contributor

@pliurh: Jira Issue OCPBUGS-55962: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-55962 has not been moved to the MODIFIED state.

In response to this:

This change introduces a mechanism to provide hidden or experimental configuration to OVN-Kubernetes through a ConfigMap. This provides a flexible way to enable advanced or experimental OVN-Kubernetes features without modifying the CNO API.

A new ConfigMap 'ovn-kubernetes-config-overrides', is now read by the operator during the bootstrap process. The key-value data from this ConfigMap is passed down to the OVN-K components.

As an initial implementation, this is used to support the flag 'udn-isolation-mode' which is to enable user to select the UDN isolation mode between 'loose' and 'strict'. If unset, the default mode is 'strict'.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: cluster-network-operator
This PR has been included in build cluster-network-operator-container-v4.20.0-202508192020.p0.g76c7185.assembly.stream.el9.
All builds following this will include this PR.

@jcaamano
Copy link
Contributor

/cherry-pick release-4.19

@openshift-cherrypick-robot

@jcaamano: new pull request created: #2781

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants