Skip to content

OCPBUGS-60264: Fix multus webhook match condition for spec changes #2772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 14, 2025
Merged

OCPBUGS-60264: Fix multus webhook match condition for spec changes #2772

merged 1 commit into from
Aug 14, 2025

Conversation

kyrtapz
Copy link
Contributor

@kyrtapz kyrtapz commented Aug 8, 2025 •
edited
Loading

Update the CreateDeleteOrUpdatedSpec match condition to properly handle cases where spec field is removed or added.
Fixes #2771
cc: @jcaamano

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 8, 2025
@openshift-ci-robot
Copy link
Contributor

@kyrtapz: This pull request references Jira Issue OCPBUGS-60264, which is invalid:

  • expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Update the CreateDeleteOrUpdatedSpec match condition to properly handle cases where spec field is removed or added.

cc: @jcaamano

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kyrtapz
Copy link
Contributor Author

kyrtapz commented Aug 8, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 8, 2025
@openshift-ci-robot
Copy link
Contributor

@kyrtapz: This pull request references Jira Issue OCPBUGS-60264, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2025
@kyrtapz kyrtapz force-pushed the fix_multus_webhook_match_conditions branch from 7ad5f79 to 3cabb3a Compare August 8, 2025 15:36
@kyrtapz
Copy link
Contributor Author

kyrtapz commented Aug 8, 2025

I manually verified it works with NADs without specs.

kyrtapz
kyrtapz commented Aug 8, 2025
View reviewed changes
@openshift-ci-robot
Copy link
Contributor

@kyrtapz: This pull request references Jira Issue OCPBUGS-60264, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

In response to this:

Update the CreateDeleteOrUpdatedSpec match condition to properly handle cases where spec field is removed or added.
Fixes #2771
cc: @jcaamano

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kyrtapz
Copy link
Contributor Author

kyrtapz commented Aug 11, 2025

/retest

@kyrtapz
Fix multus webhook match condition for spec changes
14e6a13 
Update the CreateDeleteOrUpdatedSpec match condition to properly handle
cases where spec field is removed or added.

Signed-off-by: Patryk Diak <[email protected]>
@kyrtapz kyrtapz force-pushed the fix_multus_webhook_match_conditions branch from 3cabb3a to 14e6a13 Compare August 11, 2025 15:17
@kyrtapz
Copy link
Contributor Author

kyrtapz commented Aug 12, 2025

/retest

@jcaamano
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcaamano, kyrtapz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 5df0166 and 2 for PR HEAD 14e6a13 in total

@kyrtapz
Copy link
Contributor Author

kyrtapz commented Aug 12, 2025

/cherry-pick release-4.19

@openshift-cherrypick-robot
Copy link

@kyrtapz: once the present PR merges, I will cherry-pick it on top of release-4.19 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 5df0166 and 2 for PR HEAD 14e6a13 in total

1 similar comment
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 5df0166 and 2 for PR HEAD 14e6a13 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 67399b9 and 1 for PR HEAD 14e6a13 in total

@jcaamano
Copy link
Contributor

/retest

@kyrtapz
Copy link
Contributor Author

kyrtapz commented Aug 13, 2025

/override ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-local-gw
https://issues.redhat.com/browse/OCPBUGS-60455

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 13, 2025

@kyrtapz: Overrode contexts on behalf of kyrtapz: ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-local-gw

In response to this:

/override ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-local-gw
https://issues.redhat.com/browse/OCPBUGS-60455

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 67399b9 and 2 for PR HEAD 14e6a13 in total

1 similar comment
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 67399b9 and 2 for PR HEAD 14e6a13 in total

@kyrtapz
Copy link
Contributor Author

kyrtapz commented Aug 14, 2025

/retest-required

@jcaamano
Copy link
Contributor

jcaamano commented Aug 14, 2025 •
edited
Loading

[sig-network] Services should be rejected for evicted pods (no endpoints exist) [Suite:openshift/conformance/parallel] [Suite:k8s] flakes a lot and there is already a bug for it https://issues.redhat.com/browse/OCPBUGS-57665
I would be willing to override.
https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_cluster-network-operator/2772/pull-ci-openshift-cluster-network-operator-master-e2e-aws-ovn-upgrade/1955931421952446464

@jcaamano
Copy link
Contributor

This one [sig-network] pods should successfully create sandboxes by writing network status is interesting but I don't think it is related.
https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_cluster-network-operator/2772/pull-ci-openshift-cluster-network-operator-master-4.20-upgrade-from-stable-4.19-e2e-gcp-ovn-upgrade/1955587405822038016

@jcaamano
Copy link
Contributor

/retest

@jcaamano
Copy link
Contributor

This one [sig-network] pods should successfully create sandboxes by writing network status is interesting but I don't think it is related. https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_cluster-network-operator/2772/pull-ci-openshift-cluster-network-operator-master-4.20-upgrade-from-stable-4.19-e2e-gcp-ovn-upgrade/1955587405822038016

node-identity related?

failed calling webhook "pod.network-node-identity.openshift.io": failed to call webhook: Post "https://127.0.0.1:9743/pod?timeout=10s": dial tcp 127.0.0.1:9743: connect: connection refused

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 67399b9 and 2 for PR HEAD 14e6a13 in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 14, 2025

@kyrtapz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn-dualstack-primaryv6 3cabb3a link false /test e2e-vsphere-ovn-dualstack-primaryv6
ci/prow/4.20-upgrade-from-stable-4.19-e2e-gcp-ovn-upgrade 14e6a13 link false /test 4.20-upgrade-from-stable-4.19-e2e-gcp-ovn-upgrade
ci/prow/4.20-upgrade-from-stable-4.19-e2e-azure-ovn-upgrade 14e6a13 link false /test 4.20-upgrade-from-stable-4.19-e2e-azure-ovn-upgrade
ci/prow/e2e-aws-ovn-serial 14e6a13 link false /test e2e-aws-ovn-serial
ci/prow/okd-scos-e2e-aws-ovn 14e6a13 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-vsphere-ovn-dualstack 14e6a13 link false /test e2e-vsphere-ovn-dualstack
ci/prow/e2e-vsphere-ovn 14e6a13 link false /test e2e-vsphere-ovn
ci/prow/security 14e6a13 link false /test security
ci/prow/e2e-aws-hypershift-ovn-kubevirt 14e6a13 link false /test e2e-aws-hypershift-ovn-kubevirt
ci/prow/e2e-azure-ovn 14e6a13 link false /test e2e-azure-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 6688e9a into openshift:master Aug 14, 2025
31 of 40 checks passed
@openshift-ci-robot
Copy link
Contributor

@kyrtapz: Jira Issue OCPBUGS-60264: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-60264 has been moved to the MODIFIED state.

In response to this:

Update the CreateDeleteOrUpdatedSpec match condition to properly handle cases where spec field is removed or added.
Fixes #2771
cc: @jcaamano

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot
Copy link

@kyrtapz: new pull request created: #2777

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Aug 14, 2025
Merged
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: cluster-network-operator
This PR has been included in build cluster-network-operator-container-v4.20.0-202508150152.p0.g6688e9a.assembly.stream.el9.
All builds following this will include this PR.

@bmangoen bmangoen mentioned this pull request Aug 21, 2025
Closed
6 tasks
@mkralik3 mkralik3 mentioned this pull request Aug 27, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anuragthehatter anuragthehatter Awaiting requested review from anuragthehatter

@arghosh93 arghosh93 Awaiting requested review from arghosh93

@danwinship danwinship Awaiting requested review from danwinship

1 more reviewer

@jcaamano jcaamano jcaamano left review comments

Reviewers whose approvals may not affect merge requirements
Assignees

@jcaamano jcaamano

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error while validating NetworkAttachmentDefinition with empty spec
5 participants
@kyrtapz @openshift-ci-robot @jcaamano @openshift-cherrypick-robot @openshift-bot