OCPBUGS-54766: rename OVNKubernetesNodeOVSOverflowKernel #2779
Conversation
because as per Adrian Moreno: "This alarm is great and we need visibility into these packet drops. Actually, it's already surfacing some customer issues that would otherwise stay undetected. The mild problem, however, is the naming. Technically, there are many possible reasons for the `ovs_vswitchd_dp_flows_lookup_lost` metric to increase, not just an overflow in the netlink socket (as the name of the alarm suggests). In fact, I have written a KB article listing some of them: https://access.redhat.com/articles/7115263. I'm opening this bug for us to consider renaming it as something more accurate (and less scary), e.g: OVNKubernetesNodeOVSDpLostPacket." The alert name is misleading and may indicate a bug where in reality, its just we ran out of space to process new flows and therefore drop packets. Signed-off-by: Martin Kennelly <[email protected]>
openshift-ci-robot
added
jira/valid-reference
|
@martinkennelly: This pull request references Jira Issue OCPBUGS-54766, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@martinkennelly: This pull request references Jira Issue OCPBUGS-54766, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
Simple change for you @kyrtapz to close a bug we have thats normal prio. |
|
@ahardin-rh do we have docs that reference this alert ? May need updating. We also have to search for any kcs on this alert and update. I'll do this. |
|
/retest |
1 similar comment
|
/retest |
|
@martinkennelly: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Asking Adrian for +1 |
|
Pingd Adrian but hes on PTO. Waiting. |
|
New name looks good to me, thanks. |
|
/assign @kyrtapz |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kyrtapz, martinkennelly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/jira refresh The requirements for Jira bugs have changed (Jira issues linked to PRs on main branch need to target different OCP), recalculating validity. |
openshift-ci-robot
added
jira/invalid-bug
|
@openshift-bot: This pull request references Jira Issue OCPBUGS-54766, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@kyrtapz can you over ride the bgp job - its unrelated. thanks. |
|
/override ci/prow/e2e-metal-ipi-ovn-dualstack-bgp-local-gw unrelated |
|
@martinkennelly: martinkennelly unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers openshift-sustaining-engineers. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test e2e-metal-ipi-ovn-dualstack-bgp-local-gw Looks like its passing again |
|
/tide refresh |
5 participants
because as per Adrian Moreno:
"This alarm is great and we need visibility
into these packet drops. Actually, it's already
surfacing some customer issues that would
otherwise stay undetected.
The mild problem, however, is the naming.
Technically, there are many possible reasons
for the
ovs_vswitchd_dp_flows_lookup_lostmetric to increase, not just an overflow in the netlinksocket (as the name of the alarm suggests).
In fact, I have written a KB article listing some
of them: https://access.redhat.com/articles/7115263. I'm opening this bug for us to consider renaming it as something more accurate (and less scary),
e.g: OVNKubernetesNodeOVSDpLostPacket."
The alert name is misleading and may indicate a bug where in reality, its just we ran out of space to
process new flows and therefore drop packets.