CORS-4200: Accept the GCP service endpoints #2789
Conversation
pkg/network/cloud_network.go: ** Accept the GCP service endpoints. Use the compute endpoint override (if it exists) to set the API URL. This value is passed to cloud-network-config-controller to be used when the GCP compute service is created, so that all requests to the api are sent via this url rather than the default.
openshift-ci-robot
added
the
jira/valid-reference
|
@barbacbd: This pull request references CORS-4200 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: barbacbd The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
4 similar comments
|
/retest-required |
|
/retest-required |
|
/retest-required |
|
/retest-required |
|
@barbacbd: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| if cloudBootstrapResult.PlatformType == v1.GCPPlatformType { | ||
| for _, ep := range cloudBootstrapResult.PlatformStatus.GCP.ServiceEndpoints { | ||
| if ep.Name == configv1.GCPServiceEndpointNameCompute { | ||
| apiurl = ep.URL |
There was a problem hiding this comment.
So here we're setting apiurl to the last cloudBootstrapResult.PlatformStatus.GCP.ServiceEndpoints whose name is configv1.GCPServiceEndpointNameCompute. Are we expecting multiple endpoints to match? Can we just break out of the loop after the first match?
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
pkg/network/cloud_network.go:
** Accept the GCP service endpoints. Use the compute endpoint override (if it exists) to set the API URL. This value is passed to cloud-network-config-controller to be used when the GCP compute service is created, so that all requests to the api are sent via this url rather than the default.