Skip to content

Conversation

lance5890
Copy link
Contributor

@lance5890 lance5890 commented Sep 16, 2025

As we use kubectl logs -n openshift-ovn-kubernetes ovnkube-control-plane-xxx, we see the default container logs is kube-rbac-proxy, like :

kubectl logs -n openshift-ovn-kubernetes ovnkube-control-plane-7948b585d4-wc7m4 
Defaulted container "kube-rbac-proxy" out of: kube-rbac-proxy, ovnkube-cluster-manager
2025-07-07T04:27:01+00:00 INFO: ovn-control-plane-metrics-certs mounted, starting kube-rbac-proxy
W0707 04:27:01.354951       1 deprecated.go:66] 
==== Removed Flag Warning ======================

logtostderr is removed in the k8s upstream and has no effect any more.

===============================================

I0707 04:27:01.356349       1 kube-rbac-proxy.go:233] Valid token audiences: 
I0707 04:27:01.356401       1 kube-rbac-proxy.go:347] Reading certificate files
I0707 04:27:01.356776       1 kube-rbac-proxy.go:395] Starting TCP socket on :9108
I0707 04:27:01.357087       1 kube-rbac-proxy.go:402] Listening securely on :9108

But most of the time we just care about the container ovnkube-cluster-manager logs , not the kube-rbac-proxy

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 16, 2025
Copy link
Contributor

openshift-ci bot commented Sep 16, 2025

Hi @lance5890. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot requested review from pliurh and ricky-rav September 16, 2025 01:23
Copy link
Contributor

@ricky-rav ricky-rav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I didn't know about this annotation! Could you apply the same changes also to bindata/network/ovn-kubernetes/managed/ovnkube-control-plane.yaml?

Bonus point:
Could we also do the same for ovnkube-node.yaml (self-hosted and managed) and set ovnkube-controller as the default container? That would be amazing.

Thanks! :)

@lance5890 lance5890 force-pushed the set_default_container branch from ef05ae1 to 4319a6b Compare October 2, 2025 23:50
@lance5890
Copy link
Contributor Author

Nice, I didn't know about this annotation! Could you apply the same changes also to bindata/network/ovn-kubernetes/managed/ovnkube-control-plane.yaml?

Bonus point: Could we also do the same for ovnkube-node.yaml (self-hosted and managed) and set ovnkube-controller as the default container? That would be amazing.

Thanks! :)

that makes sense, done!

@lance5890 lance5890 force-pushed the set_default_container branch from 4319a6b to fe94807 Compare October 3, 2025 08:04
Copy link
Contributor

@ricky-rav ricky-rav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@ricky-rav
Copy link
Contributor

@kyrtapz PTAL

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 3, 2025
@kyrtapz
Copy link
Contributor

kyrtapz commented Oct 3, 2025

Thanks @lance5890!
/ok-to-test
/approve

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 3, 2025
Copy link
Contributor

openshift-ci bot commented Oct 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kyrtapz, lance5890, ricky-rav

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyrtapz
Copy link
Contributor

kyrtapz commented Oct 3, 2025

/retitle NO-JIRA: set ovnkube-cluster-manager as default container

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 3, 2025
@openshift-ci openshift-ci bot changed the title set ovnkube-cluster-manager as default container NO-JIRA: set ovnkube-cluster-manager as default container Oct 3, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 3, 2025
@openshift-ci-robot
Copy link
Contributor

@lance5890: This pull request explicitly references no jira issue.

In response to this:

As we use kubectl logs -n openshift-ovn-kubernetes ovnkube-control-plane-xxx, we see the default container logs is kube-rbac-proxy, like :

kubectl logs -n openshift-ovn-kubernetes ovnkube-control-plane-7948b585d4-wc7m4 
Defaulted container "kube-rbac-proxy" out of: kube-rbac-proxy, ovnkube-cluster-manager
2025-07-07T04:27:01+00:00 INFO: ovn-control-plane-metrics-certs mounted, starting kube-rbac-proxy
W0707 04:27:01.354951       1 deprecated.go:66] 
==== Removed Flag Warning ======================

logtostderr is removed in the k8s upstream and has no effect any more.

===============================================

I0707 04:27:01.356349       1 kube-rbac-proxy.go:233] Valid token audiences: 
I0707 04:27:01.356401       1 kube-rbac-proxy.go:347] Reading certificate files
I0707 04:27:01.356776       1 kube-rbac-proxy.go:395] Starting TCP socket on :9108
I0707 04:27:01.357087       1 kube-rbac-proxy.go:402] Listening securely on :9108

But most of the time we just care about the container ovnkube-cluster-manager logs , not the kube-rbac-proxy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@lance5890
Copy link
Contributor Author

/retest

2 similar comments
@lance5890
Copy link
Contributor Author

/retest

@lance5890
Copy link
Contributor Author

/retest

@lance5890
Copy link
Contributor Author

/retest-required

1 similar comment
@lance5890
Copy link
Contributor Author

/retest-required

@lance5890
Copy link
Contributor Author

/retest-required

Copy link
Contributor

openshift-ci bot commented Oct 6, 2025

@lance5890: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn fe94807 link false /test e2e-azure-ovn
ci/prow/security fe94807 link false /test security
ci/prow/e2e-aws-hypershift-ovn-kubevirt fe94807 link false /test e2e-aws-hypershift-ovn-kubevirt
ci/prow/okd-scos-e2e-aws-ovn fe94807 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-openstack-ovn fe94807 link false /test e2e-openstack-ovn
ci/prow/4.20-upgrade-from-stable-4.19-e2e-aws-ovn-upgrade fe94807 link false /test 4.20-upgrade-from-stable-4.19-e2e-aws-ovn-upgrade
ci/prow/4.20-upgrade-from-stable-4.19-e2e-azure-ovn-upgrade fe94807 link false /test 4.20-upgrade-from-stable-4.19-e2e-azure-ovn-upgrade
ci/prow/e2e-azure-ovn-upgrade fe94807 link true /test e2e-azure-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants