-
Notifications
You must be signed in to change notification settings - Fork 255
NO-JIRA: set ovnkube-cluster-manager as default container #2798
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Hi @lance5890. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I didn't know about this annotation! Could you apply the same changes also to bindata/network/ovn-kubernetes/managed/ovnkube-control-plane.yaml
?
Bonus point:
Could we also do the same for ovnkube-node.yaml (self-hosted and managed) and set ovnkube-controller as the default container? That would be amazing.
Thanks! :)
ef05ae1
to
4319a6b
Compare
that makes sense, done! |
4319a6b
to
fe94807
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
@kyrtapz PTAL |
Thanks @lance5890! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kyrtapz, lance5890, ricky-rav The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retitle NO-JIRA: set ovnkube-cluster-manager as default container |
@lance5890: This pull request explicitly references no jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest |
2 similar comments
/retest |
/retest |
/retest-required |
1 similar comment
/retest-required |
/retest-required |
@lance5890: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
As we use
kubectl logs -n openshift-ovn-kubernetes ovnkube-control-plane-xxx
, we see the default container logs is kube-rbac-proxy, like :But most of the time we just care about the container
ovnkube-cluster-manager
logs , not thekube-rbac-proxy