OCPBUGS-42303: Add drop flows for GARP #2801
Conversation
openshift-ci-robot
added
jira/severity-important
|
@pperiyasamy: This pull request references Jira Issue OCPBUGS-42303, which is valid. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
do-not-merge/hold
|
@pperiyasamy: GitHub didn't allow me to request PR reviews from the following users: pperiyasamy. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/assign @pliurh @huiran0826 |
|
Dup of #2741 ? |
|
/retest-required |
pperiyasamy
force-pushed
the
enable-block-arp-rpl
branch
2 times, most recently
from
ff5e56d to
af57b69
Compare
| # start temp work around | ||
| # remove when https://issues.redhat.com/browse/FDP-1537 is available | ||
| if ovs-vsctl br-exists "br-ex" && ! retry "60" "add-GARP-drop-flows" "add_garp_drop_flow br-ex"; then | ||
| echo "GARP drop flows addition failed - expected during initial OVS setup" |
There was a problem hiding this comment.
If the *to-br-int has not been created after a node reboot, we will have to wait for 2 mins here. I think it's better to just call add_garp_drop_flow without retry. Like what we do at u/s https://github.com/ovn-kubernetes/ovn-kubernetes/blob/0a11e5c9f625425dd54be53a3d96f77b81112910/dist/images/ovnkube.sh#L1817
There was a problem hiding this comment.
@pliurh do you mean wait for ovsdb-server, ovs-vswitchd, ovn-northd and ovn-controller processes to be ready and then invoke add_garp_drop_flow without a retry ? anyway retry logic also waits for 2 mins until patch port is created.
There was a problem hiding this comment.
ok @pliurh , as discussed this drop flow is needed only for pod/container restart case, the node reboot is taken care with openshift/machine-config-operator#5123. removed retry logic now.
while ovnkube-controller is processing. Its removed by ovnkube-controller when processing complete. May block for 120s until action is complete. Signed-off-by: Martin Kennelly <[email protected]> Signed-off-by: Periyasamy Palanisamy <[email protected]>
pperiyasamy
force-pushed
the
enable-block-arp-rpl
branch
from
af57b69 to
2b9d5c2
Compare
|
/lgtm |
openshift-ci
bot
added
lgtm
|
/approve |
|
/retest-required |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: martinkennelly, pliurh, pperiyasamy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
DS merge is in - this is ready to go |
|
/verified by huiran |
openshift-ci-robot
added
the
verified
|
@huiran0826: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest-required |
|
/retest cluster init issues |
|
CI is borked :/ Trying to understand why - unrelated to these changes. |
|
/retest |
openshift-merge-bot
bot
merged commit 6f6d0ee
into
openshift:master
|
@pperiyasamy: Jira Issue OCPBUGS-42303: Some pull requests linked via external trackers have merged: The following pull request, linked via external tracker, has not merged: All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-42303 has not been moved to the MODIFIED state. This PR is marked as verified. If the remaining PRs listed above are marked as verified before merging, the issue will automatically be moved to VERIFIED after all of the changes from the PRs are available in an accepted nightly payload. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@pperiyasamy: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/cherry-pick release-4.20 |
|
@martinkennelly: new pull request created: #2805 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
7 participants
/cc
/hold