Skip to content

Conversation

maiqueb
Copy link
Contributor

@maiqueb maiqueb commented Sep 30, 2025

For backwards compatibility reasons, we cannot update the definition of all the attributes that use the CIDR type - only of the new, unreleased objects.

Hence, this check is only performed for the reservedSubnets and infrastructureSubnets attributes.

@maiqueb
Copy link
Contributor Author

maiqueb commented Sep 30, 2025

@kyrtapz FYI

@maiqueb maiqueb changed the title api, l2udn: subnets must be masked CORENET-6423: api, l2udn: subnets must be masked Sep 30, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 30, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 30, 2025

@maiqueb: This pull request references CORENET-6423 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

For backwards compatibility reasons, we cannot update the definition of all the attributes that use the CIDR type - only of the new, unreleased objects.

Hence, this check is only performed for the reservedSubnets and infrastructureSubnets attributes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@maiqueb
Copy link
Contributor Author

maiqueb commented Sep 30, 2025

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Sep 30, 2025

@maiqueb: This pull request references CORENET-6423 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented Sep 30, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: maiqueb
Once this PR has been reviewed and has the lgtm label, please assign jcaamano for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyrtapz
Copy link
Contributor

kyrtapz commented Oct 1, 2025

@maiqueb there are two CRDs in that file we need to update, CUDN and UDN

@maiqueb
Copy link
Contributor Author

maiqueb commented Oct 1, 2025

@maiqueb there are two CRDs in that file we need to update, CUDN and UDN

Right. On it.

For backwards compatibility reasons, we cannot update the definition of
all the attributes that use the CIDR type - only of the new, unreleased
objects.

Hence, this check is only performed for the `reservedSubnets` and
`infrastructureSubnets` attributes in both the UDN and C-UDN CRDs.

Signed-off-by: Miguel Duarte Barroso <[email protected]>
@maiqueb maiqueb force-pushed the api-l2udn-masked-subnets branch from f2cb59c to 2f74606 Compare October 1, 2025 07:39
Copy link
Contributor

openshift-ci bot commented Oct 1, 2025

@maiqueb: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-upgrade 2f74606 link true /test e2e-aws-ovn-upgrade
ci/prow/e2e-aws-ovn-serial-ipsec-2of2 2f74606 link false /test e2e-aws-ovn-serial-ipsec-2of2
ci/prow/e2e-openstack-ovn 2f74606 link false /test e2e-openstack-ovn
ci/prow/e2e-aws-ovn-single-node 2f74606 link false /test e2e-aws-ovn-single-node
ci/prow/4.20-upgrade-from-stable-4.19-e2e-aws-ovn-upgrade 2f74606 link false /test 4.20-upgrade-from-stable-4.19-e2e-aws-ovn-upgrade
ci/prow/e2e-ovn-hybrid-step-registry 2f74606 link false /test e2e-ovn-hybrid-step-registry
ci/prow/4.20-upgrade-from-stable-4.19-e2e-gcp-ovn-upgrade 2f74606 link false /test 4.20-upgrade-from-stable-4.19-e2e-gcp-ovn-upgrade
ci/prow/4.20-upgrade-from-stable-4.19-e2e-azure-ovn-upgrade 2f74606 link false /test 4.20-upgrade-from-stable-4.19-e2e-azure-ovn-upgrade
ci/prow/security 2f74606 link false /test security
ci/prow/e2e-aws-hypershift-ovn-kubevirt 2f74606 link false /test e2e-aws-hypershift-ovn-kubevirt

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants