-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sriov dp admission controller to dpu operator #172
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vrindle The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
f922f9c
to
49a01cc
Compare
WIP (unable to run make-e2e-test locally). Fixing that before removing do-not-merge label. Also WIP: add network-resource-injector detection for sriov network operator... |
49a01cc
to
d10cabf
Compare
@@ -0,0 +1,163 @@ | |||
# Copyright (c) 2019 Intel Corporation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
what does also, could you please describe the feature in the commit message and link to relevant sources (like the Jira issue that maybe contains additional information). |
@thom311 ack. By the way... SRIOV dp admission controller is this repo here: https://github.com/openshift/sriov-dp-admission-controller. Please see updated description. |
d10cabf
to
9d70ef2
Compare
9d70ef2
to
9e90fda
Compare
/test e2e-dpu-operator-tests |
@vrindle: The specified target(s) for
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test make-e2e-test |
@vrindle: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
9e90fda
to
a5bea24
Compare
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
71a7284
to
113a057
Compare
113a057
to
cc9b2c4
Compare
SRIOV DP admission controller is needed in order to inject resource limits and requests for the dpu operator based on the specified network attachment definition in the pod yaml. This functionality exists in the SRIOV dp admission controller, so we need to enable it in the dpu operator (see repo here: https://github.com/openshift/sriov-dp-admission-controller). Link to jira for the scope of this: https://issues.redhat.com/browse/IIC-367