Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sriov dp admission controller to dpu operator #172

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vrindle
Copy link
Contributor

@vrindle vrindle commented Oct 7, 2024

SRIOV DP admission controller is needed in order to inject resource limits and requests for the dpu operator based on the specified network attachment definition in the pod yaml. This functionality exists in the SRIOV dp admission controller, so we need to enable it in the dpu operator (see repo here: https://github.com/openshift/sriov-dp-admission-controller). Link to jira for the scope of this: https://issues.redhat.com/browse/IIC-367

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 7, 2024
@vrindle vrindle marked this pull request as draft October 7, 2024 05:55
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 7, 2024
@openshift-ci openshift-ci bot requested review from bn222 and wizhaoredhat October 7, 2024 05:56
Copy link

openshift-ci bot commented Oct 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vrindle

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 7, 2024
@vrindle vrindle force-pushed the add_sriov_dp_admission_controller branch from f922f9c to 49a01cc Compare October 7, 2024 05:58
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 7, 2024
@vrindle
Copy link
Contributor Author

vrindle commented Oct 7, 2024

WIP (unable to run make-e2e-test locally). Fixing that before removing do-not-merge label. Also WIP: add network-resource-injector detection for sriov network operator...

@vrindle vrindle force-pushed the add_sriov_dp_admission_controller branch from 49a01cc to d10cabf Compare October 7, 2024 06:08
@@ -0,0 +1,163 @@
# Copyright (c) 2019 Intel Corporation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

@thom311
Copy link
Contributor

thom311 commented Nov 25, 2024

what does dp in sriov dp admission controller stand for?

also, could you please describe the feature in the commit message and link to relevant sources (like the Jira issue that maybe contains additional information).

@vrindle
Copy link
Contributor Author

vrindle commented Nov 25, 2024

@thom311 ack.

By the way... SRIOV dp admission controller is this repo here: https://github.com/openshift/sriov-dp-admission-controller. Please see updated description.

@vrindle vrindle force-pushed the add_sriov_dp_admission_controller branch from d10cabf to 9d70ef2 Compare November 26, 2024 14:02
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 26, 2024
tools/tools Outdated Show resolved Hide resolved
@vrindle vrindle force-pushed the add_sriov_dp_admission_controller branch from 9d70ef2 to 9e90fda Compare December 9, 2024 02:55
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 9, 2024
@vrindle vrindle marked this pull request as ready for review December 9, 2024 02:56
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 9, 2024
@openshift-ci openshift-ci bot requested review from bn222 and SalDaniele December 9, 2024 02:57
@vrindle vrindle marked this pull request as draft December 9, 2024 03:02
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 9, 2024
@vrindle vrindle marked this pull request as ready for review December 9, 2024 05:36
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 9, 2024
@vrindle vrindle closed this Dec 9, 2024
@vrindle vrindle reopened this Dec 9, 2024
@vrindle
Copy link
Contributor Author

vrindle commented Dec 9, 2024

/test e2e-dpu-operator-tests

Copy link

openshift-ci bot commented Dec 9, 2024

@vrindle: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

/test images
/test make-e2e-test
/test make-fmt-check
/test make-generate-check
/test make-prow-ci-manifests-check
/test make-test
/test make-vendor-check

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-dpu-operator-main-images
pull-ci-openshift-dpu-operator-main-make-fmt-check
pull-ci-openshift-dpu-operator-main-make-generate-check
pull-ci-openshift-dpu-operator-main-make-prow-ci-manifests-check
pull-ci-openshift-dpu-operator-main-make-test
pull-ci-openshift-dpu-operator-main-make-vendor-check

In response to this:

/test e2e-dpu-operator-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vrindle
Copy link
Contributor Author

vrindle commented Dec 9, 2024

/test make-e2e-test

@vrindle vrindle marked this pull request as draft December 9, 2024 06:50
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 9, 2024
Copy link

openshift-ci bot commented Dec 9, 2024

@vrindle: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-dpu-operator-tests f922f9c link true /test e2e-dpu-operator-tests
ci/prow/make-test 9e90fda link true /test make-test
ci/prow/make-fmt-check 9e90fda link true /test make-fmt-check

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@vrindle vrindle force-pushed the add_sriov_dp_admission_controller branch from 9e90fda to a5bea24 Compare January 16, 2025 05:43
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 16, 2025
@openshift-merge-robot
Copy link

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@vrindle vrindle force-pushed the add_sriov_dp_admission_controller branch 2 times, most recently from 71a7284 to 113a057 Compare January 21, 2025 07:11
@vrindle vrindle force-pushed the add_sriov_dp_admission_controller branch from 113a057 to cc9b2c4 Compare January 27, 2025 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants