USHIFT-5279: MicroShift telemetry enhancement #1742
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@pacevedom: This pull request references USHIFT-5279 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@pacevedom: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| deployments this might be a bit excessive due to resource usage, network | ||
| traffic and usage patterns. | ||
|
|
||
| MicroShift should send data once a day to minimize network traffic as it can be |
There was a problem hiding this comment.
this isn't how Prometheus/Thanos works: if you don't send metrics at least every 5m, they will be marked as stale and disappear from the query result. Working with intermittent metrics is very hard in practice and not following the same principle as OCP Telemetry metrics would complicate usage.
| |version|$microshift_version| | ||
| |type|microshift-rpm, microshift-ostree| | ||
|
|
||
| Metrics from MicroShift are already supported in the API because OpenShift is |
There was a problem hiding this comment.
The Telemetry server has an allow-list of metrics which comes from OCP and incoming samples which don't match the list are dropped. What's the strategy to keep MicroShift metrics in sync with OCP metrics?
| - "pmtk, MicroShift contributor" | ||
| - "eslutsky, MicroShift contributor" | ||
| - "copejon, MicroShift contributor" | ||
| approvers: |
There was a problem hiding this comment.
this would need approval from the RHOBS team responsible for the Telemetry backend service.
/cc @moadz
| instance, not viable in the typical resource constrained MicroShift deployment. | ||
| The direct write requests take raw Prometheus data and require both special | ||
| labels (`_id` for the cluster id) and crafting the authentication headers | ||
| (cluster id and pull secret in a specific format in HTTP headers). |
There was a problem hiding this comment.
it would be good to assess the potential impact on the Telemetry write endpoint (https://infogw.api.openshift.com/metrics/v1/receive).
| telemetry: | ||
| status: <Enabled|Disabled> # Defaults to Enabled | ||
| sendingInterval: <Duration> # Defaults to 24h | ||
| samplingInterval: <Duration> # Defaults to 1h |
There was a problem hiding this comment.
at some point during development, you might want to write traffic to the Telemetry staging server.
No description provided.