Skip to content

Conversation

alebedev87
Copy link
Contributor

This PR updates the version to the latest shipped 1.3.1. Along the way it fixes the broken hack/sync-version.sh script and adds it into verify target to check at each PR.

`hack/sync-version.sh` was exiting without updating the version label in Containerfiles.
This fix adds a `sed` command to ensure the label is replaced correctly.
Adds `hack/verify-version.sh` to `verify` target to check that
the version label is set on Konflux Containerfiles.
Also updates the Makefile so that `BUNDLE_VERSION` derives its value
from the `VERSION` file, ensuring a single source of truth for all version references.
The latest shipped version of ExternalDNS Operator is 1.3.1.
It was delivered through the legacy CPaaS productization stack
as part of base image security fixes.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 29, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Sep 29, 2025

@alebedev87: This pull request references NE-2076 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

This PR updates the version to the latest shipped 1.3.1. Along the way it fixes the broken hack/sync-version.sh script and adds it into verify target to check at each PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@alebedev87
Copy link
Contributor Author

/retest

Copy link

@Thealisyed Thealisyed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks for fixing the sync-version.sh, tried locally and works properly now

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2025
Copy link
Contributor

openshift-ci bot commented Sep 29, 2025

@alebedev87: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Thealisyed
Copy link

/approve

Copy link
Contributor

openshift-ci bot commented Sep 30, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Thealisyed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 773812b into openshift:main Sep 30, 2025
12 checks passed
@alebedev87
Copy link
Contributor Author

Xref the PR which introduced the broken hack/sync-version.sh: #272.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants