-
Notifications
You must be signed in to change notification settings - Fork 40
NE-2076: Update ExternalDNS Operator to version 1.3.1 #275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
`hack/sync-version.sh` was exiting without updating the version label in Containerfiles. This fix adds a `sed` command to ensure the label is replaced correctly.
Adds `hack/verify-version.sh` to `verify` target to check that the version label is set on Konflux Containerfiles. Also updates the Makefile so that `BUNDLE_VERSION` derives its value from the `VERSION` file, ensuring a single source of truth for all version references.
The latest shipped version of ExternalDNS Operator is 1.3.1. It was delivered through the legacy CPaaS productization stack as part of base image security fixes.
@alebedev87: This pull request references NE-2076 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks for fixing the sync-version.sh, tried locally and works properly now
@alebedev87: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Thealisyed The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Xref the PR which introduced the broken |
This PR updates the version to the latest shipped
1.3.1
. Along the way it fixes the brokenhack/sync-version.sh
script and adds it intoverify
target to check at each PR.