[main] NO-ISSUE: fix CVE-2026-33186#803
Open
andrej1991 wants to merge 1 commit intoopenshift:mainfrom
Open
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@andrej1991: This pull request explicitly references no jira issue. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughUpdated indirect Go module dependencies to newer versions, including cel.dev/expr (v0.25.1), envoyproxy packages (v1.36.0, v1.3.0), OpenTelemetry GCP detector (v1.39.0), golang.org/x/oauth2 (v0.34.0), and google.golang.org/grpc (v1.79.3). Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (8 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.11.4)Command failed Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: andrej1991 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@go.mod`:
- Line 267: The replace directive currently mapping golang.org/x/oauth2 to
github.com/openshift/golang-oauth2 v0.26.1-... is out of date relative to newer
OpenShift fork releases (v0.27.0, v0.28.0); update the replace directive for
module github.com/openshift/golang-oauth2 to the appropriate newer tag (e.g.,
v0.27.0 or v0.28.0) so the required golang.org/x/oauth2 v0.34.0 resolves to the
intended fork version, and run `go mod tidy` to verify and lock the chosen
version.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 9d2cbfde-c6df-4be2-a725-72f83c7a87fc
⛔ Files ignored due to path filters (203)
go.sumis excluded by!**/*.sumvendor/cel.dev/expr/BUILD.bazelis excluded by!**/vendor/**,!vendor/**vendor/cel.dev/expr/MODULE.bazelis excluded by!**/vendor/**,!vendor/**vendor/cel.dev/expr/checked.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/cel.dev/expr/eval.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/cel.dev/expr/explain.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/cel.dev/expr/syntax.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/cel.dev/expr/value.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/udpa/annotations/migrate.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/udpa/annotations/migrate.pb.validate.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/udpa/annotations/security.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/udpa/annotations/security.pb.validate.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/udpa/annotations/sensitive.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/udpa/annotations/status.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/udpa/annotations/status.pb.validate.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/udpa/annotations/versioning.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/udpa/annotations/versioning.pb.validate.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/udpa/type/v1/typed_struct.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/udpa/type/v1/typed_struct.pb.validate.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/annotations/v3/migrate.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/annotations/v3/migrate.pb.validate.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/annotations/v3/security.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/annotations/v3/security.pb.validate.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/annotations/v3/sensitive.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/annotations/v3/status.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/annotations/v3/status.pb.validate.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/annotations/v3/versioning.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/annotations/v3/versioning.pb.validate.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/core/v3/authority.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/core/v3/authority.pb.validate.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/core/v3/cidr.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/core/v3/cidr.pb.validate.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/core/v3/collection_entry.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/core/v3/collection_entry.pb.validate.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/core/v3/context_params.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/core/v3/context_params.pb.validate.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/core/v3/extension.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/core/v3/extension.pb.validate.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/core/v3/resource.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/core/v3/resource.pb.validate.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/core/v3/resource_locator.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/core/v3/resource_locator.pb.validate.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/core/v3/resource_name.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/core/v3/resource_name.pb.validate.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/data/orca/v3/orca_load_report.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/data/orca/v3/orca_load_report.pb.validate.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/service/orca/v3/orca.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/service/orca/v3/orca.pb.validate.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/service/orca/v3/orca_grpc.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/type/matcher/v3/cel.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/type/matcher/v3/cel.pb.validate.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/type/matcher/v3/domain.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/type/matcher/v3/domain.pb.validate.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/type/matcher/v3/http_inputs.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/type/matcher/v3/http_inputs.pb.validate.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/type/matcher/v3/ip.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/type/matcher/v3/ip.pb.validate.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/type/matcher/v3/matcher.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/type/matcher/v3/matcher.pb.validate.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/type/matcher/v3/range.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/type/matcher/v3/range.pb.validate.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/type/matcher/v3/regex.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/type/matcher/v3/regex.pb.validate.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/type/matcher/v3/string.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/type/matcher/v3/string.pb.validate.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/type/v3/cel.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/type/v3/cel.pb.validate.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/type/v3/range.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/type/v3/range.pb.validate.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/type/v3/typed_struct.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/cncf/xds/go/xds/type/v3/typed_struct.pb.validate.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/config/bootstrap/v3/bootstrap.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/config/bootstrap/v3/bootstrap.pb.validate.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/config/bootstrap/v3/bootstrap_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/config/common/mutation_rules/v3/mutation_rules.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/config/common/mutation_rules/v3/mutation_rules.pb.validate.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/config/common/mutation_rules/v3/mutation_rules_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/config/core/v3/address.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/config/core/v3/config_source.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/config/core/v3/grpc_service.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/config/core/v3/grpc_service.pb.validate.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/config/core/v3/grpc_service_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/config/core/v3/health_check.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/config/core/v3/protocol.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/config/core/v3/protocol.pb.validate.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/config/core/v3/proxy_protocol.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/config/core/v3/proxy_protocol.pb.validate.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/config/core/v3/proxy_protocol_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/config/endpoint/v3/load_report.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/config/listener/v3/listener_components.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/config/metrics/v3/stats.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/config/metrics/v3/stats.pb.validate.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/config/metrics/v3/stats_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/config/overload/v3/overload.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/config/route/v3/route_components.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/config/route/v3/route_components.pb.validate.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/config/route/v3/route_components_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/config/trace/v3/zipkin.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/config/trace/v3/zipkin.pb.validate.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/config/trace/v3/zipkin_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/extensions/filters/network/http_connection_manager/v3/http_connection_manager.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/extensions/filters/network/http_connection_manager/v3/http_connection_manager.pb.validate.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/extensions/filters/network/http_connection_manager/v3/http_connection_manager_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/extensions/load_balancing_policies/client_side_weighted_round_robin/v3/client_side_weighted_round_robin.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/extensions/load_balancing_policies/client_side_weighted_round_robin/v3/client_side_weighted_round_robin.pb.validate.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/extensions/load_balancing_policies/client_side_weighted_round_robin/v3/client_side_weighted_round_robin_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/extensions/load_balancing_policies/common/v3/common.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/extensions/load_balancing_policies/common/v3/common.pb.validate.gois excluded by!**/vendor/**,!vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/extensions/load_balancing_policies/common/v3/common_vtproto.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/envoyproxy/go-control-plane/envoy/type/matcher/v3/value.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/github.com/envoyproxy/protoc-gen-validate/validate/BUILDis excluded by!**/vendor/**,!vendor/**vendor/go.opentelemetry.io/contrib/detectors/gcp/version.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/balancer/balancer.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/balancer/grpclb/grpc_lb_v1/load_balancer_grpc.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/balancer/pickfirst/internal/internal.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/balancer/pickfirst/pickfirst.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/balancer/subconn.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/balancer/weightedroundrobin/balancer.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/balancer/weightedroundrobin/scheduler.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/balancer/weightedtarget/weightedtarget.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/balancer_wrapper.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/clientconn.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/credentials/alts/internal/conn/record.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/credentials/alts/internal/proto/grpc_gcp/handshaker_grpc.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/credentials/tls.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/encoding/encoding.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/encoding/gzip/gzip.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/experimental/stats/metricregistry.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/experimental/stats/metrics.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/interceptor.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/balancer/gracefulswitch/gracefulswitch.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/envconfig/envconfig.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/experimental.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/hierarchy/hierarchy.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/idle/idle.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/internal.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/proto/grpc_lookup_v1/rls_grpc.pb.gois excluded by!**/*.pb.go,!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/resolver/dns/dns_resolver.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/stats/metrics_recorder_list.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/transport/client_stream.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/transport/controlbuf.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/transport/http2_client.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/transport/http2_server.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/transport/http_util.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/transport/transport.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/xds/balancer/cdsbalancer/cdsbalancer.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/xds/balancer/cdsbalancer/cluster_watcher.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/xds/balancer/clusterimpl/clusterimpl.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/xds/balancer/clusterimpl/picker.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/xds/balancer/clustermanager/clustermanager.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/xds/balancer/clusterresolver/clusterresolver.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/xds/balancer/clusterresolver/configbuilder.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/xds/balancer/clusterresolver/resource_resolver_dns.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/xds/balancer/clusterresolver/resource_resolver_eds.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/xds/balancer/outlierdetection/balancer.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/xds/balancer/outlierdetection/subconn_wrapper.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/xds/balancer/priority/balancer.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/xds/balancer/priority/balancer_child.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/xds/balancer/priority/balancer_priority.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/xds/balancer/wrrlocality/balancer.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/xds/bootstrap/bootstrap.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/xds/clients/internal/buffer/unbounded.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/xds/clients/xdsclient/ads_stream.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/xds/clients/xdsclient/authority.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/xds/clients/xdsclient/channel.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/xds/clients/xdsclient/clientimpl_watchers.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/xds/clients/xdsclient/resource_watcher.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/xds/clients/xdsclient/xdsconfig.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/xds/clusterspecifier/rls/rls.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/xds/matcher/string_matcher.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/xds/resolver/serviceconfig.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/xds/resolver/watch_service.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/xds/resolver/xds_resolver.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/xds/server/listener_wrapper.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/xds/server/rds_handler.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/xds/xds.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/xds/xdsclient/client.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/xds/xdsclient/clientimpl.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/xds/xdsclient/clientimpl_watchers.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/xds/xdsclient/resource_types.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/xds/xdsclient/xdsresource/cluster_resource_type.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/xds/xdsclient/xdsresource/endpoints_resource_type.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/xds/xdsclient/xdsresource/filter_chain.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/xds/xdsclient/xdsresource/listener_resource_type.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/xds/xdsclient/xdsresource/resource_type.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/xds/xdsclient/xdsresource/route_config_resource_type.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/xds/xdsclient/xdsresource/type_eds.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/xds/xdsclient/xdsresource/type_rds.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/xds/xdsclient/xdsresource/unmarshal_eds.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/xds/xdsclient/xdsresource/unmarshal_lds.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/xds/xdsclient/xdsresource/unmarshal_rds.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/xds/xdsclient/xdsresource/xdsconfig.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/internal/xds/xdsdepmgr/xds_dependency_manager.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/mem/buffer_pool.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/mem/buffers.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/resolver/resolver.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/resolver_wrapper.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/rpc_util.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/server.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/stats/opentelemetry/opentelemetry.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/stream.gois excluded by!**/vendor/**,!vendor/**vendor/google.golang.org/grpc/version.gois excluded by!**/vendor/**,!vendor/**vendor/modules.txtis excluded by!**/vendor/**,!vendor/**
📒 Files selected for processing (1)
go.mod
| golang.org/x/mod v0.32.0 // indirect | ||
| golang.org/x/net v0.49.0 // indirect | ||
| golang.org/x/oauth2 v0.32.0 // indirect | ||
| golang.org/x/oauth2 v0.34.0 // indirect |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Check the OpenShift golang-oauth2 fork for recent security-related commits
echo "=== Checking OpenShift golang-oauth2 fork for updates after March 2025 ==="
gh api repos/openshift/golang-oauth2/commits --jq '.[] | select(.commit.committer.date > "2025-03-10") | {date: .commit.committer.date, message: .commit.message, sha: .sha}' | head -20
echo ""
echo "=== Checking for tags after v0.26.1 ==="
gh api repos/openshift/golang-oauth2/tags --jq '.[] | select(.name > "v0.26.1") | {name: .name, commit: .commit.sha}'Repository: openshift/image-based-install-operator
Length of output: 910
🏁 Script executed:
sed -n '260,270p' go.modRepository: openshift/image-based-install-operator
Length of output: 536
🏁 Script executed:
sed -n '320,330p' go.modRepository: openshift/image-based-install-operator
Length of output: 1097
🏁 Script executed:
# Check if there are any comments explaining the replace directive
sed -n '300,330p' go.modRepository: openshift/image-based-install-operator
Length of output: 2042
Update the replace directive to a newer version of the OpenShift fork.
The golang.org/x/oauth2 require block specifies v0.34.0, but the replace directive at line 325 overrides it with github.com/openshift/golang-oauth2 v0.26.1-0.20250310184649-06a918c6239d (from March 10, 2025). The actual version used will be v0.26.1 from the OpenShift fork. Newer versions are available in that fork (v0.27.0, v0.28.0); verify which version should be used and update the replace directive accordingly.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@go.mod` at line 267, The replace directive currently mapping
golang.org/x/oauth2 to github.com/openshift/golang-oauth2 v0.26.1-... is out of
date relative to newer OpenShift fork releases (v0.27.0, v0.28.0); update the
replace directive for module github.com/openshift/golang-oauth2 to the
appropriate newer tag (e.g., v0.27.0 or v0.28.0) so the required
golang.org/x/oauth2 v0.34.0 resolves to the intended fork version, and run `go
mod tidy` to verify and lock the chosen version.
Contributor
Author
|
/retest |
|
@andrej1991: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit