Skip to content

CORS-2323: Allow users to bring their own custom DNS solution for API and API-Int #6829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

CORS-2323: Allow users to bring their own custom DNS solution for API and API-Int #6829

wants to merge 5 commits into from

Conversation

sadasu
Copy link
Contributor

@sadasu sadasu commented Feb 3, 2023 •
edited
Loading

Based on Enhancement Proposal : openshift/enhancements#1400

OpenShift API PR: openshift/api#1397

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 3, 2023
@sadasu sadasu force-pushed the custom-dns-config branch from 0b754da to dbcb9b2 Compare February 3, 2023 20:57
barbacbd
barbacbd reviewed Feb 10, 2023
View reviewed changes
data/data/install.openshift.io_installconfigs.yaml Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably need to add "TechPreview" here and in types, validate that tech preview feature set is active when this is provided.

pkg/types/installconfig.go Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to know explicitly if it is "Disabled" or can we just assume that it is disabled when Enabled is not true ?

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 12, 2023
@openshift-bot
Copy link
Contributor

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 12, 2023
@sadasu sadasu force-pushed the custom-dns-config branch from dbcb9b2 to fdfd7c3 Compare June 26, 2023 21:43
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 26, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from sadasu. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sadasu sadasu changed the title WIP: Provide a way to enable a custom DNS solution via Install Config Allow users to bring their own custom DNS solution for API and API-Int Jun 26, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 26, 2023
@sadasu sadasu changed the title Allow users to bring their own custom DNS solution for API and API-Int CORS-2323: Allow users to bring their own custom DNS solution for API and API-Int Jun 26, 2023
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 26, 2023 •
edited by openshift-ci bot
Loading

@sadasu: This pull request references CORS-2323 which is a valid jira issue.

In response to this:

Based on Enhancement Proposal : openshift/enhancements#1400

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 26, 2023
@sadasu
Copy link
Contributor Author

sadasu commented Jun 26, 2023

/remove-lifecycle rotten

@openshift-ci openshift-ci bot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Jun 26, 2023
@sadasu sadasu force-pushed the custom-dns-config branch 10 times, most recently from 5594f30 to 0bac87e Compare July 2, 2023 19:44
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 2, 2023 •
edited by openshift-ci bot
Loading

@sadasu: This pull request references CORS-2323 which is a valid jira issue.

In response to this:

Based on Enhancement Proposal : openshift/enhancements#1400

OpenShift API PR: openshift/api#1397

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sadasu sadasu force-pushed the custom-dns-config branch 2 times, most recently from f9c3963 to eb7d9a2 Compare July 6, 2023 02:56
jianlinliu
jianlinliu reviewed Jul 19, 2023
View reviewed changes
pkg/asset/cluster/tfvars.go Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sadasu per the code here, only BYO LB is not in this feature's scope yet, right?

sadasu added 3 commits July 25, 2023 14:46
@sadasu
Allow users to bring their own custom DNS solution for API and API-Int
00f6845 
Provide a way for customers to use their custom DNS solution in place
of the one provided by the cloud platform. This requires the users
to pre-create LBs for API and API-Int. The customer is also required
to configure their DNS solution with entries for API and API-Int
resolution.
@sadasu
Validate UserConfiguredDNSLB for the AWS platfrom
ce2f46e
@sadasu
Add install-config tests
4120f20
@sadasu sadasu force-pushed the custom-dns-config branch from 3917ac3 to a344d84 Compare July 25, 2023 20:57
sadasu added 2 commits July 31, 2023 10:00
@sadasu
Use pre-created API external and API Internal LoadBalancers
e648f31 
When user has provided the API and API-Int Load Balancers(LB) when
a custom DNS solution is in use, configure these instead.
@sadasu
Do not set PublicZone and PrivateZone in the DNS Manifest with custom…
ee9f519 
… DNS
@sadasu sadasu force-pushed the custom-dns-config branch from a344d84 to ee9f519 Compare July 31, 2023 14:00
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 31, 2023

@sadasu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-secureboot dbcb9b2930b985e0c35d8e55c8bf96be86629428 link false /test e2e-gcp-secureboot
ci/prow/okd-scos-e2e-aws-upgrade dbcb9b2930b985e0c35d8e55c8bf96be86629428 link false /test okd-scos-e2e-aws-upgrade
ci/prow/e2e-aws-ovn-disruptive dbcb9b2930b985e0c35d8e55c8bf96be86629428 link false /test e2e-aws-ovn-disruptive
ci/prow/e2e-agent-ha-dualstack 3917ac32918ca48c566fac3cfa0572064da9995e link false /test e2e-agent-ha-dualstack
ci/prow/e2e-aws-ovn-imdsv2 ee9f519 link false /test e2e-aws-ovn-imdsv2
ci/prow/e2e-aws-ovn-localzones ee9f519 link false /test e2e-aws-ovn-localzones
ci/prow/e2e-aws-ovn-shared-vpc ee9f519 link false /test e2e-aws-ovn-shared-vpc
ci/prow/e2e-aws-ovn-single-node ee9f519 link false /test e2e-aws-ovn-single-node
ci/prow/e2e-aws-ovn-fips ee9f519 link false /test e2e-aws-ovn-fips
ci/prow/e2e-aws-ovn-shared-vpc-localzones ee9f519 link false /test e2e-aws-ovn-shared-vpc-localzones
ci/prow/okd-scos-e2e-aws-ovn ee9f519 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn ee9f519 link true /test e2e-aws-ovn
ci/prow/okd-e2e-aws-ovn ee9f519 link false /test okd-e2e-aws-ovn
ci/prow/okd-e2e-aws-ovn-upgrade ee9f519 link false /test okd-e2e-aws-ovn-upgrade

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sadasu
Copy link
Contributor Author

sadasu commented Oct 4, 2023

We are moving to a solution that depends on a self-hosted DNS. In that case, there would be no need for the customer to pre-create their LBs, thus making these changes obsolete.

@sadasu sadasu closed this Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnnaZivkovic AnnaZivkovic Awaiting requested review from AnnaZivkovic

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

2 more reviewers

@jianlinliu jianlinliu jianlinliu left review comments

@barbacbd barbacbd barbacbd left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sadasu @openshift-bot @openshift-ci-robot @jianlinliu @barbacbd