Skip to content

OCPBUGS-47652: IBMCloud: Set CAPI boot volumes #9385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

cjschaef
Copy link
Member

IBM Cloud CAPI machine boot volumes must have a size set, for now default to 100 GB, until an option is available to configure the size is available via the machinepool.

Related: https://issues.redhat.com/browse/OCPBUGS-47652

IBM Cloud CAPI machine boot volumes must have a size set,
for now default to 100 GB, until an option is available to
configure the size is available via the machinepool.

Related: https://issues.redhat.com/browse/OCPBUGS-47652
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 22, 2025
@openshift-ci-robot
Copy link
Contributor

@cjschaef: This pull request references Jira Issue OCPBUGS-47652, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

IBM Cloud CAPI machine boot volumes must have a size set, for now default to 100 GB, until an option is available to configure the size is available via the machinepool.

Related: https://issues.redhat.com/browse/OCPBUGS-47652

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@cjschaef
Copy link
Member Author

/test altinfra-e2e-ibmcloud-capi-ovn

@cjschaef
Copy link
Member Author

cjschaef commented Jan 22, 2025

I will try retesting, using BYOK along with BYON support, to see if I can duplicate the failure locally.
Unfortunately, I do not see any CAPI related manifests to review what BootVolume was set too (only the golang artifact log, which isn't helpful)

BootVolume:(*v1beta2.VPCVolume)(0xc000f388c0)

For example, I'd like to see the machine manifest, which contains this:

spec:
  bootVolume:
    encryptionKeyCRN: XXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX
    sizeGiB: 100

Before I hack up something to debug more, I'll run local testing with BYOK and BYON together to see if I can duplicate the failure.

@cjschaef
Copy link
Member Author

No joy in recreating locally. I'd like to see what a retrigger does before I begin modifying content to try to parse out why the CI is failing.

/test altinfra-e2e-ibmcloud-capi-ovn

@cjschaef
Copy link
Member Author

Ah, shoot. That was not a build from this PR.
Perhaps, if it is ran again, or details are still available, more information on the Machine manifests would help debug it more than what I found so far.

@MayXuQQ
Copy link
Contributor

MayXuQQ commented Jan 23, 2025

pre-merge build create byo-kms cluster succeed.

@MayXuQQ
Copy link
Contributor

MayXuQQ commented Jan 24, 2025

/retest

@MayXuQQ
Copy link
Contributor

MayXuQQ commented Jan 24, 2025

/test altinfra-e2e-ibmcloud-capi-ovn

Copy link
Contributor

openshift-ci bot commented Jan 24, 2025

@cjschaef: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-host-groups-ovn-custom-no-upgrade e365e12 link false /test e2e-vsphere-host-groups-ovn-custom-no-upgrade
ci/prow/okd-scos-e2e-aws-ovn e365e12 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@MayXuQQ
Copy link
Contributor

MayXuQQ commented Feb 17, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Feb 17, 2025
@openshift-ci-robot
Copy link
Contributor

@MayXuQQ: This pull request references Jira Issue OCPBUGS-47652, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @MayXuQQ

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Feb 17, 2025
@openshift-ci openshift-ci bot requested a review from MayXuQQ February 17, 2025 04:47
Copy link
Contributor

@MayXuQQ MayXuQQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-merge test PASS

@MayXuQQ
Copy link
Contributor

MayXuQQ commented Feb 17, 2025

/test altinfra-e2e-ibmcloud-capi-ovn

@MayXuQQ
Copy link
Contributor

MayXuQQ commented Feb 26, 2025

main@282df046, merging: #9385 e365e12 create capi cluster PASS
$ oc get machines -A
No resources found
How about merging the PR, I will check more?

@MayXuQQ
Copy link
Contributor

MayXuQQ commented Feb 27, 2025

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Feb 27, 2025
@openshift-ci-robot
Copy link
Contributor

@cjschaef: This pull request references Jira Issue OCPBUGS-47652, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @MayXuQQ

In response to this:

IBM Cloud CAPI machine boot volumes must have a size set, for now default to 100 GB, until an option is available to configure the size is available via the machinepool.

Related: https://issues.redhat.com/browse/OCPBUGS-47652

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from MayXuQQ February 27, 2025 03:21
Copy link
Contributor

@MayXuQQ MayXuQQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-merge install PASS

@rvanderp3
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 28, 2025
@patrickdillon
Copy link
Contributor

/approve

Copy link
Contributor

openshift-ci bot commented Mar 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MayXuQQ, patrickdillon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit efbd044 into openshift:main Mar 5, 2025
19 of 21 checks passed
@openshift-ci-robot
Copy link
Contributor

@cjschaef: Jira Issue OCPBUGS-47652: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-47652 has been moved to the MODIFIED state.

In response to this:

IBM Cloud CAPI machine boot volumes must have a size set, for now default to 100 GB, until an option is available to configure the size is available via the machinepool.

Related: https://issues.redhat.com/browse/OCPBUGS-47652

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@cjschaef cjschaef deleted the ocpbugs-47652 branch March 6, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants