Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap/node-image-pull.sh: handle "separate stateroot" flow better #9570

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Mar 17, 2025

Some flows currently instead of reinstalling the bootstrap node into a control plane node just add another stateroot and reboot into it. Long- term, those flows should move to a more container-native alternative.

But for now, let's avoid breaking them by deleting the node-image ref so it doesn't leak, and touching the checkout directory so OSTree won't try to GC it.

Some flows currently instead of reinstalling the bootstrap node into a
control plane node just add another stateroot and reboot into it. Long-
term, those flows should move to a more container-native alternative.

But for now, let's avoid breaking them by deleting the node-image ref so
it doesn't leak, and touching the checkout directory so OSTree won't try
to GC it.
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 17, 2025
Copy link
Contributor

openshift-ci bot commented Mar 17, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@jlebon
Copy link
Member Author

jlebon commented Mar 17, 2025

Leaving testing of this to @carbonin.

Copy link
Contributor

openshift-ci bot commented Mar 17, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign pawanpinjarkar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Mar 24, 2025

@jlebon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/artifacts-okd-scos-images 1a61121 link true /test artifacts-okd-scos-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant