Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.15] OCPBUGS-54353: aws/edge/byovpc: tag edge subnets with shared value #9612

Open
wants to merge 1 commit into
base: release-4.15
Choose a base branch
from

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #9482

/assign mtulio

@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-50547 has been cloned as Jira Issue OCPBUGS-54353. Will retitle bug to link to clone.
/retitle [release-4.15] OCPBUGS-54353: aws/edge/byovpc: tag edge subnets with shared value

In response to this:

This is an automated cherry-pick of #9482

/assign mtulio

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Previously the subnets created by user (BYO VPC) on edge zones (Local or
Wavelength zones) were not tagged with
kubernetes.io/cluster/<InfraID>:shared.

This change ensures installer is also setting the same cluster tag as
regular zones.
@openshift-cherrypick-robot openshift-cherrypick-robot force-pushed the cherry-pick-9482-to-release-4.15 branch from 6026ea4 to 8f2d5e2 Compare March 28, 2025 14:56
@openshift-ci openshift-ci bot changed the title [release-4.15] OCPBUGS-50547: aws/edge/byovpc: tag edge subnets with shared value [release-4.15] OCPBUGS-54353: aws/edge/byovpc: tag edge subnets with shared value Mar 28, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 28, 2025
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-54353, which is invalid:

  • expected dependent Jira Issue OCPBUGS-50547 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #9482

/assign mtulio

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Mar 28, 2025
@openshift-ci openshift-ci bot requested review from mtulio and patrickdillon March 28, 2025 14:59
Copy link
Contributor

openshift-ci bot commented Mar 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from mtulio. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mtulio
Copy link
Contributor

mtulio commented Mar 28, 2025

/test ?

Copy link
Contributor

openshift-ci bot commented Mar 28, 2025

@mtulio: The following commands are available to trigger required jobs:

/test agent-integration-tests
/test altinfra-e2e-aws-ovn-upi
/test altinfra-images
/test aro-unit
/test e2e-agent-compact-ipv4
/test e2e-aws-ovn
/test e2e-aws-ovn-edge-zones-manifest-validation
/test e2e-aws-ovn-upi
/test e2e-azure-ovn
/test e2e-azure-ovn-upi
/test e2e-gcp-ovn
/test e2e-gcp-ovn-upi
/test e2e-metal-ipi-ovn-ipv6
/test e2e-openstack-ovn
/test e2e-vsphere-ovn
/test e2e-vsphere-ovn-upi
/test gofmt
/test golint
/test govet
/test images
/test openstack-manifests
/test terraform-images
/test terraform-verify-vendor
/test unit
/test verify-codegen
/test verify-vendor

The following commands are available to trigger optional jobs:

/test altinfra-e2e-aws-custom-security-groups
/test altinfra-e2e-aws-ovn
/test altinfra-e2e-aws-ovn-fips
/test altinfra-e2e-aws-ovn-imdsv2
/test altinfra-e2e-aws-ovn-localzones
/test altinfra-e2e-aws-ovn-proxy
/test altinfra-e2e-aws-ovn-public-subnets
/test altinfra-e2e-aws-ovn-shared-vpc
/test altinfra-e2e-aws-ovn-shared-vpc-edge-zones
/test altinfra-e2e-aws-ovn-single-node
/test altinfra-e2e-aws-ovn-upgrade
/test altinfra-e2e-aws-upi-proxy
/test altinfra-e2e-azure-ovn
/test altinfra-e2e-azure-ovn-resourcegroup
/test altinfra-e2e-azure-ovn-shared-vpc
/test altinfra-e2e-vsphere-ovn
/test altinfra-e2e-vsphere-static-ovn
/test altinfra-e2e-vsphere-zones
/test e2e-agent-compact-ipv4-appliance
/test e2e-agent-compact-ipv4-none-platform
/test e2e-agent-ha-dualstack
/test e2e-agent-sno-ipv4-pxe
/test e2e-agent-sno-ipv6
/test e2e-alibaba
/test e2e-aws-custom-security-groups
/test e2e-aws-overlay-mtu-ovn-1200
/test e2e-aws-ovn-edge-zones
/test e2e-aws-ovn-fips
/test e2e-aws-ovn-imdsv2
/test e2e-aws-ovn-proxy
/test e2e-aws-ovn-public-subnets
/test e2e-aws-ovn-shared-vpc
/test e2e-aws-ovn-shared-vpc-edge-zones
/test e2e-aws-ovn-single-node
/test e2e-aws-ovn-upgrade
/test e2e-aws-ovn-workers-rhel8
/test e2e-aws-upi-proxy
/test e2e-azure-ovn-resourcegroup
/test e2e-azure-ovn-shared-vpc
/test e2e-azurestack
/test e2e-azurestack-upi
/test e2e-crc
/test e2e-gcp-ovn-byo-vpc
/test e2e-gcp-ovn-xpn
/test e2e-gcp-secureboot
/test e2e-gcp-upgrade
/test e2e-gcp-upi-xpn
/test e2e-ibmcloud-ovn
/test e2e-metal-assisted
/test e2e-metal-ipi-ovn
/test e2e-metal-ipi-ovn-dualstack
/test e2e-metal-ipi-ovn-swapped-hosts
/test e2e-metal-ipi-ovn-virtualmedia
/test e2e-metal-single-node-live-iso
/test e2e-nutanix-ovn
/test e2e-openstack-ccpmso
/test e2e-openstack-ccpmso-zone
/test e2e-openstack-dualstack
/test e2e-openstack-dualstack-upi
/test e2e-openstack-externallb
/test e2e-openstack-nfv-intel
/test e2e-openstack-proxy
/test e2e-vsphere-ovn-upi-zones
/test e2e-vsphere-ovn-zones
/test e2e-vsphere-ovn-zones-techpreview
/test e2e-vsphere-static-ovn
/test okd-scos-e2e-aws-ovn
/test okd-scos-e2e-aws-upgrade
/test okd-scos-e2e-gcp
/test okd-scos-e2e-gcp-ovn-upgrade
/test okd-scos-images
/test okd-scos-unit
/test okd-scos-verify-codegen

Use /test all to run the following jobs that were automatically triggered:

pull-ci-openshift-installer-release-4.15-altinfra-e2e-aws-custom-security-groups
pull-ci-openshift-installer-release-4.15-altinfra-e2e-aws-ovn-fips
pull-ci-openshift-installer-release-4.15-altinfra-e2e-aws-ovn-single-node
pull-ci-openshift-installer-release-4.15-altinfra-images
pull-ci-openshift-installer-release-4.15-aro-unit
pull-ci-openshift-installer-release-4.15-e2e-aws-custom-security-groups
pull-ci-openshift-installer-release-4.15-e2e-aws-ovn
pull-ci-openshift-installer-release-4.15-e2e-aws-ovn-edge-zones-manifest-validation
pull-ci-openshift-installer-release-4.15-e2e-aws-ovn-fips
pull-ci-openshift-installer-release-4.15-e2e-aws-ovn-imdsv2
pull-ci-openshift-installer-release-4.15-e2e-aws-ovn-shared-vpc
pull-ci-openshift-installer-release-4.15-e2e-aws-ovn-single-node
pull-ci-openshift-installer-release-4.15-e2e-azure-ovn-resourcegroup
pull-ci-openshift-installer-release-4.15-e2e-vsphere-static-ovn
pull-ci-openshift-installer-release-4.15-gofmt
pull-ci-openshift-installer-release-4.15-golint
pull-ci-openshift-installer-release-4.15-govet
pull-ci-openshift-installer-release-4.15-images
pull-ci-openshift-installer-release-4.15-okd-scos-e2e-aws-ovn
pull-ci-openshift-installer-release-4.15-okd-scos-e2e-aws-upgrade
pull-ci-openshift-installer-release-4.15-okd-scos-unit
pull-ci-openshift-installer-release-4.15-okd-scos-verify-codegen
pull-ci-openshift-installer-release-4.15-terraform-images
pull-ci-openshift-installer-release-4.15-unit
pull-ci-openshift-installer-release-4.15-verify-codegen
pull-ci-openshift-installer-release-4.15-verify-vendor

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mtulio
Copy link
Contributor

mtulio commented Mar 28, 2025

Testing edge zones in BYO VPC

/test altinfra-e2e-aws-ovn-shared-vpc-edge-zones

@mtulio
Copy link
Contributor

mtulio commented Mar 29, 2025

Testing edge zones in BYO VPC

/test altinfra-e2e-aws-ovn-shared-vpc-edge-zones

This PR is acceptable. The failed test in[1] is related to a known bug in the e2e test, where the fist worker node in the list is selected, ignoring taints and failing to schedule - missing tolerations. In this[1] job, the cluster was installed with the edge node listed first alphabetically. By design any workload running in the edge node must have the required tolerations applied to the node. This is a known issue I've observing in the ocp provider validation flow, where the first worker node in the list is usually selected to host the test environment - similar issue, different environments. I just opened a card to file a bug proposing a better approach https://issues.redhat.com/browse/SPLAT-2109.

Testing again to ensure completeness:

/test altinfra-e2e-aws-ovn-shared-vpc-edge-zones
/lgtm
/assign @patrickdillon

[1] https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_installer/9612/pull-ci-openshift-installer-release-4.15-altinfra-e2e-aws-ovn-shared-vpc-edge-zones/1905708247491284992

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2025
@mtulio
Copy link
Contributor

mtulio commented Mar 31, 2025

I tested the wrong/unofficial job. re-testing:

/test e2e-aws-ovn-shared-vpc-edge-zones

Blocker bug is now verified:
/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 31, 2025
@openshift-ci-robot
Copy link
Contributor

@mtulio: This pull request references Jira Issue OCPBUGS-54353, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.z) matches configured target version for branch (4.15.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-50547 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-50547 targets the "4.16.z" version, which is one of the valid target versions: 4.16.0, 4.16.z
  • bug has dependents

Requesting review from QA contact:
/cc @gpei

In response to this:

I tested the wrong/unofficial job. re-testing:

/test e2e-aws-ovn-shared-vpc-edge-zones

Blocker bug is now verified:
/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from gpei March 31, 2025 15:59
Copy link
Contributor

openshift-ci bot commented Mar 31, 2025

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 8f2d5e2 link false /test okd-scos-e2e-aws-ovn
ci/prow/altinfra-e2e-aws-ovn-single-node 8f2d5e2 link false /test altinfra-e2e-aws-ovn-single-node
ci/prow/okd-scos-e2e-aws-upgrade 8f2d5e2 link false /test okd-scos-e2e-aws-upgrade
ci/prow/altinfra-e2e-aws-ovn-shared-vpc-edge-zones 8f2d5e2 link false /test altinfra-e2e-aws-ovn-shared-vpc-edge-zones
ci/prow/e2e-aws-ovn-shared-vpc-edge-zones 8f2d5e2 link false /test e2e-aws-ovn-shared-vpc-edge-zones

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants