-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.15] OCPBUGS-54353: aws/edge/byovpc: tag edge subnets with shared value #9612
base: release-4.15
Are you sure you want to change the base?
Conversation
@openshift-cherrypick-robot: Jira Issue OCPBUGS-50547 has been cloned as Jira Issue OCPBUGS-54353. Will retitle bug to link to clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Previously the subnets created by user (BYO VPC) on edge zones (Local or Wavelength zones) were not tagged with kubernetes.io/cluster/<InfraID>:shared. This change ensures installer is also setting the same cluster tag as regular zones.
6026ea4
to
8f2d5e2
Compare
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-54353, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test ? |
@mtulio: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Testing edge zones in BYO VPC /test altinfra-e2e-aws-ovn-shared-vpc-edge-zones |
This PR is acceptable. The failed test in[1] is related to a known bug in the e2e test, where the fist worker node in the list is selected, ignoring taints and failing to schedule - missing tolerations. In this[1] job, the cluster was installed with the edge node listed first alphabetically. By design any workload running in the edge node must have the required tolerations applied to the node. This is a known issue I've observing in the ocp provider validation flow, where the first worker node in the list is usually selected to host the test environment - similar issue, different environments. I just opened a card to file a bug proposing a better approach https://issues.redhat.com/browse/SPLAT-2109. Testing again to ensure completeness: /test altinfra-e2e-aws-ovn-shared-vpc-edge-zones |
I tested the wrong/unofficial job. re-testing: /test e2e-aws-ovn-shared-vpc-edge-zones Blocker bug is now verified: |
@mtulio: This pull request references Jira Issue OCPBUGS-54353, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This is an automated cherry-pick of #9482
/assign mtulio