Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-48403: Bump openshift-eng/openshift-tests-extension to main #2188

Merged

Conversation

jsafrane
Copy link

This will effectively allow us to downgrade google.golang.org/grpc to v1.65.0, which is the version that upstream Kubernetes uses in 1.31.

I used these commands:

hack/pin-dependency.sh github.com/openshift-eng/openshift-tests-extension main
hack/pin-dependency.sh google.golang.org/grpc v1.65.0
hack/pin-dependency.sh google.golang.org/genproto/googleapis/rpc v0.0.0-20240701130421-f6361c86f094
hack/pin-dependency.sh google.golang.org/genproto/googleapis/api v0.0.0-20240528184218-531527333157
hack/update-vendor.sh

(genproto/googleapis/* versions are taken from #2105)

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Jan 29, 2025
@openshift-ci-robot
Copy link

@jsafrane: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot requested review from p0lyn0mial and tkashem January 29, 2025 11:14
@openshift-ci openshift-ci bot added the vendor-update Touching vendor dir or related files label Jan 29, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 29, 2025
@openshift-ci-robot
Copy link

@jsafrane: This pull request references Jira Issue OCPBUGS-48403, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This will effectively allow us to downgrade google.golang.org/grpc to v1.65.0, which is the version that upstream Kubernetes uses in 1.31.

I used these commands:

hack/pin-dependency.sh github.com/openshift-eng/openshift-tests-extension main
hack/pin-dependency.sh google.golang.org/grpc v1.65.0
hack/pin-dependency.sh google.golang.org/genproto/googleapis/rpc v0.0.0-20240701130421-f6361c86f094
hack/pin-dependency.sh google.golang.org/genproto/googleapis/api v0.0.0-20240528184218-531527333157
hack/update-vendor.sh

(genproto/googleapis/* versions are taken from #2105)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

This will effectively allow us to downgrade google.golang.org/grpc to
v1.65.0, which is the version that upstream Kubernetes uses in 1.31.
@jsafrane jsafrane force-pushed the 4.18-downgrade-grpc branch from e8086fe to a119997 Compare January 29, 2025 11:15
@openshift-ci-robot
Copy link

@jsafrane: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

jsafrane added a commit to jsafrane/origin that referenced this pull request Jan 29, 2025
jsafrane added a commit to jsafrane/origin that referenced this pull request Jan 29, 2025
jsafrane added a commit to jsafrane/origin that referenced this pull request Jan 29, 2025
jsafrane added a commit to jsafrane/origin that referenced this pull request Jan 29, 2025
jsafrane added a commit to jsafrane/origin that referenced this pull request Jan 29, 2025
jsafrane added a commit to jsafrane/origin that referenced this pull request Jan 29, 2025
@bertinatto
Copy link
Member

/retest-required

@bertinatto
Copy link
Member

/remove-label backports/unvalidated-commits
/label backports/validated-commits
/lgtm

@openshift-ci openshift-ci bot added backports/validated-commits Indicates that all commits come to merged upstream PRs. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Jan 29, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2025
Copy link

openshift-ci bot commented Jan 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2025
Copy link

openshift-ci bot commented Jan 29, 2025

@jsafrane: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn a119997 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jsafrane
Copy link
Author

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 30, 2025
@jsafrane
Copy link
Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 30, 2025
@openshift-ci-robot
Copy link

@jsafrane: This pull request references Jira Issue OCPBUGS-48403, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-48402 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-48402 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@gangwgr
Copy link

gangwgr commented Jan 30, 2025

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 30, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit b28f6f3 into openshift:release-4.18 Jan 30, 2025
21 of 22 checks passed
@openshift-ci-robot
Copy link

@jsafrane: Jira Issue OCPBUGS-48403: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-48403 has not been moved to the MODIFIED state.

In response to this:

This will effectively allow us to downgrade google.golang.org/grpc to v1.65.0, which is the version that upstream Kubernetes uses in 1.31.

I used these commands:

hack/pin-dependency.sh github.com/openshift-eng/openshift-tests-extension main
hack/pin-dependency.sh google.golang.org/grpc v1.65.0
hack/pin-dependency.sh google.golang.org/genproto/googleapis/rpc v0.0.0-20240701130421-f6361c86f094
hack/pin-dependency.sh google.golang.org/genproto/googleapis/api v0.0.0-20240528184218-531527333157
hack/update-vendor.sh

(genproto/googleapis/* versions are taken from #2105)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-pod
This PR has been included in build openshift-enterprise-pod-container-v4.18.0-202501301431.p0.gb28f6f3.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: kube-proxy
This PR has been included in build kube-proxy-container-v4.18.0-202501301431.p0.gb28f6f3.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-hyperkube
This PR has been included in build openshift-enterprise-hyperkube-container-v4.18.0-202501301431.p0.gb28f6f3.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-kube-apiserver-artifacts
This PR has been included in build ose-installer-kube-apiserver-artifacts-container-v4.18.0-202501301431.p0.gb28f6f3.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. backports/validated-commits Indicates that all commits come to merged upstream PRs. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants