Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNTRLPLANE-1: downgrade grpc library to 1.65.0 #2190

Merged
merged 1 commit into from
Jan 31, 2025
Merged

CNTRLPLANE-1: downgrade grpc library to 1.65.0 #2190

merged 1 commit into from
Jan 31, 2025

Conversation

bertinatto
Copy link
Member

@bertinatto bertinatto commented Jan 29, 2025 •
edited
Loading

This PR:

  • Bumps openshift-eng/openshift-tests-extension to main.
  • Downgrade gRPC library back to 1.65.0, which is the version k8s 1.32.1 uses.

PR #2105 bumped google.golang.org/grpc to v1.67.0. However, that version rejects TLS connections that don't support ALPN, which is incompatible with how the product currently works. As a result, routes tests in openshift/origin fail when the o/k is bumped there.

Kubernetes 1.32.1 uses version 1.65, so we decided to downgrade the library to the same version as upstream uses.

/assign @jsafrane @stbenjam

@bertinatto
UPSTREAM: <drop>: downgrade grpc library to 1.65.0
084abc5 
PR openshift#2105 bumped
google.golang.org/grpc to v1.67.0. However, that version rejects TLS
connections that don't support ALPN, which is incompatible with how
the product currently works. As a result, routes tests in openshift/origin are
currently failing.

Kubernetes 1.32.1 uses version 1.65, so we decided to downgrade
the library to the same version as upstream uses.
@openshift-ci-robot openshift-ci-robot added backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jan 29, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 29, 2025 •
edited by openshift-ci bot
Loading

@bertinatto: This pull request references CNTRLPLANE-1 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.19.0" version, but no target version was set.

In response to this:

PR #2105 bumped google.golang.org/grpc to v1.67.0. However, that version rejects TLS connections that don't support ALPN, which is incompatible with how the product currently works. As a result, routes tests in openshift/origin fail when the o/k is bumped there.

Kubernetes 1.32.1 uses version 1.65, so we decided to downgrade the library to the same version as upstream uses.

/assign @jsafrane @stbenjam

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

@bertinatto: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot added vendor-update Touching vendor dir or related files approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 29, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 29, 2025 •
edited by openshift-ci bot
Loading

@bertinatto: This pull request references CNTRLPLANE-1 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.19.0" version, but no target version was set.

In response to this:

This PR:

  • Bumps openshift-eng/openshift-tests-extension to main.
  • Downgrade gRPC library back to 1.65.0, which is the version k8s 1.32.1 uses.

PR #2105 bumped google.golang.org/grpc to v1.67.0. However, that version rejects TLS connections that don't support ALPN, which is incompatible with how the product currently works. As a result, routes tests in openshift/origin fail when the o/k is bumped there.

Kubernetes 1.32.1 uses version 1.65, so we decided to downgrade the library to the same version as upstream uses.

/assign @jsafrane @stbenjam

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bertinatto bertinatto mentioned this pull request Jan 29, 2025
Closed
@stbenjam
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 29, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bertinatto
Copy link
Member Author

/retest-required

@stbenjam
Copy link
Member

/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Jan 29, 2025
@bertinatto
Copy link
Member Author

/remove-label backports/unvalidated-commits
/label backports/validated-commits

@openshift-ci openshift-ci bot added backports/validated-commits Indicates that all commits come to merged upstream PRs. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Jan 30, 2025
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 13d3c9b and 2 for PR HEAD 084abc5 in total

@bertinatto
Copy link
Member Author

/retest-required

@bertinatto
Copy link
Member Author

/test integration

@bertinatto
Copy link
Member Author

/retest-required

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 13d3c9b and 2 for PR HEAD 084abc5 in total

@bertinatto
Copy link
Member Author

/retest

1 similar comment
@bertinatto
Copy link
Member Author

/retest

@jsafrane
Copy link

/retest-required

@bertinatto
Copy link
Member Author

/retest

3 similar comments
@bertinatto
Copy link
Member Author

/retest

@bertinatto
Copy link
Member Author

/retest

@bertinatto
Copy link
Member Author

/retest

@bertinatto
Copy link
Member Author

/retest-required

@bertinatto
Copy link
Member Author

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 13d3c9b and 2 for PR HEAD 084abc5 in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 13d3c9b and 2 for PR HEAD 084abc5 in total

@bertinatto
Copy link
Member Author

/retest

3 similar comments
@bertinatto
Copy link
Member Author

/retest

@bertinatto
Copy link
Member Author

/retest

@bertinatto
Copy link
Member Author

/retest

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 31, 2025

@bertinatto: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 5562572 into openshift:master Jan 31, 2025
23 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-pod
This PR has been included in build openshift-enterprise-pod-container-v4.19.0-202502010106.p0.g5562572.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: kube-proxy
This PR has been included in build kube-proxy-container-v4.19.0-202502010106.p0.g5562572.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-hyperkube
This PR has been included in build openshift-enterprise-hyperkube-container-v4.19.0-202502010106.p0.g5562572.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-kube-apiserver-artifacts
This PR has been included in build ose-installer-kube-apiserver-artifacts-container-v4.19.0-202502010106.p0.g5562572.assembly.stream.el9.
All builds following this will include this PR.

@bertinatto bertinatto deleted the bump-ote branch February 5, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerpeter1 jerpeter1 Awaiting requested review from jerpeter1

@p0lyn0mial p0lyn0mial Awaiting requested review from p0lyn0mial

Assignees

@stbenjam stbenjam

@jsafrane jsafrane

Labels
acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bertinatto @openshift-ci-robot @stbenjam @jsafrane @openshift-bot