-
Notifications
You must be signed in to change notification settings - Fork 119
[release-4.18] OCPBUGS-56834: allow TLS1.3 or modern profile to be specified #2315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-4.18
Are you sure you want to change the base?
Conversation
Co-authored-by: Allen Ray <[email protected]>
@openshift-cherrypick-robot: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
@openshift-cherrypick-robot: Jira Issue OCPBUGS-37706 has been cloned as Jira Issue OCPBUGS-56834. Will retitle bug to link to clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-56834, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@openshift-cherrypick-robot: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-tls-13 #2315 openshift/cluster-etcd-operator#1428 |
/lgtm |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: openshift-cherrypick-robot, wangke19 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There’s still no e2e test that automatically validates the modern profile (openshift/origin#29611), and the periodic job (https://prow.ci.openshift.org/job-history/gs/test-platform-results/logs/periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-tls-13) seems to be permanently failing. Are we confident about back porting the fix? |
I will take some time to check the root cause for tls13 failed e2e tests. |
Fixed in PR openshift/origin#29911 |
/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-tls-13 #2315 openshift/cluster-etcd-operator#1428 |
/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-tls-13 openshift/cluster-etcd-operator#1428 #2315 |
/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-tls-13 openshift/cluster-etcd-operator#1428 #2315 |
/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-tls-13 openshift/cluster-etcd-operator#1428 |
/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-tls-13 #2315 |
/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-tls-13 openshift/cluster-etcd-operator#1428 |
/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-tls-13 openshift/cluster-etcd-operator#1428 |
/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.18-e2e-gcp-ovn openshift/cluster-etcd-operator#1428 |
/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-tls-13 openshift/cluster-etcd-operator#1428 |
@wangke19: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f841c170-4d40-11f0-8f6e-c22952cd3d6f-0 |
/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-tls-13 openshift/cluster-etcd-operator#1428 |
@wangke19: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command |
/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-tls-13 openshift/cluster-etcd-operator#1428 |
@wangke19: trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command |
Test results of CI job periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-tls-13: 96a24535-7a0b-4ad3-adeb-bdf2d9b6a5c9, looks good. |
/payload-job-with-prs periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-tls-13 openshift/cluster-etcd-operator#1428 |
@wangke19: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/dc46af30-4db3-11f0-82ac-e8f71330d1dc-0 |
The test passed. |
/assign @p0lyn0mial @dusk125 @jacobsee |
This is an automated cherry-pick of #2135
/assign wangke19