TRT-2068: Reintroduce non-suite annotation removal #2331
Conversation
openshift-ci-robot
added
backports/unvalidated-commits
|
@smg247: This pull request references TRT-2068 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@smg247: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
openshift-ci
bot
added
the
do-not-merge/hold
|
/test all |
|
@smg247: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/payload 4.20 nightly blocking |
|
@smg247: trigger 11 job(s) of type blocking for the nightly release of OCP 4.20
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9a36ebf0-5731-11f0-9133-50de750d2804-0 |
|
/payload-job periodic-ci-openshift-hypershift-release-4.20-periodics-e2e-aws-ovn-conformance |
|
@smg247: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f3d95010-5779-11f0-8512-ea6c03e58b4e-0 |
|
/payload-job periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview-serial |
|
@smg247: trigger 3 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/19969150-577a-11f0-9669-9c28ca633fef-0 |
smg247
force-pushed
the
ann-removal-fix-micro
branch
from
5250af1 to
debfbc3
Compare
|
@smg247: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
@smg247: This pull request references TRT-2068 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/payload 4.20 nightly blocking |
|
@smg247: trigger 11 job(s) of type blocking for the nightly release of OCP 4.20
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1ed2fc60-5835-11f0-9442-5f2168c6da67-0 |
|
/payload 4.20 nightly blocking |
|
@smg247: trigger 11 job(s) of type blocking for the nightly release of OCP 4.20
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3ba37fd0-5b1f-11f0-8363-dfee229a1da1-0 |
… for missed disabled tests
smg247
force-pushed
the
ann-removal-fix-micro
branch
from
debfbc3 to
ea68016
Compare
|
@smg247: the contents of this pull request could not be automatically validated. The following commits could not be validated and must be approved by a top-level approver:
Comment |
|
/payload-job periodic-ci-openshift-release-master-nightly-4.20-e2e-metal-ipi-ovn-ipv6 |
|
@smg247: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f8b5c720-5b71-11f0-8667-e18e4a6b35ea-0 |
|
/payload-job periodic-ci-openshift-release-master-nightly-4.20-e2e-metal-ipi-ovn-ipv6 |
|
@smg247: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c1aa4ea0-5b84-11f0-9bcc-9a7296028c98-0 |
|
/payload-job periodic-ci-openshift-release-master-nightly-4.20-e2e-metal-ipi-ovn-ipv6 |
|
@smg247: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1f3c47d0-5b9e-11f0-9a34-7f48d1799035-0 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: smg247, stbenjam The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/hold until after the rebase |
openshift-ci
bot
added
the
do-not-merge/hold
| @@ -15,6 +15,8 @@ func filterOutDisabledSpecs(specs et.ExtensionTestSpecs) et.ExtensionTestSpecs { | |||
| "[Feature:ClusterTrustBundle]", | |||
| "[Feature:SELinuxMount]", | |||
| "[FeatureGate:SELinuxMount]", | |||
| "[Feature:UserNamespacesPodSecurityStandards]", | |||
| "[Feature:UserNamespacesSupport]", // disabled Beta | |||
There was a problem hiding this comment.
Are you sure you want to add these?
This feature is now enabled in 4.20 and Peter enabled the tests here: #2239.
There was a problem hiding this comment.
well that explains why they were missing! they were failing when I ran payload tests. I will remove them and try it again to see if there was some other reason for that...
Reverts the recent revert, and adds the two missed disabled tests. Also fixes another issue discovered during payload testing: the env selector was expecting
Proxy, but Origin is passingProxiedinstead./hold to merge after openshift/origin#29904