Skip to content

[release-4.18] OCPBUGS-57488: UPSTREAM: <carry>: Mark admissionregistration.k8s.io/v1beta1 as deprecated. #2333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: release-4.18
Choose a base branch
from
Open

[release-4.18] OCPBUGS-57488: UPSTREAM: <carry>: Mark admissionregistration.k8s.io/v1beta1 as deprecated. #2333

wants to merge 1 commit into from

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #2290

/assign openshift-cherrypick-robot

@benluddy
UPSTREAM: <carry>: Mark admissionregistration.k8s.io/v1beta1 as depre…
1d9e321 
…cated.

We inadvertently began serving these in the default feature set beginning with 4.17.0. We intend to
stop serving them in 4.20.0 and to treat this as a typical deprecated API removal.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 16, 2025
Merged
@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Jun 16, 2025
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot requested review from bertinatto and deads2k June 16, 2025 13:37
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-55937 has been cloned as Jira Issue OCPBUGS-57488. Will retitle bug to link to clone.
/retitle [release-4.18] OCPBUGS-57488: UPSTREAM: : Mark admissionregistration.k8s.io/v1beta1 as deprecated.

In response to this:

This is an automated cherry-pick of #2290

/assign openshift-cherrypick-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.18] OCPBUGS-55937: UPSTREAM: <carry>: Mark admissionregistration.k8s.io/v1beta1 as deprecated. [release-4.18] OCPBUGS-57488: UPSTREAM: <carry>: Mark admissionregistration.k8s.io/v1beta1 as deprecated. Jun 16, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 16, 2025
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-57488, which is invalid:

  • expected dependent Jira Issue OCPBUGS-55937 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead
  • expected dependent Jira Issue OCPBUGS-55937 to target a version in 4.19.0, but it targets "4.19.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #2290

/assign openshift-cherrypick-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jun 16, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 16, 2025

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/k8s-e2e-gcp-ovn 1d9e321 link true /test k8s-e2e-gcp-ovn
ci/prow/k8s-e2e-gcp-serial 1d9e321 link true /test k8s-e2e-gcp-serial
ci/prow/e2e-gcp-ovn-upgrade 1d9e321 link true /test e2e-gcp-ovn-upgrade
ci/prow/e2e-gcp 1d9e321 link true /test e2e-gcp

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

bertinatto
bertinatto reviewed Jun 17, 2025
View reviewed changes
Copy link
Member

@bertinatto bertinatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/remove-label backports/unvalidated-commits
/approve

@openshift-ci openshift-ci bot removed the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Jun 17, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2025
@sdodson sdodson added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 26, 2025
@sdodson
Copy link
Member

sdodson commented Jun 26, 2025

Marked this as jira/valid-bug because it'd be beneficial to get this part into 4.18 ASAP so that we begin counting and letting people know about the removal ASAP. The 4.19 bug is doing more work than this but this one can go on its own. Just needs lgtm.

/label backport-risk-assessed cherry-pick-approved

@bertinatto
Copy link
Member

Should this be packported all the way down to 4.17?

/assign @benluddy
For LGTM

/retest-required

@benluddy
Copy link

Should this be backported all the way down to 4.17?

We'd been thinking no, since 4.18 is enough to give us the eus-to-eus removal alert.

@benluddy
Copy link

/hold

/payload-job periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-techpreview

/cc @JoelSpeed Are the CAPI components still using this GV in 4.18?

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 26, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jun 26, 2025

@benluddy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/43ea5990-52b7-11f0-9356-bcacd5d8ad6f-0

@benluddy
Copy link

user/system:serviceaccount:openshift-cluster-api:cluster-capi-operator accessed validatingadmissionpolicies.v1beta1.admissionregistration.k8s.io 2136 times

@JoelSpeed
Copy link

/hold

I haven't completed the removal of this GV for 4.18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bertinatto bertinatto bertinatto left review comments

@deads2k deads2k Awaiting requested review from deads2k

Assignees

@benluddy benluddy

@openshift-cherrypick-robot openshift-cherrypick-robot

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@openshift-cherrypick-robot @openshift-ci-robot @sdodson @bertinatto @benluddy @JoelSpeed