Skip to content

OCPBUGS-66973: Ntpfailover backport 418 #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 9 commits into from
Jan 11, 2026
Merged

OCPBUGS-66973: Ntpfailover backport 418 #512

openshift-merge-bot merged 9 commits into from
Jan 11, 2026

Conversation

@josephdrichard
Copy link
Contributor

@josephdrichard josephdrichard commented Dec 9, 2025

/hold to fix mod

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 9, 2025
@openshift-ci openshift-ci bot requested review from dougbtv and zshi-redhat December 9, 2025 01:07
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 9, 2025
@josephdrichard josephdrichard changed the title Ntpfailover backport 418 OCPBUGS-66973: Ntpfailover backport 418 Dec 9, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 9, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 9, 2025

@josephdrichard: This pull request references Jira Issue OCPBUGS-66973, which is invalid:

  • expected the bug to target the "4.18.z" version, but no target version was set
  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-66973 to depend on a bug targeting a version in 4.19.0, 4.19.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/hold to fix mod

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@josephdrichard josephdrichard force-pushed the ntpfailover_backport_418 branch 2 times, most recently from d13592a to 0daeb36 Compare December 11, 2025 23:00
@josephdrichard
Copy link
Contributor Author

josephdrichard commented Dec 11, 2025

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2025
@josephdrichard josephdrichard force-pushed the ntpfailover_backport_418 branch from 0daeb36 to c6ea546 Compare December 11, 2025 23:39
@josephdrichard
ntpfailover plugin implementation
922d1f2 
Implement ntpfailover plugin to add support for failing over from GNSS
to NTP as a time source for setting the system clock, in order to ensure
at least some accuracy for the system clock even when GNSS is
unavailable.

When this plugin is enabled, phc2sys will be disabled upon loss of GNSS,
and reenabled once GNSS becomes available again.  Also, chronyd will be
set to offline when GNSS is available, and then back online when GNSS
stops being available.

Note that this is scoped to only allowing failover when GNSS is
configured as the primary source for the system clock, and does not
support failover from PTP to NTP.  Further work would be necessary to
enable such a feature.

Also add required interfaces to plugin framework and throughout daemon
code to support this implementation.

.

.
@josephdrichard
chronyd changes to work with events.
aa539a6
@josephdrichard
Handle chronyd restarting when disabled
b0cecf1
@josephdrichard
Update go mod and revendor
42528ec
@josephdrichard josephdrichard force-pushed the ntpfailover_backport_418 branch from c6ea546 to 42528ec Compare December 11, 2025 23:47
@josephdrichard
Copy link
Contributor Author

josephdrichard commented Dec 12, 2025

/verified later @klaskosk

@openshift-ci-robot openshift-ci-robot added verified-later verified Signifies that the PR passed pre-merge verification criteria labels Dec 12, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Dec 12, 2025

@josephdrichard: This PR has been marked to be verified later by @klaskosk.

Details

In response to this:

/verified later @klaskosk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 12, 2025

@josephdrichard: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@josephdrichard
Copy link
Contributor Author

josephdrichard commented Dec 12, 2025

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 12, 2025
@josephdrichard
Copy link
Contributor Author

josephdrichard commented Jan 6, 2026

/hold cancel
/jira refresh
/retest

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 6, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 6, 2026

@josephdrichard: This pull request references Jira Issue OCPBUGS-66973, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-66973 to depend on a bug targeting a version in 4.19.0, 4.19.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/hold cancel
/jira refresh
/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@lack
Copy link
Member

lack commented Jan 8, 2026

/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 8, 2026
@josephdrichard
Copy link
Contributor Author

josephdrichard commented Jan 9, 2026

/jira refresh
/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 9, 2026

@josephdrichard: This pull request references Jira Issue OCPBUGS-66973, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected Jira Issue OCPBUGS-66973 to depend on a bug targeting a version in 4.19.0, 4.19.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh
/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@josephdrichard
Copy link
Contributor Author

josephdrichard commented Jan 9, 2026

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 9, 2026

@josephdrichard: This pull request references Jira Issue OCPBUGS-66973, which is invalid:

  • expected Jira Issue OCPBUGS-66973 to depend on a bug targeting a version in 4.19.0, 4.19.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@josephdrichard
Copy link
Contributor Author

josephdrichard commented Jan 9, 2026

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 9, 2026
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 9, 2026

@josephdrichard: This pull request references Jira Issue OCPBUGS-66973, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.z) matches configured target version for branch (4.18.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-66971 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-66971 targets the "4.19.z" version, which is one of the valid target versions: 4.19.0, 4.19.z
  • bug has dependents

Requesting review from QA contact:
/cc @klaskosk

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from klaskosk January 9, 2026 21:08
@vitus133
Copy link
Contributor

vitus133 commented Jan 11, 2026

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 11, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 11, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: josephdrichard, vitus133

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [josephdrichard,vitus133]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 1744755 into openshift:release-4.18 Jan 11, 2026
6 checks passed
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jan 11, 2026

@josephdrichard: Jira Issue OCPBUGS-66973: All pull requests linked via external trackers have merged:

This pull request has the verified-later tag and will need to be manually moved to VERIFIED after testing. Jira Issue OCPBUGS-66973 has been moved to the MODIFIED state.

Details

In response to this:

/hold to fix mod

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dougbtv dougbtv Awaiting requested review from dougbtv

@zshi-redhat zshi-redhat Awaiting requested review from zshi-redhat

@klaskosk klaskosk Awaiting requested review from klaskosk

Assignees

@mffiedler mffiedler

@rbbratta rbbratta

@gsr-shanks gsr-shanks

@weliang1 weliang1

@anuragthehatter anuragthehatter

@huiran0826 huiran0826

@asood-rh asood-rh

@jechen0648 jechen0648

@obochan-rh obochan-rh

@qiowang721 qiowang721

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria verified-later

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.