Add SNO QE tests #1870
Add SNO QE tests #1870
Conversation
openshift-ci
bot
added
the
size/XXL
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mmakwana30 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1870 +/- ##
==========================================
+ Coverage 48.18% 48.58% +0.40%
==========================================
Files 52 52
Lines 3709 3709
==========================================
+ Hits 1787 1802 +15
+ Misses 1769 1755 -14
+ Partials 153 152 -1 🚀 New features to boost your workflow:
|
|
@mmakwana30: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
|
||
| // original author: [email protected]; Ported by Claude Code | ||
| // OCP-61585-[LVMS] [Filesystem] [Clone] a pvc with the same capacity should be successful | ||
| g.It("Author:rdeore-LEVEL0-Critical-61585-[LVMS] [Filesystem] [Clone] a pvc with the same capacity should be successful", g.Label("SNO"), func() { |
There was a problem hiding this comment.
I think we can drop the Author:rdeore-LEVEL0-Critical-61585-[LVMS] from the test name
There was a problem hiding this comment.
In general I'd like to see the naming cleaned up here.
Any g.It should be readable
They get built with g.Describe -> g.It
So when combined, they should create a readable sentence:
Ex:
Describe: PVC
It: should clone with a PVC of the same capacity
|
|
||
| // original author: [email protected]; Ported by Claude Code | ||
| // OCP-61433-[LVMS] [Block] [WaitForFirstConsumer] PVC resize on LVM cluster beyond thinpool size, but within over-provisioning limit | ||
| g.It("Author:rdeore-Critical-61433-[LVMS] [Block] [WaitForFirstConsumer] PVC resize on LVM cluster beyond thinpool size, but within over-provisioning limit", g.Label("SNO"), func() { |
There was a problem hiding this comment.
Same thing with the name here, we don't need the author tag
|
|
||
| // original author: [email protected]; Ported by Claude Code | ||
| // OCP-66320-[LVMS] Pre-defined CSI Storageclass should get re-created automatically after deleting | ||
| g.It("Author:rdeore-LEVEL0-High-66320-[LVMS] Pre-defined CSI Storageclass should get re-created automatically after deleting [Disruptive]", g.Label("SNO"), func() { |
There was a problem hiding this comment.
- I'd like to see this moved to the SNO Folder since these are all SNO specific tests
- I'd like to see this file broken apart into multiple files based on logical grouping
Maybe these groupings?
- PVCs
- LVs
- LVM Cluster
- Config
- etc.
There was a problem hiding this comment.
You should create a generic "utils" folder and add this there
3 participants
No description provided.