OCPBUGS-72257: feat(vgmanager): improve encrypted devices deletion

[qJkee]

Improve deletion logic for encrypted devices as user provided device name and actual device name on host usually doesnt match

[openshift-ci-robot]

@qJkee: This pull request references Jira Issue OCPBUGS-72257, which is invalid:

• expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Improve deletion logic for encrypted devices as user provided device name and actual device name on host usually doesnt match

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qJkee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [qJkee]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov-commenter]

Codecov Report

❌ Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.68%. Comparing base (c070ca9) to head (ba90182).
⚠️ Report is 58 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/controllers/vgmanager/controller.go	37.50%	3 Missing and 2 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1912      +/-   ##
==========================================
- Coverage   48.69%   48.68%   -0.02%     
==========================================
  Files          52       52              
  Lines        3709     3716       +7     
==========================================
+ Hits         1806     1809       +3     
- Misses       1753     1756       +3     
- Partials      150      151       +1     

Files with missing lines	Coverage Δ
internal/controllers/vgmanager/controller.go	66.38% <37.50%> (-0.36%)	⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[qJkee]

/retest

[suleymanakbas91]

/lgtm

[openshift-ci]

@qJkee: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-hypershift	ba90182	link	true	/test e2e-aws-hypershift
ci/prow/e2e-aws-single-node	ba90182	link	true	/test e2e-aws-single-node
ci/prow/e2e-aws	ba90182	link	true	/test e2e-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.