OCPBUGS-49592: Remove service dependencies on crio-wipe.service as it doesn't exist anymore

[emy]

- What I did
I removed references to crio-wipe.service from the service templates, as crio-wipe doesn't exist anymore as evident in OCPBUGS-49592.

- How to verify it
systemctl cat crio-wipe.service should yield the following output if crio-wipe.service really does not exist anymore:

No files found for crio-wipe.service.

systemctl cat on-prem-resolv-prepender should yield the following output:

# /etc/systemd/system/on-prem-resolv-prepender.service
[Unit]
Description=Populates resolv.conf according to on-prem IPI needs
StartLimitIntervalSec=0
[Service]
Type=oneshot
# Would prefer to do Restart=on-failure instead of this bash retry loop, but
# the version of systemd we have right now doesn't support it. It should be
# available in systemd v244 and higher.
ExecStart=/bin/bash -c " \
  until \
  /usr/local/bin/resolv-prepender.sh; \
  do \
  sleep 10; \
  done"
EnvironmentFile=-/run/resolv-prepender/env

systemctl cat kubelet-dependencies.target should show:

# /etc/systemd/system/kubelet-dependencies.target
[Unit]
Description=Dependencies necessary to run kubelet
Documentation=https://github.com/openshift/machine-config-operator/
Requires=basic.target network-online.target
Wants=NetworkManager-wait-online.service
Wants=rpc-statd.service chrony-wait.service

systemctl cat machine-config-daemon-pull.service should show:

# /etc/systemd/system/machine-config-daemon-pull.service
[Unit]
Description=Machine Config Daemon Pull
# Make sure it runs only on OSTree booted system
ConditionPathExists=/run/ostree-booted
# This "stamp file" is unlinked when we complete
# machine-config-daemon-firstboot.service
ConditionPathExists=/etc/ignition-machine-config-encapsulated.json
Wants=NetworkManager-wait-online.service
After=NetworkManager-wait-online.service network.service

[Service]
Type=oneshot
RemainAfterExit=yes
ExecStartPre=/etc/machine-config-daemon/generate_podman_policy_args.sh
ExecStart=/bin/sh -c "while ! /usr/bin/podman pull $(cat /tmp/podman_policy_args) --authfile=/var/lib/kubelet/config.json 'virthost.ostest.test.metalkube.org:5000/localimages/machine-config-operator:latest'; do sleep 1; done"

[Install]
RequiredBy=machine-config-daemon-firstboot.service

- Description for the changelog
Remove references to crio-wipe.service in other service definitions because it doesn't exist anymore.

[openshift-ci-robot]

@emy: This pull request references Jira Issue OCPBUGS-49592, which is invalid:

• expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

- What I did
I removed references to crio-wipe.service from the service templates, as crio-wipe doesn't exist anymore as evident in OCPBUGS-49592.

- How to verify it
systemctl cat crio-wipe.service should yield the following output if crio-wipe.service really does not exist anymore:

No files found for crio-wipe.service.

systemctl cat on-prem-resolv-prepender should yield the following output:

# /etc/systemd/system/on-prem-resolv-prepender.service
[Unit]
Description=Populates resolv.conf according to on-prem IPI needs
StartLimitIntervalSec=0
[Service]
Type=oneshot
# Would prefer to do Restart=on-failure instead of this bash retry loop, but
# the version of systemd we have right now doesn't support it. It should be
# available in systemd v244 and higher.
ExecStart=/bin/bash -c " \
 until \
 /usr/local/bin/resolv-prepender.sh; \
 do \
 sleep 10; \
 done"
EnvironmentFile=-/run/resolv-prepender/env

systemctl cat kubelet-dependencies.target should show:

# /etc/systemd/system/kubelet-dependencies.target
[Unit]
Description=Dependencies necessary to run kubelet
Documentation=https://github.com/openshift/machine-config-operator/
Requires=basic.target network-online.target
Wants=NetworkManager-wait-online.service
Wants=rpc-statd.service chrony-wait.service

systemctl cat machine-config-daemon-pull.service should show:

# /etc/systemd/system/machine-config-daemon-pull.service
[Unit]
Description=Machine Config Daemon Pull
# Make sure it runs only on OSTree booted system
ConditionPathExists=/run/ostree-booted
# This "stamp file" is unlinked when we complete
# machine-config-daemon-firstboot.service
ConditionPathExists=/etc/ignition-machine-config-encapsulated.json
Wants=NetworkManager-wait-online.service
After=NetworkManager-wait-online.service network.service

[Service]
Type=oneshot
RemainAfterExit=yes
ExecStartPre=/etc/machine-config-daemon/generate_podman_policy_args.sh
ExecStart=/bin/sh -c "while ! /usr/bin/podman pull $(cat /tmp/podman_policy_args) --authfile=/var/lib/kubelet/config.json 'virthost.ostest.test.metalkube.org:5000/localimages/machine-config-operator:latest'; do sleep 1; done"

[Install]
RequiredBy=machine-config-daemon-firstboot.service

- Description for the changelog
Remove references to crio-wipe.service in other service definitions because it doesn't exist anymore.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: emy
Once this PR has been reviewed and has the lgtm label, please assign umohnani8 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@emy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azure-ovn-upgrade-out-of-change	3d2bbe4	link	false	/test e2e-azure-ovn-upgrade-out-of-change
ci/prow/e2e-aws-ovn-windows	3d2bbe4	link	false	/test e2e-aws-ovn-windows
ci/prow/e2e-gcp-op-ocl	3d2bbe4	link	false	/test e2e-gcp-op-ocl
ci/prow/e2e-hypershift-techpreview	3d2bbe4	link	false	/test e2e-hypershift-techpreview
ci/prow/okd-scos-e2e-aws-ovn	3d2bbe4	link	false	/test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.