Skip to content

[release-4.19] OCPBUGS-56829: Only update boot disks during GCP boot image updates #5088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #5084

/assign djoshy

/cherrypick release-4.18 release-4.17

@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-55830 has been cloned as Jira Issue OCPBUGS-56829. Will retitle bug to link to clone.
/retitle [release-4.19] OCPBUGS-56829: Only update boot disks during GCP boot image updates

In response to this:

This is an automated cherry-pick of #5084

/assign djoshy

/cherrypick release-4.18 release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.19] OCPBUGS-55830: Only update boot disks during GCP boot image updates [release-4.19] OCPBUGS-56829: Only update boot disks during GCP boot image updates May 29, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels May 29, 2025
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-56829, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
  • expected dependent Jira Issue OCPBUGS-55830 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #5084

/assign djoshy

/cherrypick release-4.18 release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 29, 2025
@openshift-ci openshift-ci bot requested review from djoshy and dkhater-redhat May 29, 2025 01:16
@djoshy
Copy link
Contributor

djoshy commented May 29, 2025

/lgtm

/label backport-risk-assessed

/retest-required

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label May 29, 2025
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2025
Copy link
Contributor

openshift-ci bot commented May 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2025
@djoshy
Copy link
Contributor

djoshy commented May 29, 2025

/test unit

Copy link
Contributor

openshift-ci bot commented May 29, 2025

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn-upgrade-out-of-change 57321a1 link false /test e2e-azure-ovn-upgrade-out-of-change
ci/prow/okd-scos-e2e-aws-ovn 57321a1 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-gcp-op-ocl 57321a1 link false /test e2e-gcp-op-ocl

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ptalgulk01
Copy link

Pre-merge verified here:
Verified using IPI based GCP 4.19 cluster

  • Edit the machinesets value by adding extra disk
$ oc get machinesets.machine.openshift.io  -n openshift-machine-api ppt-2905d-dm6ht-worker-b -o yaml
          - autoDelete: true
            boot: true
            image: projects/rhcos-cloud/global/images/rhcos-9-6-20250523-0-gcp-x86-64
            labels: {}
            sizeGb: 300
            type: pd-ssd
  • Scale that machinesets
oc scale --replicas 2 machinesets.machine.openshift.io -n openshift-machine-api ppt-2905d-dm6ht-worker-b
  • See the machine is Provisioned
oc get machines
NAME                             PHASE          TYPE            REGION        ZONE            AGE
ppt-2905d-dm6ht-master-0         Running        n2-standard-4   us-central1   us-central1-a   4h54m
ppt-2905d-dm6ht-master-1         Running        n2-standard-4   us-central1   us-central1-b   4h54m
ppt-2905d-dm6ht-master-2         Running        n2-standard-4   us-central1   us-central1-c   4h54m
ppt-2905d-dm6ht-worker-a-h2w55   Running        n2-standard-4   us-central1   us-central1-a   4h47m
ppt-2905d-dm6ht-worker-b-hn6v5   Provisioning   n2-standard-4   us-central1   us-central1-b   32s
ppt-2905d-dm6ht-worker-b-w28lc   Running        n2-standard-4   us-central1   us-central1-b   4h47m
ppt-2905d-dm6ht-worker-c-rdt7q   Running        n2-standard-4   us-central1   us-central1-c   4h47m
ppt-2905d-dm6ht-worker-f-6m79j   Running        n2-standard-4   us-central1   us-central1-f   20m

/label cherry-pick-approved

@openshift-ci openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label May 29, 2025
@djoshy
Copy link
Contributor

djoshy commented May 29, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 29, 2025
@openshift-ci-robot
Copy link
Contributor

@djoshy: This pull request references Jira Issue OCPBUGS-56829, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-55830 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-55830 targets the "4.20.0" version, which is one of the valid target versions: 4.20.0
  • bug has dependents

Requesting review from QA contact:
/cc @sunzhaohua2

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from sunzhaohua2 May 29, 2025 15:01
@djoshy
Copy link
Contributor

djoshy commented May 29, 2025

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@djoshy: This pull request references Jira Issue OCPBUGS-56829, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.19.0) matches configured target version for branch (4.19.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-55830 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-55830 targets the "4.20.0" version, which is one of the valid target versions: 4.20.0
  • bug has dependents

Requesting review from QA contact:
/cc @sunzhaohua2

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit bccdc7e into openshift:release-4.19 May 29, 2025
18 of 21 checks passed
@openshift-ci-robot
Copy link
Contributor

@openshift-cherrypick-robot: Jira Issue OCPBUGS-56829: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-56829 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #5084

/assign djoshy

/cherrypick release-4.18 release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot
Copy link
Author

@openshift-cherrypick-robot: new pull request created: #5089

In response to this:

This is an automated cherry-pick of #5084

/assign djoshy

/cherrypick release-4.18 release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-machine-config-operator
This PR has been included in build ose-machine-config-operator-container-v4.19.0-202505291613.p0.gbccdc7e.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.