[release-4.20] OCPBUGS-62273: Networking: reset ovn-remote config and allow ovnkube controller to s… #5317
Conversation
…et it This fixes the issue where ovn-remote is set prior to reboot and when boot occurs, ovn-controller syncs quickly with a stale SB DB. This PR is part of the EIP GARP issue fix. Its required because when ovnkube-controller and ovn-controller container start on boot, there is no order to which container will start first, and we dont want ovn-controller to connect to SB DB before ovnkube controller has added the drop flows. Ideally, we would only allow ovn-controller to sync with SB DB when ovnkube controller has concluded syncing and the changes are available in SB DB. That maybe future work. Signed-off-by: Martin Kennelly <[email protected]>
|
@openshift-cherrypick-robot: Detected clone of Jira Issue OCPBUGS-42303 with correct target version. Will retitle the PR to link to the clone. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
changed the title
openshift-ci-robot
added
jira/severity-important
|
@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-62273, which is valid. 7 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
requested review from
anuragthehatter,
cheesesashimi and
isabella-janssen
|
/payload-with-prs 4.20 nightly blocking openshift/cluster-network-operator#2806,openshift/ovn-kubernetes#2767 |
|
@martinkennelly: given command is invalid: at least one of the commands given is only supported on a one-command-per-comment basis, please separate out commands as multiple comments |
|
/payload-with-prs 4.20 nightly blocking openshift/cluster-network-operator#2806,openshift/ovn-kubernetes#2767 |
|
@martinkennelly: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info. |
|
/payload-with-prs 4.20 nightly blocking openshift/cluster-network-operator#2806,openshift/ovn-kubernetes#2767 |
|
@martinkennelly: it appears that you have attempted to use some version of the payload command, but your comment was incorrectly formatted and cannot be acted upon. See the docs for usage info. |
|
/payload-with-prs 4.20 nightly blocking openshift/cluster-network-operator#2806 openshift/ovn-kubernetes#2767 |
|
@martinkennelly: trigger 10 job(s) of type blocking for the nightly release of OCP 4.20
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/c1411b20-9ea4-11f0-832b-31e3f9e7c09d-0 |
|
/payload-with-prs 4.20 nightly informing openshift/cluster-network-operator#2806 openshift/ovn-kubernetes#2767 |
|
@martinkennelly: trigger 67 job(s) of type informing for the nightly release of OCP 4.20
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d08c34c0-9ea4-11f0-9135-f805ed0e2cd9-0 |
|
/hold Until 4.20.0 is cut. |
openshift-ci
bot
added
the
do-not-merge/hold
|
/payload-with-prs 4.20 nightly blocking openshift/cluster-network-operator#2806 openshift/ovn-kubernetes#2767 Looking good. |
|
@martinkennelly: An error was encountered. No known errors were detected, please see the full error message for details. Full error message.
unable to get additional pr info from string: Looking: string: Looking doesn't match expected format: org/repo#number
Please contact an administrator to resolve this issue. |
|
/payload-with-prs 4.20 nightly blocking openshift/cluster-network-operator#2806 openshift/ovn-kubernetes#2767 |
|
@martinkennelly: trigger 10 job(s) of type blocking for the nightly release of OCP 4.20
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/13c8aa30-9f85-11f0-8f90-4690ab5934ee-0 |
|
@martinkennelly: trigger 67 job(s) of type informing for the nightly release of OCP 4.20
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5a2d3d80-a43d-11f0-8069-b32b778be59b-0 |
|
does this work? /payload-job-with-prs periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-serial openshift/cluster-network-operator#2806 openshift/ovn-kubernetes#2767 |
|
@jluhrsen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5d52e080-a48a-11f0-8096-36f245ae4e36-0 |
|
@martinkennelly , I don't understand how the *-with-prs commands is figuring out which jobs to run, but this is a !@#$ ton of jobs compared to just running the payload command. anyway, here's all that failed as a re-run. there is one more above when I was double checking this /payload-job-with-prs periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview openshift/cluster-network-operator#2806 openshift/ovn-kubernetes#2767 |
|
@jluhrsen: given command is invalid: at least one of the commands given is only supported on a one-command-per-comment basis, please separate out commands as multiple comments |
|
/jira refresh |
|
@martinkennelly: This pull request references Jira Issue OCPBUGS-62273, which is valid. 9 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test unit Build failed - unrelated to this PR. |
|
/test e2e-aws-ovn-upgrade-out-of-change Infra init issue |
|
/label staff-eng-approved |
openshift-ci
bot
added
the
staff-eng-approved
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/verified with "pre-merge testing" |
|
@jechen0648: The In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test unit Failed twice in a row for this PR but I see it passing on other PRs. Its not related to this PR. |
|
/verified by "QE / CI" As seen in previous command by QE : #5317 (comment) |
openshift-ci-robot
added
the
verified
|
@martinkennelly: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/verified by 'pre-merge testing' |
|
@jechen0648: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@jechen0648: This PR has been marked as verified by In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
@yuqi-zhang are you aware of this? Unit test keeps failing: |
|
For the unit test, I also see it fail to pull an image: |
|
/test unit Trying again. |
openshift-merge-bot
bot
merged commit 8d409e0
into
openshift:release-4.20
|
@openshift-cherrypick-robot: Jira Issue OCPBUGS-62273: Some pull requests linked via external trackers have merged: The following pull request, linked via external tracker, has not merged:
All associated pull requests must be merged or unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with Jira Issue OCPBUGS-62273 has not been moved to the MODIFIED state. This PR is marked as verified. If the remaining PRs listed above are marked as verified before merging, the issue will automatically be moved to VERIFIED after all of the changes from the PRs are available in an accepted nightly payload. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
16 participants
This is an automated cherry-pick of #5123
/assign martinkennelly