OCPBUGS-56264, OCPBUGS-55803: Use console-provided ROSA branding

[logonoff]

What type of PR is this?

(bug/feature/cleanup/documentation)

bugfix + cleanup

What this PR does / why we need it?

Removes the rosa-brand-logo.svg custom logo in favor of setting the brand to ROSA.

This fixes an issue with the contrast of the ROSA logo on OpenShift 4.19+, where the masthead can change background colours from light to dark.

Instead of using the new custom logo API, which would contain new schema that is not recognized by older versions of OpenShift, changing the value of brand achieves the same effect (i.e., the title and logo are changed).

Any future updates that are needed to the ROSA logo can be made in the openshift/console repo.

Which Jira/Github issue(s) this PR fixes?

https://issues.redhat.com/browse/OCPBUGS-55803

Special notes for your reviewer:

Is there a way to update the oauth-templates versions of OpenShift newer than 4.19?

A new version of oauth-templates was released which contains the PatternFly 6 changes made in 4.19 and is ready for consumption by this repo

Pre-checks (if applicable):

• Tested latest changes against a cluster

• Included documentation changes with PR

• If this is a new object that is not intended for the FedRAMP environment (if unsure, please reach out to team FedRAMP), please exclude it with:

  matchExpressions:
  - key: api.openshift.com/fedramp
    operator: NotIn
    values: ["true"]

[openshift-ci-robot]

@logonoff: This pull request references Jira Issue OCPBUGS-55803, which is invalid:

• expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What type of PR is this?

(bug/feature/cleanup/documentation)

bugfix + cleanup

What this PR does / why we need it?

Removes the rosa-brand-logo.svg custom logo in favor of setting the brand to ROSA.

This fixes an issue with the contrast of the ROSA logo on OpenShift 4.19+, where the masthead can change background colours from light to dark.

Instead of using the new custom logo API, which would contain new schema that is not recognized by older versions of OpenShift, changing the value of brand achieves the same effect (i.e., the title and logo are changed).

Any future updates that are needed to the ROSA logo can be made in the openshift/console repo.

Which Jira/Github issue(s) this PR fixes?

https://issues.redhat.com/browse/OCPBUGS-55803

Special notes for your reviewer:

Is there a way to update the oauth-templates versions of OpenShift newer than 4.19?

A new version of oauth-templates was released which contains the PatternFly 6 changes made in 4.19 and is ready for consumption by this repo

Pre-checks (if applicable):

• Tested latest changes against a cluster

• Included documentation changes with PR

• If this is a new object that is not intended for the FedRAMP environment (if unsure, please reach out to team FedRAMP), please exclude it with:

  matchExpressions:
  - key: api.openshift.com/fedramp
    operator: NotIn
    values: ["true"]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: logonoff
Once this PR has been reviewed and has the lgtm label, please assign xiaoyu74 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[logonoff]

/jira refresh

[openshift-ci-robot]

@logonoff: This pull request references Jira Issue OCPBUGS-55803, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.20.0) matches configured target version for branch (4.20.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@logonoff: This pull request references Jira Issue OCPBUGS-56264, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.20.0) matches configured target version for branch (4.20.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-55803, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.20.0) matches configured target version for branch (4.20.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What type of PR is this?

(bug/feature/cleanup/documentation)

bugfix + cleanup

What this PR does / why we need it?

Removes the rosa-brand-logo.svg custom logo in favor of setting the brand to ROSA.

This fixes an issue with the contrast of the ROSA logo on OpenShift 4.19+, where the masthead can change background colours from light to dark.

Instead of using the new custom logo API, which would contain new schema that is not recognized by older versions of OpenShift, changing the value of brand achieves the same effect (i.e., the title and logo are changed).

Any future updates that are needed to the ROSA logo can be made in the openshift/console repo.

Which Jira/Github issue(s) this PR fixes?

https://issues.redhat.com/browse/OCPBUGS-55803

Special notes for your reviewer:

Is there a way to update the oauth-templates versions of OpenShift newer than 4.19?

A new version of oauth-templates was released which contains the PatternFly 6 changes made in 4.19 and is ready for consumption by this repo

Pre-checks (if applicable):

• Tested latest changes against a cluster

• Included documentation changes with PR

• If this is a new object that is not intended for the FedRAMP environment (if unsure, please reach out to team FedRAMP), please exclude it with:

  matchExpressions:
  - key: api.openshift.com/fedramp
    operator: NotIn
    values: ["true"]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@logonoff: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@logonoff: This pull request references Jira Issue OCPBUGS-56264. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

This pull request references Jira Issue OCPBUGS-55803. The bug has been updated to no longer refer to the pull request using the external bug tracker. All external bug links have been closed. The bug has been moved to the NEW state.

In response to this:

What type of PR is this?

(bug/feature/cleanup/documentation)

bugfix + cleanup

What this PR does / why we need it?

Removes the rosa-brand-logo.svg custom logo in favor of setting the brand to ROSA.

This fixes an issue with the contrast of the ROSA logo on OpenShift 4.19+, where the masthead can change background colours from light to dark.

Instead of using the new custom logo API, which would contain new schema that is not recognized by older versions of OpenShift, changing the value of brand achieves the same effect (i.e., the title and logo are changed).

Any future updates that are needed to the ROSA logo can be made in the openshift/console repo.

Which Jira/Github issue(s) this PR fixes?

https://issues.redhat.com/browse/OCPBUGS-55803

Special notes for your reviewer:

Is there a way to update the oauth-templates versions of OpenShift newer than 4.19?

A new version of oauth-templates was released which contains the PatternFly 6 changes made in 4.19 and is ready for consumption by this repo

Pre-checks (if applicable):

• Tested latest changes against a cluster

• Included documentation changes with PR

• If this is a new object that is not intended for the FedRAMP environment (if unsure, please reach out to team FedRAMP), please exclude it with:

  matchExpressions:
  - key: api.openshift.com/fedramp
    operator: NotIn
    values: ["true"]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.