Skip to content

Oadp velero pod affinity #1690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mpryc
Copy link
Contributor

@mpryc mpryc commented Apr 2, 2025

Why the changes were made

Follow up fix for the https://issues.redhat.com//browse/OADP-5832

This fixes Velero pod affinity, other PRs are for the node-agent and repository maintenance jobs.
That is why this also modifies design doc to include velero pod.

How to test the changes made

Testing is very similar to the testing for the #1683 (comment)
Except the config should include spec.configuration.velero.loadAffinity options. Please refer to the design doc as this setting can work together with the spec.configuration.velero.podConfig.nodeSelector field.

Number of tests were written to cover simple and more complex scenario, also make tests runs them.

apiVersion: oadp.openshift.io/v1alpha1
kind: DataProtectionApplication
metadata:
  name: <dpa_sample>
spec:
...
  configuration:
    velero:
      loadAffinity:
        nodeSelector:
          matchLabels:
            kubernetes.io/hostname: node3
          matchExpressions:
            - key: node-role.kubernetes.io/backup
              operator: In
              values:
                - true

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 2, 2025
Copy link

openshift-ci bot commented Apr 2, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 2, 2025
@kaovilai

This comment was marked as off-topic.

This comment was marked as off-topic.

@kaovilai

This comment was marked as off-topic.

@kaovilai

This comment was marked as off-topic.

@kaovilai

This comment was marked as off-topic.

Signed-off-by: Michal Pryc <[email protected]>
@mpryc mpryc force-pushed the OADP-velero-pod-affinity branch from 4b58767 to db64a60 Compare April 15, 2025 11:07
@mpryc
Copy link
Contributor Author

mpryc commented Apr 15, 2025

/unhold

@mpryc mpryc marked this pull request as ready for review April 15, 2025 11:13
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 15, 2025
@mpryc
Copy link
Contributor Author

mpryc commented Apr 15, 2025

/retest

@sseago
Copy link
Contributor

sseago commented Apr 15, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 15, 2025
Copy link

openshift-ci bot commented Apr 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mpryc, sseago, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 41178dc into openshift:master Apr 15, 2025
8 of 9 checks passed
@mpryc
Copy link
Contributor Author

mpryc commented Apr 15, 2025

/cherry-pick oadp-1.5

@openshift-cherrypick-robot
Copy link
Contributor

@mpryc: new pull request created: #1716

In response to this:

/cherry-pick oadp-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants