-
Notifications
You must be signed in to change notification settings - Fork 79
Oadp velero pod affinity #1690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oadp velero pod affinity #1690
Conversation
Skipping CI for Draft Pull Request. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Signed-off-by: Michal Pryc <[email protected]>
4b58767
to
db64a60
Compare
/unhold |
/retest |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mpryc, sseago, weshayutin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
41178dc
into
openshift:master
/cherry-pick oadp-1.5 |
@mpryc: new pull request created: #1716 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Why the changes were made
Follow up fix for the https://issues.redhat.com//browse/OADP-5832
This fixes Velero pod affinity, other PRs are for the node-agent and repository maintenance jobs.
That is why this also modifies design doc to include velero pod.
How to test the changes made
Testing is very similar to the testing for the #1683 (comment)
Except the config should include
spec.configuration.velero.loadAffinity
options. Please refer to the design doc as this setting can work together with thespec.configuration.velero.podConfig.nodeSelector field.
Number of tests were written to cover simple and more complex scenario, also
make tests
runs them.