Skip to content

Comments

[oadp-1.5] DPA config for backup repo cache and full maintenance interval (#1705)#1710

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:oadp-1.5from
sseago:backup-repo-config-1.5
Apr 15, 2025
Merged

[oadp-1.5] DPA config for backup repo cache and full maintenance interval (#1705)#1710
openshift-merge-bot[bot] merged 1 commit intoopenshift:oadp-1.5from
sseago:backup-repo-config-1.5

Conversation

@sseago
Copy link
Contributor

@sseago sseago commented Apr 14, 2025

cherry-pick of #1705

Why the changes were made

Enable backup repository configuration via DPA. Upstream docs are here: https://velero.io/docs/v1.16/backup-repository-configuration/

This PR adds two new DPA fields to NodeAgentConfig to set cacheLimitMB and fullMaintenanceInterval

How to test the changes made

How to test the changes made

Changes to cacheLimitMB will be reflected in the conf file under $HOME/udmrepo in the velero pod. The number doesn't translate exactly to a single value seen, but for example setting it to 8000 produces these numbers:

  "caching": {
    "cacheDirectory": "../.cache/kopia/2123fc541362ef5f",
    "maxCacheSize": 5368709120,
    "contentCacheSizeLimitBytes": 6710886400,
    "maxMetadataCacheSize": 1342177280,
    "metadataCacheSizeLimitBytes": 1677721600,
    "maxListCacheDuration": 30000000000
  },
Setting it to 4000 will drop all of those numbers except for `maxListCacheDuration` in half.

Also, verify that the `backup-repository-dpa-name` configmap has both fields set (if you set both) and the values match the DPA field valuess:

apiVersion: v1
data:
kopia: '{"cacheLimitMB":2000,"fullMaintenanceInterval":"fastGC"}'
kind: ConfigMap

and that the configmap is passed as an arg to the velero pod:
    - --backup-repository-configmap=backup-repository-velero-sample

<!-- Explain how the changes introduced by this PR can be tested and verified, with commands and pictures -->

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2025
@shubham-pampattiwar
Copy link
Member

/lgtm

1 similar comment
@mpryc
Copy link
Contributor

mpryc commented Apr 14, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2025
@openshift-ci
Copy link

openshift-ci bot commented Apr 14, 2025

@sseago: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@weshayutin weshayutin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve /lgtm

@openshift-ci
Copy link

openshift-ci bot commented Apr 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mpryc, shubham-pampattiwar, sseago, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [mpryc,shubham-pampattiwar,sseago]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 692c8bb into openshift:oadp-1.5 Apr 15, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants