[oadp-1.5] DPA config for backup repo cache and full maintenance interval (#1705)#1710
Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:oadp-1.5from Apr 15, 2025
Conversation
shubham-pampattiwar
approved these changes
Apr 14, 2025
Member
|
/lgtm |
1 similar comment
Contributor
|
/lgtm |
mpryc
approved these changes
Apr 14, 2025
|
@sseago: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mpryc, shubham-pampattiwar, sseago, weshayutin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick of #1705
Why the changes were made
Enable backup repository configuration via DPA. Upstream docs are here: https://velero.io/docs/v1.16/backup-repository-configuration/
This PR adds two new DPA fields to NodeAgentConfig to set
cacheLimitMBandfullMaintenanceIntervalHow to test the changes made
How to test the changes made
Changes to
cacheLimitMBwill be reflected in the conf file under $HOME/udmrepo in the velero pod. The number doesn't translate exactly to a single value seen, but for example setting it to 8000 produces these numbers:apiVersion: v1
data:
kopia: '{"cacheLimitMB":2000,"fullMaintenanceInterval":"fastGC"}'
kind: ConfigMap