Skip to content

MIG-1688: Attributes for MTC 1.8.6 #87735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2025
Merged

MIG-1688: Attributes for MTC 1.8.6 #87735

merged 1 commit into from
Apr 22, 2025

Conversation

anarnold97
Copy link
Contributor

@anarnold97 anarnold97 commented Jan 28, 2025 •
edited
Loading

JIRA

Version(s):

  • OCP 4.13 → branch/enterprise-4.13
  • OCP 4.14 → branch/enterprise-4.14
  • OCP 4.15 → branch/enterprise-4.15
  • OCP 4.16 → branch/enterprise-4.16
  • OCP 4.17 → branch/enterprise-4.17
  • OCP 4.18 → branch/enterprise-4.18
  • OCP 4.19 → branch/enterprise-4.19

QE review:

@openshift-ci-robot
Copy link

@anarnold97: No Jira issue with key MTC-1688 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

JIRA

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 28, 2025
@ocpdocs-previewbot
Copy link

🤖 Tue Jan 28 19:47:00 - Prow CI generated the docs preview:
https://87735--ocpdocs-pr.netlify.app
Complete list of updated preview URLs: artifacts/updated_preview_urls.txt

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 28, 2025

@anarnold97: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

midays
midays approved these changes Apr 16, 2025
View reviewed changes
Copy link

@midays midays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci-robot
Copy link

@anarnold97: No Jira issue with key MTC-1688 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

JIRA

Version(s):

  • OCP 4.13 → branch/enterprise-4.13
  • OCP 4.14 → branch/enterprise-4.14
  • OCP 4.15 → branch/enterprise-4.15
  • OCP 4.16 → branch/enterprise-4.16
  • OCP 4.17 → branch/enterprise-4.17
  • OCP 4.18 → branch/enterprise-4.18
  • OCP 4.19 → branch/enterprise-4.19

QE review:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@anarnold97 anarnold97 changed the title WIP - MTC-1688: Attributes for MTC 1.8.6 MTC-1688: Attributes for MTC 1.8.6 Apr 16, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 16, 2025
@openshift-ci-robot
Copy link

@anarnold97: No Jira issue with key MTC-1688 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

JIRA

Version(s):

  • OCP 4.13 → branch/enterprise-4.13
  • OCP 4.14 → branch/enterprise-4.14
  • OCP 4.15 → branch/enterprise-4.15
  • OCP 4.16 → branch/enterprise-4.16
  • OCP 4.17 → branch/enterprise-4.17
  • OCP 4.18 → branch/enterprise-4.18
  • OCP 4.19 → branch/enterprise-4.19

QE review:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@anarnold97
Copy link
Contributor Author

/label mtc

@openshift-ci openshift-ci bot added the MTC Label for all MTC PRs label Apr 16, 2025
@anarnold97
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 16, 2025
@anarnold97 anarnold97 changed the title MTC-1688: Attributes for MTC 1.8.6 MIG-1688: Attributes for MTC 1.8.6 Apr 16, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 16, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 16, 2025 •
edited by openshift-ci bot
Loading

@anarnold97: This pull request references MIG-1688 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

JIRA

Version(s):

  • OCP 4.13 → branch/enterprise-4.13
  • OCP 4.14 → branch/enterprise-4.14
  • OCP 4.15 → branch/enterprise-4.15
  • OCP 4.16 → branch/enterprise-4.16
  • OCP 4.17 → branch/enterprise-4.17
  • OCP 4.18 → branch/enterprise-4.18
  • OCP 4.19 → branch/enterprise-4.19

QE review:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@shreyasiddhartha
Copy link
Contributor

/label peer-review-in-progress
/remove-label peer-review-needed

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 17, 2025
shreyasiddhartha
shreyasiddhartha reviewed Apr 17, 2025
View reviewed changes
Copy link
Contributor

@shreyasiddhartha shreyasiddhartha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xenolinux PTAL! Thanks. :)

@xenolinux xenolinux added this to the Continuous Release milestone Apr 17, 2025
xenolinux
xenolinux reviewed Apr 17, 2025
View reviewed changes
Copy link
Contributor

@xenolinux xenolinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shreyasiddhartha @anarnold97
Follow-up peer review - LGTM

@xenolinux xenolinux added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Apr 17, 2025
@anarnold97
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Apr 22, 2025
@jab-rh jab-rh added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Apr 22, 2025
@jab-rh jab-rh merged commit d5bbd4c into openshift:main Apr 22, 2025
2 checks passed
@jab-rh
Copy link
Contributor

jab-rh commented Apr 22, 2025

/cherry-pick enterprise-4.19

@jab-rh
Copy link
Contributor

jab-rh commented Apr 22, 2025

/cherry-pick enterprise-4.18

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 22, 2025
Merged
@openshift-cherrypick-robot
Copy link

@jab-rh: new pull request created: #92490

In response to this:

/cherry-pick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 22, 2025
Merged
@openshift-cherrypick-robot
Copy link

@jab-rh: new pull request created: #92491

In response to this:

/cherry-pick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jab-rh
Copy link
Contributor

jab-rh commented Apr 22, 2025

/cherry-pick enterprise-4.17

@jab-rh
Copy link
Contributor

jab-rh commented Apr 22, 2025

/cherry-pick enterprise-4.16

@jab-rh
Copy link
Contributor

jab-rh commented Apr 22, 2025

/cherry-pick enterprise-4.15

@jab-rh
Copy link
Contributor

jab-rh commented Apr 22, 2025

/cherry-pick enterprise-4.14

@openshift-cherrypick-robot
Copy link

@jab-rh: new pull request created: #92492

In response to this:

/cherry-pick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 22, 2025
Merged
@openshift-cherrypick-robot
Copy link

@jab-rh: new pull request created: #92493

In response to this:

/cherry-pick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 22, 2025
Merged
@openshift-cherrypick-robot
Copy link

@jab-rh: new pull request created: #92494

In response to this:

/cherry-pick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

This was referenced Apr 22, 2025
Merged
Merged
@openshift-cherrypick-robot
Copy link

@jab-rh: new pull request created: #92495

In response to this:

/cherry-pick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jab-rh jab-rh removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xenolinux xenolinux xenolinux left review comments

@shreyasiddhartha shreyasiddhartha shreyasiddhartha left review comments

@midays midays midays approved these changes

Assignees
No one assigned
Labels
branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. MTC Label for all MTC PRs peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
8 participants
@anarnold97 @openshift-ci-robot @ocpdocs-previewbot @shreyasiddhartha @jab-rh @openshift-cherrypick-robot @xenolinux @midays