Skip to content

OCPBUGS-54148: Added PTP UDP OVNK primary interface note #90987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2025
Merged

OCPBUGS-54148: Added PTP UDP OVNK primary interface note #90987

merged 1 commit into from
Apr 23, 2025

Conversation

dfitzmau
Copy link
Contributor

@dfitzmau dfitzmau commented Mar 24, 2025 •
edited
Loading

Version(s):
4.12+

Issue:
OCPBUGS-54148

Link to docs preview:

  • SME has approved this change (Christian Passarelli/comment in team-ocp-dsn doc).
  • QE has approved this change (Zhanqi Zhao).

@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 24, 2025
@openshift-ci-robot
Copy link

@dfitzmau: This pull request references Jira Issue OCPBUGS-54148, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Version(s):

Issue:

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 24, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 24, 2025 •
edited
Loading

🤖 Wed Apr 23 07:57:38 - Prow CI generated the docs preview:

https://90987--ocpdocs-pr.netlify.app/openshift-enterprise/latest/networking/ptp/about-ptp.html

@zhaozhanqi
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2025
@dfitzmau dfitzmau added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 22, 2025
@lahinson lahinson added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 22, 2025
lahinson
lahinson reviewed Apr 22, 2025
View reviewed changes
Copy link
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a couple items for your consideration.

networking/ptp/about-ptp.adoc Outdated
[IMPORTANT]
====
If your `openshift-sdn` cluster with Precision Time Protocol (PTP) uses the User Datagram Protocol (UDP) for hardware time stamping, the hardware time stamping cannot be applied to primary interface devices, such as an Open vSwitch (OVS) bridge, after you migrate to the OVN-Kubernetes plugin. This means that
UDP version 4 configurations cannot work with a `br-ex` interface.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
UDP version 4 configurations cannot work with a `br-ex` interface.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

@lahinson lahinson added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Apr 22, 2025
@lahinson lahinson mentioned this pull request Apr 22, 2025
Merged
2 tasks
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 23, 2025

New changes are detected. LGTM label has been removed.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 23, 2025

@dfitzmau: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dfitzmau dfitzmau merged commit 675f7ec into openshift:main Apr 23, 2025
2 checks passed
@openshift-ci-robot
Copy link

@dfitzmau: Jira Issue OCPBUGS-54148: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-54148 has been moved to the MODIFIED state.

In response to this:

Version(s):
4.12+

Issue:
OCPBUGS-54148

Link to docs preview:

  • SME has approved this change (Christian Passarelli/comment in team-ocp-dsn doc).
  • QE has approved this change (Zhanqi Zhao).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dfitzmau
Copy link
Contributor Author

/cherrypick enterprise-4.19

@dfitzmau
Copy link
Contributor Author

/cherrypick enterprise-4.18

@dfitzmau
Copy link
Contributor Author

/cherrypick enterprise-4.17

@dfitzmau
Copy link
Contributor Author

/cherrypick enterprise-4.16

@dfitzmau
Copy link
Contributor Author

/cherrypick enterprise-4.15

@dfitzmau
Copy link
Contributor Author

/cherrypick enterprise-4.14

@dfitzmau
Copy link
Contributor Author

/cherrypick enterprise-4.13

@dfitzmau
Copy link
Contributor Author

/cherrypick enterprise-4.12

@openshift-cherrypick-robot
Copy link

@dfitzmau: new pull request created: #92508

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 23, 2025
Merged
@openshift-cherrypick-robot
Copy link

@dfitzmau: new pull request created: #92509

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 23, 2025
Merged
@openshift-cherrypick-robot
Copy link

@dfitzmau: new pull request created: #92510

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 23, 2025
Merged
@openshift-cherrypick-robot
Copy link

@dfitzmau: #90987 failed to apply on top of branch "enterprise-4.16":

Patch is empty.
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To record the empty patch as an empty commit, run "git am --allow-empty".
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link

@dfitzmau: new pull request created: #92511

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 23, 2025
Merged
@openshift-cherrypick-robot
Copy link

@dfitzmau: new pull request created: #92512

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 23, 2025
Merged
@openshift-cherrypick-robot
Copy link

@dfitzmau: #90987 failed to apply on top of branch "enterprise-4.13":

Applying: OCPBUGS-54148: Added PTP UDP OVNK primary interface note
Using index info to reconstruct a base tree...
A	networking/ptp/about-ptp.adoc
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): networking/ptp/about-ptp.adoc deleted in HEAD and modified in OCPBUGS-54148: Added PTP UDP OVNK primary interface note. Version OCPBUGS-54148: Added PTP UDP OVNK primary interface note of networking/ptp/about-ptp.adoc left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 OCPBUGS-54148: Added PTP UDP OVNK primary interface note

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link

@dfitzmau: #90987 failed to apply on top of branch "enterprise-4.12":

Applying: OCPBUGS-54148: Added PTP UDP OVNK primary interface note
Using index info to reconstruct a base tree...
A	networking/ptp/about-ptp.adoc
Falling back to patching base and 3-way merge...
CONFLICT (modify/delete): networking/ptp/about-ptp.adoc deleted in HEAD and modified in OCPBUGS-54148: Added PTP UDP OVNK primary interface note. Version OCPBUGS-54148: Added PTP UDP OVNK primary interface note of networking/ptp/about-ptp.adoc left in tree.
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 OCPBUGS-54148: Added PTP UDP OVNK primary interface note

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dfitzmau
Copy link
Contributor Author

/cherrypick enterprise-4.16

@openshift-cherrypick-robot
Copy link

@dfitzmau: new pull request created: #92516

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaozhanqi zhaozhanqi zhaozhanqi left review comments

@lahinson lahinson lahinson left review comments

Assignees

@zhaozhanqi zhaozhanqi

Labels
branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dfitzmau @openshift-ci-robot @ocpdocs-previewbot @zhaozhanqi @openshift-cherrypick-robot @lahinson