Skip to content

OCPBUGS-48234: added an xref to PriorityClass creation #91045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sheriff-rh merged 1 commit into from
Apr 22, 2025
Merged

OCPBUGS-48234: added an xref to PriorityClass creation #91045

sheriff-rh merged 1 commit into from
Apr 22, 2025

Conversation

@sheriff-rh
Copy link
Contributor

@sheriff-rh sheriff-rh commented Mar 25, 2025 •
edited
Loading

Version(s):
4.12+

Issue:
https://issues.redhat.com/browse/OCPBUGS-48234

Link to docs preview:
Setting PriorityClass for ScanSetting scans

QE review:

  • QE has approved this change.

Additional information:
None

@sheriff-rh sheriff-rh added this to the Continuous Release milestone Mar 25, 2025
@sheriff-rh sheriff-rh self-assigned this Mar 25, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Mar 25, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 25, 2025

@sheriff-rh: This pull request references Jira Issue OCPBUGS-48234, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Version(s):
4.12+

Issue:
https://issues.redhat.com/browse/OCPBUGS-48234

Link to docs preview:
In progress

QE review:

  • QE has approved this change.

Additional information:
None

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 25, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Mar 25, 2025 •
edited
Loading

🤖 Tue Apr 22 12:12:09 - Prow CI generated the docs preview:

https://91045--ocpdocs-pr.netlify.app/openshift-enterprise/latest/security/compliance_operator/co-scans/compliance-operator-advanced.html

ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Mar 25, 2025
View reviewed changes
@openshift-ci openshift-ci bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 25, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 25, 2025

@sheriff-rh: This pull request references Jira Issue OCPBUGS-48234, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set
  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Version(s):
4.12+

Issue:
https://issues.redhat.com/browse/OCPBUGS-48234

Link to docs preview:
Setting PriorityClass for ScanSetting scans

QE review:

  • QE has approved this change.

Additional information:
None

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

rhmdnd
rhmdnd reviewed Apr 17, 2025
View reviewed changes
rhmdnd
rhmdnd approved these changes Apr 17, 2025
View reviewed changes
Copy link
Contributor

@rhmdnd rhmdnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Just one question to satisfy my own curiosity.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2025
@sheriff-rh
Copy link
Contributor Author

sheriff-rh commented Apr 18, 2025

Ready for your review @xiaojiey, thank you.

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2025
@openshift-ci
Copy link

openshift-ci bot commented Apr 22, 2025

New changes are detected. LGTM label has been removed.

@openshift-ci
Copy link

openshift-ci bot commented Apr 22, 2025

@sheriff-rh: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sheriff-rh
Copy link
Contributor Author

sheriff-rh commented Apr 22, 2025

Merging.

@sheriff-rh sheriff-rh merged commit c2e5973 into openshift:main Apr 22, 2025
2 checks passed
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 22, 2025

@sheriff-rh: Jira Issue OCPBUGS-48234 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

Details

In response to this:

Version(s):
4.12+

Issue:
https://issues.redhat.com/browse/OCPBUGS-48234

Link to docs preview:
Setting PriorityClass for ScanSetting scans

QE review:

  • QE has approved this change.

Additional information:
None

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@sheriff-rh
Copy link
Contributor Author

sheriff-rh commented Apr 22, 2025

/cherrypick enterprise-4.19

@sheriff-rh
Copy link
Contributor Author

sheriff-rh commented Apr 22, 2025

/cherrypick enterprise-4.18

@sheriff-rh
Copy link
Contributor Author

sheriff-rh commented Apr 22, 2025

/cherrypick enterprise-4.17

@sheriff-rh
Copy link
Contributor Author

sheriff-rh commented Apr 22, 2025

/cherrypick enterprise-4.16

@sheriff-rh
Copy link
Contributor Author

sheriff-rh commented Apr 22, 2025

/cherrypick enterprise-4.15

@sheriff-rh
Copy link
Contributor Author

sheriff-rh commented Apr 22, 2025

/cherrypick enterprise-4.14

@sheriff-rh
Copy link
Contributor Author

sheriff-rh commented Apr 22, 2025

/cherrypick enterprise-4.13

@sheriff-rh
Copy link
Contributor Author

sheriff-rh commented Apr 22, 2025

/cherrypick enterprise-4.12

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 22, 2025
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Apr 22, 2025

@sheriff-rh: new pull request created: #92438

Details

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Apr 22, 2025

@sheriff-rh: new pull request created: #92439

Details

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 22, 2025
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Apr 22, 2025

@sheriff-rh: new pull request created: #92440

Details

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 22, 2025
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Apr 22, 2025

@sheriff-rh: new pull request created: #92441

Details

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 22, 2025
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Apr 22, 2025

@sheriff-rh: new pull request created: #92442

Details

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 22, 2025
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Apr 22, 2025

@sheriff-rh: new pull request created: #92443

Details

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 22, 2025
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Apr 22, 2025

@sheriff-rh: new pull request created: #92444

Details

In response to this:

/cherrypick enterprise-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 22, 2025
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Apr 22, 2025

@sheriff-rh: new pull request created: #92446

Details

In response to this:

/cherrypick enterprise-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 22, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@agantony agantony agantony left review comments

@xiaojiey xiaojiey Awaiting requested review from xiaojiey

@BhargaviGudi BhargaviGudi Awaiting requested review from BhargaviGudi

+3 more reviewers

@aravipra aravipra aravipra left review comments

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

@rhmdnd rhmdnd rhmdnd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sheriff-rh sheriff-rh

@rhmdnd rhmdnd

Labels

branch/enterprise-4.12 branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

Continuous Release

Development

Successfully merging this pull request may close these issues.

9 participants

@sheriff-rh @openshift-ci-robot @ocpdocs-previewbot @xiaojiey @aravipra @openshift-cherrypick-robot @agantony @rhmdnd @ocpdocs-vale-bot