Skip to content

OSDOCS-12976: updates greenboot scripts MicroShift #91739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2025
Merged

OSDOCS-12976: updates greenboot scripts MicroShift #91739

merged 1 commit into from
Apr 18, 2025

Conversation

ShaunaDiaz
Copy link
Contributor

@ShaunaDiaz ShaunaDiaz commented Apr 7, 2025 •
edited
Loading

Version(s):
4.19+

Issue:
OSDOCS-12976

Link to docs preview:
MicroShift health check script
Greenbooth health check scripts

Reviews:

  • QE has approved this change.
  • SME has approved this change.

Additional information:
Release notes, #91750

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 7, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 7, 2025 •
edited by openshift-ci bot
Loading

@ShaunaDiaz: This pull request references OSDOCS-12976 which is a valid jira issue.

In response to this:

Version(s):

Issue:
OSDOCS-12976

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 7, 2025 •
edited by openshift-ci bot
Loading

@ShaunaDiaz: This pull request references OSDOCS-12976 which is a valid jira issue.

In response to this:

Version(s):

Issue:
OSDOCS-12976

Link to docs preview:

Reviews:

  • QE has approved this change.
  • SME has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ShaunaDiaz ShaunaDiaz added this to the Planned for 4.19 GA milestone Apr 7, 2025
@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 7, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 7, 2025 •
edited
Loading

🤖 Fri Apr 18 12:11:55 - Prow CI generated the docs preview:

https://91739--ocpdocs-pr.netlify.app/
https://91739--ocpdocs-pr.netlify.app/microshift/latest/microshift_install_get_ready/microshift-greenboot.html
https://91739--ocpdocs-pr.netlify.app/microshift/latest/microshift_running_apps/microshift-greenboot-workload-health-checks.html
https://91739--ocpdocs-pr.netlify.app/microshift/latest/microshift_updating/microshift-update-options.html

ShaunaDiaz
ShaunaDiaz commented Apr 7, 2025
View reviewed changes
modules/microshift-greenboot-app-health-check-script.adoc
@@ -0,0 +1,19 @@
//Module included in the following assemblies:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a modularization of the content here; no text updates.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 7, 2025 •
edited by openshift-ci bot
Loading

@ShaunaDiaz: This pull request references OSDOCS-12976 which is a valid jira issue.

In response to this:

Version(s):

Issue:
OSDOCS-12976

Link to docs preview:
(https://91739--ocpdocs-pr.netlify.app/microshift/latest/microshift_configuring/microshift-greenboot-checking-status.html)[]
(https://91739--ocpdocs-pr.netlify.app/microshift/latest/microshift_install_get_ready/microshift-greenboot.html)[]
(https://91739--ocpdocs-pr.netlify.app/microshift/latest/microshift_running_apps/microshift-greenboot-workload-scripts.html)[]

Reviews:

  • QE has approved this change.
  • SME has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ShaunaDiaz ShaunaDiaz mentioned this pull request Apr 7, 2025
Merged
2 tasks
@ShaunaDiaz ShaunaDiaz force-pushed the OSDOCS-12976 branch 3 times, most recently from ecaf08e to 45d0d0c Compare April 8, 2025 13:53
@openshift openshift deleted a comment from openshift-ci-robot Apr 8, 2025
@openshift openshift deleted a comment from openshift-ci-robot Apr 8, 2025
@openshift openshift deleted a comment from openshift-ci-robot Apr 8, 2025
@openshift openshift deleted a comment from openshift-ci-robot Apr 8, 2025
@openshift openshift deleted a comment from openshift-ci-robot Apr 8, 2025
@openshift openshift deleted a comment from openshift-ci-robot Apr 8, 2025
@openshift openshift deleted a comment from openshift-ci-robot Apr 8, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 8, 2025 •
edited by openshift-ci bot
Loading

@ShaunaDiaz: This pull request references OSDOCS-12976 which is a valid jira issue.

In response to this:

Version(s):

Issue:
OSDOCS-12976

Link to docs preview:
MicroShift health check script
Greenbooth health check scripts

Reviews:

  • QE has approved this change.
  • SME has approved this change.

Additional information:
Release notes, #91750

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

pmtk
pmtk reviewed Apr 10, 2025
View reviewed changes
Copy link
Member

@pmtk pmtk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One general comment: it's hard to follow changes (or see what actually changed content wise) when they are part of the same commit as the reorganization/modularization.

@openshift-ci openshift-ci bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 10, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 14, 2025 •
edited by openshift-ci bot
Loading

@ShaunaDiaz: This pull request references OSDOCS-12976 which is a valid jira issue.

In response to this:

Version(s):

Issue:
OSDOCS-12976

Link to docs preview:
MicroShift health check script
Greenbooth health check scripts

Reviews:

  • QE has approved this change.
  • SME has approved this change.

Additional information:
Release notes, #91750

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ShaunaDiaz ShaunaDiaz added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 14, 2025
@pmtk
Copy link
Member

pmtk commented Apr 14, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2025
@lpettyjo lpettyjo added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 15, 2025
@lpettyjo lpettyjo self-requested a review April 15, 2025 12:09
lpettyjo
lpettyjo reviewed Apr 15, 2025
View reviewed changes
Copy link
Contributor

@lpettyjo lpettyjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lpettyjo lpettyjo added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Apr 15, 2025
@ShaunaDiaz ShaunaDiaz removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 15, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 16, 2025

New changes are detected. LGTM label has been removed.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 17, 2025 •
edited by openshift-ci bot
Loading

@ShaunaDiaz: This pull request references OSDOCS-12976 which is a valid jira issue.

In response to this:

Version(s):
4.19+

Issue:
OSDOCS-12976

Link to docs preview:
MicroShift health check script
Greenbooth health check scripts

Reviews:

  • QE has approved this change.
  • SME has approved this change.

Additional information:
Release notes, #91750

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 18, 2025

@ShaunaDiaz: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dhensel-rh
Copy link

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Apr 18, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 18, 2025 •
edited by openshift-ci bot
Loading

@ShaunaDiaz: This pull request references OSDOCS-12976 which is a valid jira issue.

In response to this:

Version(s):
4.19+

Issue:
OSDOCS-12976

Link to docs preview:
MicroShift health check script
Greenbooth health check scripts

Reviews:

  • QE has approved this change.
  • SME has approved this change.

Additional information:
Release notes, #91750

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 18, 2025 •
edited by openshift-ci bot
Loading

@ShaunaDiaz: This pull request references OSDOCS-12976 which is a valid jira issue.

In response to this:

Version(s):
4.19+

Issue:
OSDOCS-12976

Link to docs preview:
MicroShift health check script
Greenbooth health check scripts

Reviews:

  • QE has approved this change.
  • SME has approved this change.

Additional information:
Release notes, #91750

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ShaunaDiaz ShaunaDiaz merged commit 7b1a2a7 into openshift:main Apr 18, 2025
2 checks passed
@ShaunaDiaz
Copy link
Contributor Author

/cherrypick enterprise-4.19

@openshift-cherrypick-robot
Copy link

@ShaunaDiaz: new pull request created: #92368

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 18, 2025
Closed
@ShaunaDiaz ShaunaDiaz mentioned this pull request Apr 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmtk pmtk pmtk left review comments

@lpettyjo lpettyjo lpettyjo left review comments

@dhensel-rh dhensel-rh dhensel-rh left review comments

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

Assignees

@pmtk pmtk

Labels
branch/enterprise-4.19 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR qe-approved Signifies that QE has signed off on this PR size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
Planned for 4.19 GA
Development

Successfully merging this pull request may close these issues.
8 participants
@ShaunaDiaz @openshift-ci-robot @ocpdocs-previewbot @pmtk @dhensel-rh @openshift-cherrypick-robot @lpettyjo @ocpdocs-vale-bot