Skip to content

OSDOCS-13576: Added info on rosa create network command #91784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2025
Merged

OSDOCS-13576: Added info on rosa create network command #91784

merged 1 commit into from
Apr 22, 2025

Conversation

EricPonvelle
Copy link
Contributor

@EricPonvelle EricPonvelle commented Apr 7, 2025 •
edited
Loading

Version(s):
enterprise-4.18+

Issue:
OSDOCS-13576

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
This PR introduces the rosa create network command.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 7, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 7, 2025 •
edited by openshift-ci bot
Loading

@EricPonvelle: This pull request references OSDOCS-13576 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Version(s):
enterprise-4.18+

Issue:
OSDOCS-13576

Link to docs preview:

  • Creating a ROSA cluster (rosa create network link)
  • rosa create objects updates

QE review:

  • QE has approved this change.

Additional information:
This PR introduces the rosa create network command.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 7, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 7, 2025 •
edited
Loading

🤖 Tue Apr 22 15:40:14 - Prow CI generated the docs preview:

https://91784--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/cli_reference/rosa_cli/rosa-manage-objects-cli.html
https://91784--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/rosa_hcp/rosa-hcp-creating-cluster-with-aws-kms-key.html
https://91784--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/rosa_hcp/rosa-hcp-egress-lockdown-install.html
https://91784--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/rosa_hcp/rosa-hcp-quickstart-guide.html
https://91784--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/rosa_hcp/rosa-hcp-sts-creating-a-cluster-quickly.html
https://91784--ocpdocs-pr.netlify.app/openshift-rosa/latest/cli_reference/rosa_cli/rosa-manage-objects-cli.html
https://91784--ocpdocs-pr.netlify.app/openshift-rosa/latest/rosa_hcp/rosa-hcp-creating-cluster-with-aws-kms-key.html
https://91784--ocpdocs-pr.netlify.app/openshift-rosa/latest/rosa_hcp/rosa-hcp-egress-lockdown-install.html
https://91784--ocpdocs-pr.netlify.app/openshift-rosa/latest/rosa_hcp/rosa-hcp-sts-creating-a-cluster-quickly.html

@EricPonvelle EricPonvelle force-pushed the OSDOCS-13576_rosa-create-network branch from 47da369 to 279ee86 Compare April 7, 2025 19:38
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 9, 2025 •
edited by openshift-ci bot
Loading

@EricPonvelle: This pull request references OSDOCS-13576 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Version(s):
enterprise-4.18+

Issue:
OSDOCS-13576

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
This PR introduces the rosa create network command.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@EricPonvelle EricPonvelle force-pushed the OSDOCS-13576_rosa-create-network branch 3 times, most recently from 8fd9946 to f3f7335 Compare April 9, 2025 22:05
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 10, 2025 •
edited by openshift-ci bot
Loading

@EricPonvelle: This pull request references OSDOCS-13576 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Version(s):
enterprise-4.18+

Issue:
OSDOCS-13576

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
This PR introduces the rosa create network command.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 10, 2025 •
edited by openshift-ci bot
Loading

@EricPonvelle: This pull request references OSDOCS-13576 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Version(s):
enterprise-4.18+

Issue:
OSDOCS-13576

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
This PR introduces the rosa create network command.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 10, 2025 •
edited by openshift-ci bot
Loading

@EricPonvelle: This pull request references OSDOCS-13576 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Version(s):
enterprise-4.18+

Issue:
OSDOCS-13576

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
This PR introduces the rosa create network command.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@EricPonvelle EricPonvelle force-pushed the OSDOCS-13576_rosa-create-network branch 3 times, most recently from 49c5b69 to 63bada5 Compare April 10, 2025 20:36
jneczypor
jneczypor reviewed Apr 10, 2025
View reviewed changes
Copy link
Contributor

@jneczypor jneczypor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly tiny fixes. Great work on the new procedure!

rosa_hcp/rosa-hcp-egress-lockdown-install.adoc Outdated
include::modules/rosa-hcp-vpc-manual.adoc[leveloffset=+2]

[id="troubleshooting_shared-vpc-hcp_vpc-creation-egress-lockdown"]
=== Troubleshooting
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section and the "Get Support" section could be a good snippet. :)

@EricPonvelle EricPonvelle force-pushed the OSDOCS-13576_rosa-create-network branch 10 times, most recently from ad8eadf to e7538c3 Compare April 14, 2025 19:51
@EricPonvelle EricPonvelle force-pushed the OSDOCS-13576_rosa-create-network branch 3 times, most recently from a93f057 to 158e912 Compare April 15, 2025 14:44
@EricPonvelle EricPonvelle added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 16, 2025
@lpettyjo lpettyjo added this to the Continuous Release milestone Apr 16, 2025
lpettyjo
lpettyjo reviewed Apr 16, 2025
View reviewed changes
Copy link
Contributor

@lpettyjo lpettyjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lpettyjo lpettyjo added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 16, 2025
@EricPonvelle EricPonvelle force-pushed the OSDOCS-13576_rosa-create-network branch 2 times, most recently from 66b6bf9 to e02405b Compare April 17, 2025 12:59
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 17, 2025 •
edited by openshift-ci bot
Loading

@EricPonvelle: This pull request references OSDOCS-13576 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

Version(s):
enterprise-4.18+

Issue:
OSDOCS-13576

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:
This PR introduces the rosa create network command.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@EricPonvelle EricPonvelle force-pushed the OSDOCS-13576_rosa-create-network branch from e02405b to e4dc78e Compare April 22, 2025 12:51
@mletalie
Copy link
Contributor

image
Might want to clean that up while you are in the file.

@EricPonvelle EricPonvelle force-pushed the OSDOCS-13576_rosa-create-network branch from e4dc78e to 68bf9a3 Compare April 22, 2025 14:40
mletalie
mletalie reviewed Apr 22, 2025
View reviewed changes
@EricPonvelle EricPonvelle force-pushed the OSDOCS-13576_rosa-create-network branch from 68bf9a3 to 554588f Compare April 22, 2025 15:26
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 22, 2025

@EricPonvelle: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@EricPonvelle EricPonvelle merged commit 20c7382 into openshift:main Apr 22, 2025
2 checks passed
@EricPonvelle
Copy link
Contributor Author

/cherrypick enterprise-4.18

@EricPonvelle
Copy link
Contributor Author

/cherrypick enterprise-4.19

@openshift-cherrypick-robot
Copy link

@EricPonvelle: new pull request created: #92478

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 22, 2025
Merged
@openshift-cherrypick-robot
Copy link

@EricPonvelle: new pull request created: #92479

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 22, 2025
Merged
@EricPonvelle EricPonvelle deleted the OSDOCS-13576_rosa-create-network branch April 22, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laubai laubai laubai left review comments

@lpettyjo lpettyjo lpettyjo left review comments

@jneczypor jneczypor jneczypor left review comments

@mletalie mletalie mletalie left review comments

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

Assignees
No one assigned
Labels
branch/enterprise-4.18 branch/enterprise-4.19 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
9 participants
@EricPonvelle @openshift-ci-robot @ocpdocs-previewbot @mletalie @openshift-cherrypick-robot @laubai @lpettyjo @jneczypor @ocpdocs-vale-bot