Skip to content

RHDEVDOCS 6421 use secret_ref: instead of secretRef: #91793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2025
Merged

RHDEVDOCS 6421 use secret_ref: instead of secretRef: #91793

merged 1 commit into from
Apr 14, 2025

Conversation

mramendi
Copy link
Contributor

@mramendi mramendi commented Apr 8, 2025 •
edited
Loading

Version(s):

pipelines-docs-1.14, pipelines-docs-1.15, pipelines-docs-1.16, pipelines-docs-1.17, pipelines-docs-1.18, pipelines-docs-1.19

Issue:

RHDEVDOCS 6421

Link to docs preview:

https://91793--ocpdocs-pr.netlify.app/openshift-pipelines/latest/pac/using-repository-crd.html#op-custom-parameter-expansion_using-repository-crd

QE review:

  • QE has approved this change.

Additional information:

@mramendi
Copy link
Contributor Author

mramendi commented Apr 8, 2025

https://issues.redhat.com/browse/RHDEVDOCS-6421

@openshift-ci openshift-ci bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 8, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 8, 2025 •
edited
Loading

🤖 Mon Apr 14 16:00:16 - Prow CI generated the docs preview:

https://91793--ocpdocs-pr.netlify.app/openshift-pipelines/latest/pac/using-repository-crd.html

@mramendi
Copy link
Contributor Author

mramendi commented Apr 9, 2025

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 9, 2025
@eromanova97
Copy link
Contributor

/remove-label peer-review-needed

/label peer-review-in-progress

@openshift-ci openshift-ci bot added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 9, 2025
eromanova97
eromanova97 reviewed Apr 9, 2025
View reviewed changes
Copy link
Contributor

@eromanova97 eromanova97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one question and one small out of scope suggestion, thank you!

/remove-label peer-review-in-progress

/label peer-review-done

@openshift-ci openshift-ci bot added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Apr 9, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 9, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 14, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 14, 2025

@mramendi: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mramendi
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Apr 14, 2025
@bergerhoffer
Copy link
Contributor

/label merge-review-in-progress

@openshift-ci openshift-ci bot added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Apr 14, 2025
bergerhoffer
bergerhoffer reviewed Apr 14, 2025
View reviewed changes
Copy link
Contributor

@bergerhoffer bergerhoffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to merge

@bergerhoffer bergerhoffer merged commit 19ff112 into openshift:pipelines-docs-main Apr 14, 2025
2 checks passed
@bergerhoffer
Copy link
Contributor

/cherrypick pipelines-docs-1.14

@bergerhoffer
Copy link
Contributor

/cherrypick pipelines-docs-1.15

@bergerhoffer
Copy link
Contributor

/cherrypick pipelines-docs-1.16

@bergerhoffer
Copy link
Contributor

/cherrypick pipelines-docs-1.17

@bergerhoffer
Copy link
Contributor

/cherrypick pipelines-docs-1.18

@bergerhoffer
Copy link
Contributor

/cherrypick pipelines-docs-1.19

@openshift-cherrypick-robot
Copy link

@bergerhoffer: new pull request created: #92152

In response to this:

/cherrypick pipelines-docs-1.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 14, 2025
Merged
@openshift-cherrypick-robot
Copy link

@bergerhoffer: new pull request created: #92153

In response to this:

/cherrypick pipelines-docs-1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 14, 2025
Merged
@openshift-cherrypick-robot
Copy link

@bergerhoffer: new pull request created: #92154

In response to this:

/cherrypick pipelines-docs-1.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

This was referenced Apr 14, 2025
Merged
Merged
@openshift-cherrypick-robot
Copy link

@bergerhoffer: new pull request created: #92155

In response to this:

/cherrypick pipelines-docs-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link

@bergerhoffer: new pull request created: #92156

In response to this:

/cherrypick pipelines-docs-1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 14, 2025
Merged
@openshift-cherrypick-robot
Copy link

@bergerhoffer: new pull request created: #92157

In response to this:

/cherrypick pipelines-docs-1.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 14, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergerhoffer bergerhoffer bergerhoffer left review comments

@eromanova97 eromanova97 eromanova97 left review comments

@ppitonak ppitonak ppitonak approved these changes

@zakisk zakisk zakisk approved these changes

Assignees
No one assigned
Labels
merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR peer-review-done Signifies that the peer review team has reviewed this PR size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mramendi @ocpdocs-previewbot @eromanova97 @bergerhoffer @openshift-cherrypick-robot @ppitonak @zakisk @openshift-merge-robot