-
Notifications
You must be signed in to change notification settings - Fork 1.8k
RHDEVDOCS 6421 use secret_ref: instead of secretRef: #91793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RHDEVDOCS 6421 use secret_ref: instead of secretRef: #91793
Conversation
🤖 Mon Apr 14 16:00:16 - Prow CI generated the docs preview: https://91793--ocpdocs-pr.netlify.app/openshift-pipelines/latest/pac/using-repository-crd.html |
/label peer-review-needed |
/remove-label peer-review-needed /label peer-review-in-progress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added one question and one small out of scope suggestion, thank you!
/remove-label peer-review-in-progress
/label peer-review-done
21e8f1b
to
8e7d6f9
Compare
8e7d6f9
to
0de46c9
Compare
@mramendi: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/label merge-review-needed |
/label merge-review-in-progress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM to merge
/cherrypick pipelines-docs-1.14 |
/cherrypick pipelines-docs-1.15 |
/cherrypick pipelines-docs-1.16 |
/cherrypick pipelines-docs-1.17 |
/cherrypick pipelines-docs-1.18 |
/cherrypick pipelines-docs-1.19 |
@bergerhoffer: new pull request created: #92152 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@bergerhoffer: new pull request created: #92153 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@bergerhoffer: new pull request created: #92154 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@bergerhoffer: new pull request created: #92155 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@bergerhoffer: new pull request created: #92156 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@bergerhoffer: new pull request created: #92157 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Version(s):
pipelines-docs-1.14, pipelines-docs-1.15, pipelines-docs-1.16, pipelines-docs-1.17, pipelines-docs-1.18, pipelines-docs-1.19
Issue:
RHDEVDOCS 6421
Link to docs preview:
https://91793--ocpdocs-pr.netlify.app/openshift-pipelines/latest/pac/using-repository-crd.html#op-custom-parameter-expansion_using-repository-crd
QE review:
Additional information: