Skip to content

MIG-1620: MTC VM storage migration #91828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2025
Merged

MIG-1620: MTC VM storage migration #91828

merged 1 commit into from
Apr 18, 2025

Conversation

anarnold97
Copy link
Contributor

@anarnold97 anarnold97 commented Apr 8, 2025 •
edited
Loading

JIRA

Version(s):

  • OCP 4.14 → branch/enterprise-4.14
  • OCP 4.15 → branch/enterprise-4.15
  • OCP 4.16 → branch/enterprise-4.16
  • OCP 4.17 → branch/enterprise-4.17
  • OCP 4.18 → branch/enterprise-4.18
  • OCP 4.19 → branch/enterprise-4.19

Link to docs preview:

QE review:

@openshift-ci openshift-ci bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 8, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 8, 2025 •
edited
Loading

🤖 Fri Apr 18 10:13:43 - Prow CI generated the docs preview:

https://91828--ocpdocs-pr.netlify.app/openshift-enterprise/latest/migration_toolkit_for_containers/mtc-migrating-vms.html

@anarnold97 anarnold97 changed the title MIG mtv vm storage migration MIG-1620: MTV VM storage migration Apr 8, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 8, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 8, 2025 •
edited by openshift-ci bot
Loading

@anarnold97: This pull request references MIG-1620 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

JIRA

Version(s):

  • OCP 4.14 → branch/enterprise-4.14
  • OCP 4.15 → branch/enterprise-4.15
  • OCP 4.16 → branch/enterprise-4.16
  • OCP 4.17 → branch/enterprise-4.17
  • OCP 4.18 → branch/enterprise-4.18
  • OCP 4.19 → branch/enterprise-4.19

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@anarnold97 anarnold97 changed the title MIG-1620: MTV VM storage migration MIG-1620: MTC VM storage migration Apr 8, 2025
awels
awels reviewed Apr 9, 2025
View reviewed changes
Copy link

@awels awels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yan's comments are correct, looks good otherwise.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 9, 2025 •
edited by openshift-ci bot
Loading

@anarnold97: This pull request references MIG-1620 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

JIRA

Version(s):

  • OCP 4.14 → branch/enterprise-4.14
  • OCP 4.15 → branch/enterprise-4.15
  • OCP 4.16 → branch/enterprise-4.16
  • OCP 4.17 → branch/enterprise-4.17
  • OCP 4.18 → branch/enterprise-4.18
  • OCP 4.19 → branch/enterprise-4.19

Link to docs preview:

QE review:

  • QE has approved this change.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@anarnold97
Copy link
Contributor Author

@duyanyan & @awels

Thanks for the review

Just one other thing to ask you please, is please can you just validate the the Preview

I have pulled in a new module:

Please, can you look at this and provide suggestions that are required for VM storage migration?

Thanks again

@duyanyan
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 17, 2025
@awels
Copy link

awels commented Apr 17, 2025

/lgtm

@anarnold97
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 17, 2025
@anarnold97
Copy link
Contributor Author

/label mtc

@openshift-ci openshift-ci bot added the MTC Label for all MTC PRs label Apr 17, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 18, 2025

New changes are detected. LGTM label has been removed.

@anarnold97 anarnold97 force-pushed the 4.17-MIG-1620-MTV-VM-storage-migration branch from 3344dab to 370c26c Compare April 18, 2025 10:03
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 18, 2025 •
edited by openshift-ci bot
Loading

@anarnold97: This pull request references MIG-1620 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.19.0" version, but no target version was set.

In response to this:

JIRA

Version(s):

  • OCP 4.14 → branch/enterprise-4.14
  • OCP 4.15 → branch/enterprise-4.15
  • OCP 4.16 → branch/enterprise-4.16
  • OCP 4.17 → branch/enterprise-4.17
  • OCP 4.18 → branch/enterprise-4.18
  • OCP 4.19 → branch/enterprise-4.19

Link to docs preview:

QE review:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@anarnold97
Copy link
Contributor Author

@lpettyjo - thanks

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 18, 2025

@anarnold97: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@anarnold97
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Apr 18, 2025
@sheriff-rh sheriff-rh added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Apr 18, 2025
sheriff-rh
sheriff-rh approved these changes Apr 18, 2025
View reviewed changes
Copy link
Contributor

@sheriff-rh sheriff-rh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, merging.

@sheriff-rh sheriff-rh merged commit 6bc0fa8 into openshift:main Apr 18, 2025
2 checks passed
@sheriff-rh
Copy link
Contributor

/cherrypick enterprise-4.19

@sheriff-rh
Copy link
Contributor

/cherrypick enterprise-4.18

@sheriff-rh
Copy link
Contributor

/cherrypick enterprise-4.17

@sheriff-rh
Copy link
Contributor

/cherrypick enterprise-4.16

@sheriff-rh
Copy link
Contributor

/cherrypick enterprise-4.15

@sheriff-rh
Copy link
Contributor

/cherrypick enterprise-4.14

@openshift-cherrypick-robot
Copy link

@sheriff-rh: new pull request created: #92360

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 18, 2025
Merged
@openshift-cherrypick-robot
Copy link

@sheriff-rh: new pull request created: #92361

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 18, 2025
Merged
@openshift-cherrypick-robot
Copy link

@sheriff-rh: new pull request created: #92362

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 18, 2025
Merged
@openshift-cherrypick-robot
Copy link

@sheriff-rh: new pull request created: #92363

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 18, 2025
Merged
@openshift-cherrypick-robot
Copy link

@sheriff-rh: new pull request created: #92364

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 18, 2025
Merged
@openshift-cherrypick-robot
Copy link

@sheriff-rh: new pull request created: #92365

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awels awels awels left review comments

@duyanyan duyanyan duyanyan left review comments

@lpettyjo lpettyjo lpettyjo left review comments

@sheriff-rh sheriff-rh sheriff-rh approved these changes

Assignees

@awels awels

@duyanyan duyanyan

Labels
branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. merge-review-in-progress Signifies that the merge review team is reviewing this PR MTC Label for all MTC PRs peer-review-done Signifies that the peer review team has reviewed this PR size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@anarnold97 @ocpdocs-previewbot @openshift-ci-robot @duyanyan @awels @sheriff-rh @openshift-cherrypick-robot @lpettyjo