-
Notifications
You must be signed in to change notification settings - Fork 1.8k
MTC 1.8.6 does not support multiple migplans per namespace #91832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MTC 1.8.6 does not support multiple migplans per namespace #91832
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/label mtc |
/label peer-review-needed |
/label peer-review-in-progress |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a small grammatical suggestion.
@xenolinux PTAL! Thanks. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shreyasiddhartha @anarnold97
For the follow-up peer review - left one comment
/label peer-review-done |
956caf4
to
4864108
Compare
Signed-off-by: A.Arnold <[email protected]>
effbb70
to
bcc8a32
Compare
@anarnold97: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/label merge-review-needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/cherrypick enterprise-4.19 |
/cherrypick enterprise-4.18 |
/cherrypick enterprise-4.17 |
/cherrypick enterprise-4.16 |
/cherrypick enterprise-4.15 |
/cherrypick enterprise-4.14 |
@ShaunaDiaz: new pull request created: #92464 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@ShaunaDiaz: new pull request created: #92466 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@ShaunaDiaz: new pull request created: #92468 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@ShaunaDiaz: new pull request created: #92469 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@ShaunaDiaz: new pull request created: #92471 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@ShaunaDiaz: new pull request created: #92472 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
JIRA
Version(s):
Link to docs preview:
QE review: