Skip to content

OSDOCS-13820: Adding Kueue about docs #91855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2025
Merged

OSDOCS-13820: Adding Kueue about docs #91855

merged 1 commit into from
Apr 22, 2025

Conversation

abrennan89
Copy link
Contributor

@abrennan89 abrennan89 commented Apr 8, 2025 •
edited
Loading

Version(s):
Merge to kueue-docs branch only. For Kueue GA docs.

Issue:
https://issues.redhat.com/browse/OSDOCS-13820

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 8, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 8, 2025 •
edited by openshift-ci bot
Loading

@abrennan89: This pull request references OSDOCS-13820 which is a valid jira issue.

In response to this:

Version(s):
Merge to kueue-docs branch only. For Kueue GA docs.

Issue:
https://issues.redhat.com/browse/OSDOCS-13820

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 8, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 8, 2025 •
edited
Loading

🤖 Mon Apr 14 16:08:28 - Prow CI generated the docs preview:

https://91855--ocpdocs-pr.netlify.app/
https://91855--ocpdocs-pr.netlify.app/openshift-kueue/latest/welcome/about-kueue.html
https://91855--ocpdocs-pr.netlify.app/openshift-kueue/latest/welcome/index.html

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 8, 2025 •
edited by openshift-ci bot
Loading

@abrennan89: This pull request references OSDOCS-13820 which is a valid jira issue.

In response to this:

Version(s):
Merge to kueue-docs branch only. For Kueue GA docs.

Issue:
https://issues.redhat.com/browse/OSDOCS-13820

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@kalexand-rh
Copy link
Contributor

/retest

@abrennan89 abrennan89 force-pushed the kueue-about branch 2 times, most recently from ab35ca6 to ced9e60 Compare April 8, 2025 20:16
kannon92
kannon92 reviewed Apr 8, 2025
View reviewed changes
kannon92
kannon92 reviewed Apr 8, 2025
View reviewed changes
@openshift-ci openshift-ci bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 9, 2025
@openshift-ci openshift-ci bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 9, 2025
@abrennan89 abrennan89 force-pushed the kueue-about branch 2 times, most recently from c289bae to 8cd8bc0 Compare April 10, 2025 19:40
kannon92
kannon92 reviewed Apr 11, 2025
View reviewed changes
kannon92
kannon92 reviewed Apr 11, 2025
View reviewed changes
kannon92
kannon92 reviewed Apr 11, 2025
View reviewed changes
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 14, 2025

@abrennan89: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

kannon92
kannon92 reviewed Apr 14, 2025
View reviewed changes
Copy link

@kannon92 kannon92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking my suggestions.

LGTM.

Minus the TODO for diagram, but not sure if that is required for your first merge.

@abrennan89
Copy link
Contributor Author

@kannon92 it's not a requirement, it's actually something we'd need to raise a separate issue to work on, and since it's not a blocker I will likely add this either as a stretch goal for GA or post GA work.
Thanks so much for the reviews!

@cpmeadors
Copy link

/lgtm
QE approval

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2025
@abrennan89 abrennan89 changed the title [WIP] OSDOCS-13820: Adding Kueue about docs OSDOCS-13820: Adding Kueue about docs Apr 16, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 16, 2025
@abrennan89 abrennan89 added peer-review-needed Signifies that the peer review team needs to review this PR do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Apr 16, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 16, 2025 •
edited by openshift-ci bot
Loading

@abrennan89: This pull request references OSDOCS-13820 which is a valid jira issue.

In response to this:

Version(s):
Merge to kueue-docs branch only. For Kueue GA docs.

Issue:
https://issues.redhat.com/browse/OSDOCS-13820

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 16, 2025
@lpettyjo lpettyjo added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 16, 2025
@lpettyjo lpettyjo self-requested a review April 16, 2025 18:31
lpettyjo
lpettyjo reviewed Apr 16, 2025
View reviewed changes
Copy link
Contributor

@lpettyjo lpettyjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lpettyjo lpettyjo added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Apr 16, 2025
@abrennan89
Copy link
Contributor Author

/cherrypick kueue-docs

@openshift-cherrypick-robot
Copy link

@abrennan89: I cannot cherry-pick the present PR on top of its base branch (kueue-docs).

In response to this:

/cherrypick kueue-docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@abrennan89 abrennan89 merged commit 62d1063 into openshift:kueue-docs Apr 22, 2025
2 checks passed
@openshift-cherrypick-robot
Copy link

@abrennan89: base branch (kueue-docs) needs to differ from target branch (kueue-docs)

In response to this:

/cherrypick kueue-docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kannon92 kannon92 kannon92 left review comments

@lpettyjo lpettyjo lpettyjo left review comments

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

Assignees

@cpmeadors cpmeadors

Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@abrennan89 @openshift-ci-robot @ocpdocs-previewbot @kalexand-rh @cpmeadors @openshift-cherrypick-robot @kannon92 @lpettyjo @ocpdocs-vale-bot