Skip to content

OADP-3921 remove cpu limits #91970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2025
Merged

OADP-3921 remove cpu limits #91970

merged 1 commit into from
Apr 23, 2025

Conversation

shdeshpa07
Copy link
Contributor

@shdeshpa07 shdeshpa07 commented Apr 10, 2025 •
edited
Loading

Jira

Remove CPU limits

Version

  • OCP 4.13 → OCP 4.19

Preview

QE Review

  • QE has approved this change.

@shdeshpa07
Copy link
Contributor Author

/label OADP

@openshift-ci openshift-ci bot added OADP Label for all OADP PRs size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 10, 2025
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Apr 10, 2025 •
edited
Loading

🤖 Wed Apr 23 08:46:42 - Prow CI generated the docs preview:

https://91970--ocpdocs-pr.netlify.app/openshift-enterprise/latest/backup_and_restore/application_backup_and_restore/installing/about-installing-oadp.html

@shdeshpa07
Copy link
Contributor Author

@weshayutin @stillalearner - Could you please review this PR? Thanks.

ocpdocs-vale-bot
ocpdocs-vale-bot reviewed Apr 10, 2025
View reviewed changes
modules/oadp-backup-restore-for-large-usage.adoc Outdated
====

Testing detected no CPU limiting or memory saturation with these resource specifications.
Customers can tune their OpenShift environments based on the their analysis and preference. Red Hat does not recommend using CPU limits in environments where Kopia is required.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 [error] RedHat.Spacing: Keep one space between words in 'preference. Red'. For more information, see RedHat.Spacing.

@shdeshpa07
Copy link
Contributor Author

@weshayutin - Could you please review again? I have added a little context. Thanks.

stillalearner
stillalearner approved these changes Apr 22, 2025
View reviewed changes
Copy link

@stillalearner stillalearner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shdeshpa07 shdeshpa07 force-pushed the oadp3921-remove-cpu-limits branch from c103bf3 to 16bf367 Compare April 22, 2025 09:13
@shdeshpa07
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Apr 22, 2025
@lahinson lahinson added peer-review-in-progress Signifies that the peer review team is reviewing this PR and removed peer-review-needed Signifies that the peer review team needs to review this PR labels Apr 22, 2025
lahinson
lahinson reviewed Apr 22, 2025
View reviewed changes
Copy link
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I left a few comments based on IBM Style guidance.

@lahinson lahinson added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR labels Apr 22, 2025
@shdeshpa07 shdeshpa07 force-pushed the oadp3921-remove-cpu-limits branch from 5bb40f5 to 62cd080 Compare April 23, 2025 06:04
@shdeshpa07
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Apr 23, 2025
@agantony agantony added merge-review-in-progress Signifies that the merge review team is reviewing this PR and removed merge-review-needed Signifies that the merge review team needs to review this PR labels Apr 23, 2025
agantony
agantony reviewed Apr 23, 2025
View reviewed changes
Copy link
Contributor

@agantony agantony left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Highlighted a few style guide issues; overall lgtm!

@agantony agantony removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Apr 23, 2025
@agantony
Copy link
Contributor

Merge review completed

@shdeshpa07 shdeshpa07 force-pushed the oadp3921-remove-cpu-limits branch from dccae26 to 235c5a5 Compare April 23, 2025 08:35
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Apr 23, 2025

@shdeshpa07: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@shdeshpa07
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Apr 23, 2025
@agantony agantony added this to the Continuous Release milestone Apr 23, 2025
@agantony agantony merged commit 4ad0cfa into openshift:main Apr 23, 2025
2 checks passed
@agantony
Copy link
Contributor

/cherrypick enterprise-4.19

@agantony
Copy link
Contributor

/cherrypick enterprise-4.18

@agantony
Copy link
Contributor

/cherrypick enterprise-4.17

@agantony
Copy link
Contributor

/cherrypick enterprise-4.16

@agantony
Copy link
Contributor

/cherrypick enterprise-4.15

@agantony
Copy link
Contributor

/cherrypick enterprise-4.14

@agantony
Copy link
Contributor

/cherrypick enterprise-4.13

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 23, 2025
Merged
@openshift-cherrypick-robot
Copy link

@agantony: new pull request created: #92517

In response to this:

/cherrypick enterprise-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot
Copy link

@agantony: new pull request created: #92518

In response to this:

/cherrypick enterprise-4.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 23, 2025
Merged
@openshift-cherrypick-robot
Copy link

@agantony: new pull request created: #92519

In response to this:

/cherrypick enterprise-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 23, 2025
Merged
@openshift-cherrypick-robot
Copy link

@agantony: new pull request created: #92520

In response to this:

/cherrypick enterprise-4.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 23, 2025
Merged
@openshift-cherrypick-robot
Copy link

@agantony: new pull request created: #92521

In response to this:

/cherrypick enterprise-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 23, 2025
Merged
@openshift-cherrypick-robot
Copy link

@agantony: new pull request created: #92522

In response to this:

/cherrypick enterprise-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 23, 2025
Merged
@agantony agantony removed the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Apr 23, 2025
@shdeshpa07 shdeshpa07 mentioned this pull request Apr 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshayutin weshayutin weshayutin left review comments

@lahinson lahinson lahinson left review comments

@ocpdocs-vale-bot ocpdocs-vale-bot ocpdocs-vale-bot left review comments

@stillalearner stillalearner stillalearner approved these changes

@agantony agantony agantony approved these changes

Assignees
No one assigned
Labels
branch/enterprise-4.13 branch/enterprise-4.14 branch/enterprise-4.15 branch/enterprise-4.16 branch/enterprise-4.17 branch/enterprise-4.18 branch/enterprise-4.19 lgtm Indicates that a PR is ready to be merged. OADP Label for all OADP PRs peer-review-done Signifies that the peer review team has reviewed this PR size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
Continuous Release
Development

Successfully merging this pull request may close these issues.
9 participants
@shdeshpa07 @ocpdocs-previewbot @agantony @openshift-cherrypick-robot @weshayutin @stillalearner @lahinson @ocpdocs-vale-bot @CarmiWisemon